Skip to content

Update github CreatePullRequestReview schema to allow line or position #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

ashwin-ant
Copy link
Member

Description

Allow either line or position in PR review comments, but not both, to align with GitHub API functionality.

🤖 Generated with Claude Code

Server Details

  • Server: github
  • Changes to: tools

Motivation and Context

Adding the ability to submit pull requests with line numbers instead of line positions. GitHub's API supports both: https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request

How Has This Been Tested?

Verified in MCP inspector and in Claude Code

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Allow either line or position in PR review comments, but not both,
to align with GitHub API functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ashwin-ant ashwin-ant merged commit 53a5410 into main Apr 7, 2025
28 checks passed
@ashwin-ant ashwin-ant deleted the ashwin/github branch April 7, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants