Use info level when starting up server #1279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaservo
reviewed
Apr 11, 2025
| @@ -367,7 +367,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => { | |||
| async function runServer() { | |||
| const transport = new StdioServerTransport(); | |||
| await server.connect(transport); | |||
| console.error("Brave Search MCP Server running on stdio"); | |||
There was a problem hiding this comment.
I think that this needs to stay console.error since stdio is being used as the server transport. I made the same correction on servers before and Claude Desktop started throwing errors.
There was a problem hiding this comment.
Maybe we can leave a comment here to indicate that reasoning then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed server startup logging from error level to info level to better reflect the non-error nature of the startup message.
Server Details
Motivation and Context
The server startup message was incorrectly using error level logging, which could cause confusion during monitoring and potentially trigger false alarms in log analysis systems. Using info level is more appropriate for operational status messages that don't indicate problems.
How Has This Been Tested?
Verified server starts correctly with the new logging level and that the message appears properly in logs.
Breaking Changes
None. This is purely a server-side logging change with no impact on client functionality.
Types of changes
Checklist
Additional context
This change aligns with standard logging practices where error level should be reserved for actual error conditions.