Skip to content

Commit e95f60c

Browse files
committed
Problem: use of underscore in package names
1. It is hard to visually differentiate "_" and "-" 2. Debian (support is coming!) does not allow underscores Solution: use the plus sign ("+") instead It definitely gives more visual signalling and is allowed in Debian.
1 parent 392962c commit e95f60c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/pgpm/rpm/spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ def versionless
2424
License: #{@package.license}
2525
2626
BuildRequires: #{@postgres_distribution.build_time_requirement_packages.join(" ")}
27-
Requires: pgpm-#{@package.name}-#{@postgres_distribution.version}_#{@package.version}
28-
BuildRequires: pgpm-#{@package.name}-#{@postgres_distribution.version}_#{@package.version}
27+
Requires: pgpm-#{@package.name}+#{@package.version}-#{@postgres_distribution.version}
28+
BuildRequires: pgpm-#{@package.name}+#{@package.version}-#{@postgres_distribution.version}
2929
BuildArch: noarch
3030
3131
%description
@@ -62,7 +62,7 @@ def to_s
6262
end
6363

6464
<<~EOF
65-
Name: pgpm-#{@package.name}-#{@postgres_distribution.version}_#{@package.version}
65+
Name: pgpm-#{@package.name}+#{@package.version}-#{@postgres_distribution.version}
6666
Version: 1
6767
Release: 1%{?dist}
6868
Summary: #{@package.summary}

0 commit comments

Comments
 (0)