[add] Implementation of the Beta Negative Binomial Distribution #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
approved these changes
May 26, 2025
There was a problem hiding this comment.
Thanks @ShozenD! I think we can address cdf icdf later if needed.
Could you add an entry for this distribution in https://github.com/pyro-ppl/numpyro/blob/master/docs/source/distributions.rst ?
|
Hi @ShozenD, could you merge with master and add the distribution to the doc index? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation proposal for [Issue #2030].
So far all unit tests are passing (including documentation tests).
I have not implemented the CDF (also not available in the most recent version of scipy).
Stan does seem to provide a CDF implementation.
Does anyone know what is the best way to do this?