Skip to content

Optimize w8a8 quantized matmul kernel #9412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 1, 2025
Merged

Optimize w8a8 quantized matmul kernel #9412

merged 7 commits into from
Jul 1, 2025
+172 −111

Conversation

vanbasten23
Copy link
Collaborator

@vanbasten23 vanbasten23 commented Jun 26, 2025 •
edited
Loading

This PR

  • updated the block table.
  • fall back to xla w8a8 quantized matmul if the block sizes are not found.

Test plan:

  • pytest pytorch/xla/test/test_quantized_matmul_pallas_kernel.py -s
  • python pytorch/xla/test/test_pallas.py -k test_quantized_matmul_int8

@vanbasten23 vanbasten23 marked this pull request as ready for review June 27, 2025 23:20
yaochengji
yaochengji reviewed Jun 28, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xiongfei for your conribution!

@vanbasten23 vanbasten23 requested a review from yaochengji June 28, 2025 02:05
yaochengji
yaochengji approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@vanbasten23
Copy link
Collaborator Author

The CI has been failing prior to this PR (eg #9415) and seems irrelevant to this PR.

@vanbasten23
Copy link
Collaborator Author

I also created an empty change #9430 and the same CI also fails.

@yaochengji yaochengji merged commit 4101ea5 into master Jul 1, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaochengji yaochengji yaochengji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanbasten23 @yaochengji