feat(react navigation): use static screens configuration #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
force-pushed
the
dannyhw/feat-static-react-navigation
branch
from
989739e to
8a04f0d
Compare
dannyhw
changed the title
|
@jpudysz thoughts on this? |
jpudysz
suggested changes
Jun 2, 2025
cli/src/templates/packages/react-navigation/navigation/tab-navigator.tsx.ejs
Show resolved
Hide resolved
fix fix fix fix: unistyles warning feat: use rnn theme together with unistyles theme remove file
dannyhw
force-pushed
the
dannyhw/feat-static-react-navigation
branch
from
d205331 to
4ae6f71
Compare
satya164
reviewed
Jun 14, 2025
jpudysz
approved these changes
Jun 16, 2025
Renamed type to better reflect that it represents the root navigator's param list, not specifically a stack. This aligns with the Navigation component naming convention.
satya164
approved these changes
Jun 28, 2025
- Use DarkTheme/DefaultTheme instead of merging with dark property - Replace useEffect with Navigation onReady prop for SplashScreen - Clean up theme selection with cleaner useMemo syntax - Remove unused useEffect import from Tamagui section
|
I believe this has now addressed all comments I think its ready to go @danstepanov |
danstepanov
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moves templates to the static configuration
note that I moved to the stylesheet api for unistyles because the config is static so its more complicated to use a hook in the setup of the screen options
Related Issue
Motivation and Context
its the suggested way by the react navigation team
How Has This Been Tested?
tested with these combinations
Screenshots (if appropriate):