Handle potentially-shadowing bindings in manual_let_else
#15118
Merged
+218
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
notriddle
force-pushed
the
notriddle/issue-9939
branch
2 times, most recently
from
ba936e3 to
1007571
Compare
This commit also adds more test cases, which work fine but were mentioned in the issue.
notriddle
force-pushed
the
notriddle/issue-9939
branch
from
1007571 to
cd68244
Compare
llogiq
approved these changes
Jul 6, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also adds more test cases, which already worked but were mentioned in the issue.
Fixes #9939
changelog: [
manual_let_else]: correctly handle binding subpattern with unused name