-
Notifications
You must be signed in to change notification settings - Fork 0
feature: NVRHI #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: NVRHI #19
Conversation
I have to figure out how to implement it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Integrate the NVRHI rendering abstraction into the build system and update the ImGui layer to target a newer GLSL version.
- Add NVRHI as a submodule and include path.
- Update premake scripts to include and link NVRHI for both engine and editor.
- Bump ImGui OpenGL backend shader version from 410 to 450.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
premake5.lua | Register new “Dependencies – NVRHI” group |
StarEngine/src/StarEngine/ImGui/ImGuiLayer.cpp | Updated ImGui OpenGL GLSL version to 450 |
StarEngine/premake5.lua | Added NVRHI include dir and linked libraries |
StarEditor/premake5.lua | Added NVRHI include directory for the editor |
Dependencies.lua | Added IncludeDir["nvrhi"] path |
.gitmodules | Added NVRHI submodule entry |
Comments suppressed due to low confidence (2)
StarEditor/premake5.lua:26
- The editor project includes the NVRHI header path but does not link the NVRHI library. You should add "nvrhi" to the
links
block so the editor can resolve its symbols.
%{IncludeDir.nvrhi},
premake5.lua:37
- [nitpick] The indentation for this
include
line doesn’t match the single-tab style used elsewhere. Align it with the other dependency entries for consistency.
include "StarEngine/vendor/nvrhi"
@@ -67,7 +67,7 @@ namespace StarEngine { | |||
|
|||
// Setup Platform/Renderer bindings | |||
ImGui_ImplGlfw_InitForOpenGL(window, true); | |||
ImGui_ImplOpenGL3_Init("#version 410"); | |||
ImGui_ImplOpenGL3_Init("#version 450"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Hardcoding "#version 450" enforces a minimum OpenGL 4.5 context and may break compatibility on older hardware. Consider making the GLSL version configurable or document this requirement.
ImGui_ImplOpenGL3_Init("#version 450"); | |
const char* glslVersion = "#version 450"; // Default GLSL version | |
// Optionally, retrieve GLSL version dynamically or make it configurable | |
ImGui_ImplOpenGL3_Init(glslVersion); |
Copilot uses AI. Check for mistakes.
alot more to come
No description provided.