Skip to content

🚩(frontend) feature flag on blocking edition #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented May 23, 2025

Purpose

  • 🚩(frontend) feature flag on blocking edition
  • ✏️(frontend) change antivirus fail sentence

New env var

COLLABORATION_WS_NOT_CONNECTED_READY_ONLY=[boolean]

If users were not connected to the collaboration server, they were not be able to edit documents.
We decided to add a feature flag on this feature as it can be quite restrictive.
We can now enable or disable this feature at runtime thanks to the env variable COLLABORATION_WS_NOT_CONNECTED_READY_ONLY.

See: Docs

@AntoLC AntoLC self-assigned this May 23, 2025
@AntoLC AntoLC changed the title 💄Fine tuning 3.3.0 🚩(frontend) feature flag on blocking edition May 23, 2025
@AntoLC AntoLC force-pushed the feature/fine-tuning-3.3.0 branch from b5e30a1 to cc04992 Compare May 23, 2025 08:28
@AntoLC AntoLC requested a review from lunika May 23, 2025 08:28
@AntoLC AntoLC force-pushed the feature/fine-tuning-3.3.0 branch from cc04992 to 954935d Compare May 23, 2025 09:06
@AntoLC AntoLC requested a review from lunika May 23, 2025 09:06
AntoLC added 3 commits May 23, 2025 11:08
If users were not connected to the collaboration
server, they were not be able to edit documents.

We decided to add a feature flag on this feature
as it can be quite restrictive.
We can now enable or disable this feature at runtime
thanks to the env variable
"COLLABORATION_WS_NOT_CONNECTED_READY_ONLY".
The message was not accurate when the analizer failed.
We improved the message to be more accurate.
A bunch of fixes are in this pacth release.
Better to update now before we release to 3.3.0.
@AntoLC AntoLC force-pushed the feature/fine-tuning-3.3.0 branch from 954935d to f851ef2 Compare May 23, 2025 09:08
@AntoLC AntoLC merged commit f851ef2 into main May 23, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the feature/fine-tuning-3.3.0 branch May 23, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants