Skip to content

Increase test coverage #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cheukting opened this issue Jul 23, 2020 · 3 comments · Fixed by #128
Open

Increase test coverage #123

Cheukting opened this issue Jul 23, 2020 · 3 comments · Fixed by #128
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress issue in progress mentored-sprint multi-contributors This task require multiple contributors

Comments

@Cheukting
Copy link
Contributor

Cheukting commented Jul 23, 2020

The coverage now is not very good 😞 :

Screenshot 2021-05-15 at 10 28 18


So to make it better, do the following:

  1. Pick a file that has < 80% coverage 👎🏻
  2. Check the comment below to see if someone has already taken that file
  3. Comment below which file you are going to work on. If you are only taking a part of the file, please state clearly which methods are yours.
  4. After you have written new tests (that passes ✅ when run tox, details here), check the new coverage by running make coverage in your terminal (at the dir of the repo). The goal is 80% 💪🏻
  5. When you send your PR, please link this issue by putting see #123 in the comment of your PR. Also, mention the new coverage. ⭐

Tips for writing the tests:

  • Most of the functions have the JavaScript equivalent in the JS client, you can use the result of the JS client as the "answer" for the test
  • You can use the TerminusDB console to check what the correct Json-LD of a query is (JS to Json-LD)
@Cheukting Cheukting added EuroPython2020 good first issue Good for newcomers help wanted Extra attention is needed multi-contributors This task require multiple contributors and removed good first issue Good for newcomers labels Jul 23, 2020
@Pradhvan
Copy link
Contributor

Working on this issue 😄

@Cheukting
Copy link
Contributor Author

Pump coverage session scheduled every Friday. Who's interested?

@Pradhvan
Copy link
Contributor

@Cheukting sounds like a plan. 🚀

Cheukting added a commit that referenced this issue May 16, 2021
Add unit tests for less, greater, upper and lower methods in woql_query.py (#123)
Cheukting added a commit that referenced this issue May 17, 2021
Add unit tests for sum and pad methods (#123)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress issue in progress mentored-sprint multi-contributors This task require multiple contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants