feat(security_groups): enhance unused security group detection with ENI-based approach

[dannysteenman]

GitHub Issue

#25

---

PR Type

Enhancement

---

Description

• Improved security group detection using ENI-based approach

• Enhanced type filtering based on naming conventions

• Streamlined code by removing service-specific checks

• Updated documentation for clarity and accuracy

---

Changes walkthrough 📝

	Relevant files
Enhancement	delete_unused_security_groups.py Refactor security group detection and improve documentation general/delete_unused_security_groups.py Replaced service-specific checks with ENI-based detection Updated type filtering to use naming conventions Removed unnecessary AWS client initializations Enhanced documentation and usage instructions +54/-69

[Copilot]

Pull Request Overview

This PR enhances the detection of unused security groups by shifting from service-specific checks to an ENI-based approach, streamlining AWS client usage and updating documentation accordingly.

• Replaces individual service checks with a unified ENI-based detection method.
• Updates type filtering to rely on naming conventions.
• Removes extraneous AWS client initializations and clarifies usage in the documentation.

Comments suppressed due to low confidence (2)

general/delete_unused_security_groups.py:159

• [nitpick] Consider using a multiline string or reformatting the help text for the '--type' argument to enhance readability in the CLI.

help="Specify the type of security groups to consider based on naming conventions: - all: All security groups - ec2: Security groups not starting with 'rds-' or 'elb-' - rds: Security groups starting with 'rds-' - elb: Security groups starting with 'elb-'"

general/delete_unused_security_groups.py:40

• [nitpick] Consider removing the trailing newline from the log message to maintain consistency with other log outputs.

logger.info(f"Unused Security Group IDs: {list(unused_sg)}\n")