Skip to content

Fix Add missing BadRequest 400 to object get/head API spec #9130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

Fix Add missing BadRequest 400 to object get/head API spec #9130

merged 2 commits into from
Jun 2, 2025

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Jun 2, 2025

Fix #9129

@nopcoder nopcoder requested a review from a team June 2, 2025 13:06
@nopcoder nopcoder added bug Something isn't working area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog labels Jun 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025 •
edited
Loading

♻️ PR Preview ff1d369 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@nopcoder nopcoder changed the title Add Bad Request (400) responses to API spec, client docs, and tests Fix Add Bad Request (400) to API spec Jun 2, 2025
@nopcoder nopcoder marked this pull request as ready for review June 2, 2025 13:07
@nopcoder nopcoder changed the title Fix Add Bad Request (400) to API spec Fix Add Bad Request 400 to object get/head API spec Jun 2, 2025
@nopcoder nopcoder changed the title Fix Add Bad Request 400 to object get/head API spec Fix Add missing BadRequest 400 to object get/head API spec Jun 2, 2025
itaigilo
itaigilo approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
About time, I guess.

@nopcoder
Copy link
Contributor Author

nopcoder commented Jun 2, 2025

Good catch. About time, I guess.

Need to a bigger review of the response status codes, but will try to do it incrementally.

@nopcoder nopcoder enabled auto-merge (squash) June 2, 2025 14:47
@nopcoder nopcoder merged commit a7ed576 into master Jun 2, 2025
44 checks passed
@nopcoder nopcoder deleted the fix/object-bad-request-spec branch June 2, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaigilo itaigilo itaigilo approved these changes

Assignees
No one assigned
Labels
area/API Improvements or additions to the API bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Update API spec returns 400 for Invalid Object Retrieval Requests
2 participants
@nopcoder @itaigilo