Skip to content

Remove leftovers of the use of the AWS SDK v1 in favor of the AWS SDK v2 #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Jun 5, 2025

No description provided.

@nopcoder nopcoder requested a review from a team June 5, 2025 15:10
@nopcoder nopcoder self-assigned this Jun 5, 2025
@nopcoder nopcoder added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jun 5, 2025
@nopcoder nopcoder removed the request for review from a team June 5, 2025 15:12
@itaigilo
Copy link
Contributor

itaigilo commented Jun 5, 2025

@nopcoder looks good,
But tests are failing...

@nopcoder
Copy link
Contributor Author

nopcoder commented Jun 5, 2025

will fix. the problem I have is with the delta package that still pull it in.

@nopcoder nopcoder requested a review from itaigilo June 6, 2025 08:28
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@nopcoder nopcoder merged commit 7254eb7 into master Jun 6, 2025
41 checks passed
@nopcoder nopcoder deleted the chore/remove-aws-sdk-v1 branch June 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants