Skip to content

Fix catalog init in Iceberg docs #9150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Fix catalog init in Iceberg docs #9150

merged 1 commit into from
Jun 7, 2025

Conversation

itaigilo
Copy link
Contributor

@itaigilo itaigilo commented Jun 6, 2025

No description provided.

@itaigilo itaigilo added docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jun 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

♻️ PR Preview ff95e5c has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@kesarwam
Copy link
Contributor

kesarwam commented Jun 7, 2025

import should also be changed:

from pyiceberg.catalog.rest import RestCatalog

@kesarwam
Copy link
Contributor

kesarwam commented Jun 7, 2025

Also fix this section: https://docs.lakefs.io/integrations/iceberg.html#example-client-code

nopcoder
nopcoder approved these changes Jun 7, 2025
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nopcoder nopcoder merged commit f800140 into master Jun 7, 2025
48 checks passed
@nopcoder nopcoder deleted the docs/fix-iceberg-catalog-init branch June 7, 2025 09:25
@itaigilo itaigilo mentioned this pull request Jun 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder approved these changes

@ozkatz ozkatz Awaiting requested review from ozkatz

@talSofer talSofer Awaiting requested review from talSofer

@kesarwam kesarwam Awaiting requested review from kesarwam

Assignees
No one assigned
Labels
docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itaigilo @kesarwam @nopcoder