Fix: support all refs in lakeFS log #9170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 2ba8f97 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-9170.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
guy-har
added
the
include-changelog
guy-har
changed the title
nopcoder
requested changes
Jun 10, 2025
cmd/lakectl/cmd/log.go
Outdated
| @@ -81,9 +81,9 @@ func filterMergeCommits(commits []apigen.Commit) []apigen.Commit { | |||
|
|
|||
| // logCmd represents the log command | |||
| var logCmd = &cobra.Command{ | |||
| Use: "log <branch URI>", | |||
| Use: "log <Ref URI>", | |||
There was a problem hiding this comment.
Suggested change
| Use: "log <Ref URI>", | |
| Use: "log <ref URI>", |
cmd/lakectl/cmd/log.go
Outdated
| Short: "Show log of commits", | ||
| Long: "Show log of commits for a given branch", | ||
| Long: "Show log of commits for a given Ref", |
There was a problem hiding this comment.
Suggested change
| Long: "Show log of commits for a given Ref", | |
| Long: "Show log of commits for a given a ref", |
cmd/lakectl/cmd/log.go
Outdated
| @@ -109,7 +109,7 @@ var logCmd = &cobra.Command{ | |||
| pagination := apigen.Pagination{HasMore: true} | |||
| showMetaRangeID := Must(cmd.Flags().GetBool("show-meta-range-id")) | |||
| client := getClient() | |||
| branchURI := MustParseBranchURI("branch URI", args[0]) | |||
| RefURI := MustParseRefURI("Ref URI", args[0]) | |||
There was a problem hiding this comment.
Suggested change
| RefURI := MustParseRefURI("Ref URI", args[0]) | |
| refURI := MustParseRefURI("ref URI", args[0]) |
cmd/lakectl/cmd/log.go
Outdated
| @@ -141,14 +141,14 @@ var logCmd = &cobra.Command{ | |||
|
|
|||
| graph := &dotWriter{ | |||
| w: os.Stdout, | |||
| repositoryID: branchURI.Repository, | |||
| repositoryID: RefURI.Repository, | |||
There was a problem hiding this comment.
Suggested change
| repositoryID: RefURI.Repository, | |
| repositoryID: refURI.Repository, |
cmd/lakectl/cmd/log.go
Outdated
| } | ||
| if dot { | ||
| graph.Start() | ||
| } | ||
|
|
||
| for pagination.HasMore { | ||
| resp, err := client.LogCommitsWithResponse(cmd.Context(), branchURI.Repository, branchURI.Ref, logCommitsParams) | ||
| resp, err := client.LogCommitsWithResponse(cmd.Context(), RefURI.Repository, RefURI.Ref, logCommitsParams) |
There was a problem hiding this comment.
Suggested change
| resp, err := client.LogCommitsWithResponse(cmd.Context(), RefURI.Repository, RefURI.Ref, logCommitsParams) | |
| resp, err := client.LogCommitsWithResponse(cmd.Context(), refURI.Repository, refURI.Ref, logCommitsParams) |
guy-har
force-pushed
the
fix/lakectl-log-arg
branch
from
35c24bb to
2ba8f97
Compare
nopcoder
added
the
area/lakectl
arielshaqed
reviewed
Jun 11, 2025
| @@ -168,7 +168,6 @@ var logCmd = &cobra.Command{ | |||
| After: pagination.NextOffset, | |||
| }, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: whitespace changes.
nopcoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.