Python HL SDK: pre-signed urls in stat()
#9180
Conversation
ozkatz
added
include-changelog
| @@ -676,13 +676,15 @@ def reader(self, mode: ReadModes = 'rb', pre_sign: Optional[bool] = None) -> Obj | |||
| """ | |||
| return ObjectReader(self, mode=mode, pre_sign=pre_sign, client=self._client) | |||
|
|
|||
| def stat(self) -> ObjectInfo: | |||
| def stat(self, pre_sign: Optional[bool] = None) -> ObjectInfo: | |||
There was a problem hiding this comment.
- Because we use named parameters, consider using the name param name 'presign'.
- Why not include user metadata and close the issue?
There was a problem hiding this comment.
convolutes the caching behavior. If I cached an object with no user_metadata and now I request it with user_metadata, I need to make sure not to use the cached version (and vice versa).
As for pre_sign vs presign - I decided to adopt the style of the surrounding code (see for example the reader() method above)
| """ | ||
| Return the Stat object representing this object | ||
| """ | ||
| if self._stats is None: | ||
| # don't cache pre-signed stats |
There was a problem hiding this comment.
Q. did we had a requirement to add caching? it works for a single app, but any change from outside the app will make this case invalid. it is also true for committed data if we enable retention.
There was a problem hiding this comment.
I believe it was added because there are access patterns that might stat frequently. I'm ok with revisiting this decision but maybe not as part of this PR :)
Partially closes #9070 (pre-signed URLs only for now)