Skip to content

webui: update caniuse browserlist db #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

webui: update caniuse browserlist db #9194

merged 1 commit into from
Jun 19, 2025

Conversation

nopcoder
Copy link
Contributor

Update can I use browserslist DB

@nopcoder nopcoder requested a review from a team June 17, 2025 13:49
@nopcoder nopcoder self-assigned this Jun 17, 2025
@nopcoder nopcoder added infrastructure build, deploy and release processes exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Jun 17, 2025
arielshaqed
arielshaqed requested changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we update package-lock.json manually. I would expect such an override to update package.json, and then npm to shake caniuse appropriately. In fact, the word "caniuse" appears some 11 times in package-lock.json, and this PR changes only 2 of them.

I will very happily unblock if you explain what I don't understand; I will happily unblock if you just tell me I am wrong.

@nopcoder
Copy link
Contributor Author

didn't update manually. the package comes with a script that asks if you like to update and this is the result. the package is a database that warn about use of API compatibility and not functionality.

@nopcoder nopcoder requested a review from arielshaqed June 18, 2025 06:31
arielshaqed
arielshaqed approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Didn't realize it's just the result of running the command the package says to run. If so, please just add the command you ran... and pull!

@arielshaqed
Copy link
Contributor

clay pigeon "pull!"

@nopcoder
Copy link
Contributor Author

Cool, thanks! Didn't realize it's just the result of running the command the package says to run. If so, please just add the command you ran... and pull!

npx update-browserslist-db@latest

@nopcoder nopcoder merged commit 2034779 into master Jun 19, 2025
48 checks passed
@nopcoder nopcoder deleted the chore/update-browserslist-db branch June 19, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@nopcoder nopcoder

Labels
exclude-changelog PR description should not be included in next release changelog infrastructure build, deploy and release processes minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopcoder @arielshaqed