Skip to content

[Fix] import regex instead of re #19875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Conversation

tdoublep
Copy link
Member

The pre-commits checks are currently failing on main because xlam_tool_parser.py is using import re. This is a quick and tiny fix.

Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
@tdoublep tdoublep requested a review from aarnphm as a code owner June 19, 2025 17:13
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tdoublep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a pre-commit linting issue that was causing failures on the main branch. The change involves a minor adjustment to an import statement, ensuring that the codebase adheres to established coding standards and passes automated checks.

Highlights

  • Linting Fix: Addressed a pre-commit linting failure by updating the regular expression module import in xlam_tool_parser.py.
  • Dependency Update: Switched the import from Python's built-in re module to the regex library, aliasing it as re, to comply with project linting standards.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR replaces the re module with the regex module in xlam_tool_parser.py to address a linting issue. The change aligns with the project's pre-commit checks and is consistent with the use of regex in other parts of the codebase, such as protocol.py. The regex library is aliased to re for seamless integration. This change improves maintainability by adhering to project linting standards. No issues of medium or higher severity were found.

@aarnphm aarnphm changed the title xlam_tool_parser.py: Fix regex linting issue [Fix] import regex instead of re Jun 19, 2025
@aarnphm aarnphm enabled auto-merge (squash) June 19, 2025 18:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 19, 2025
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@tdoublep
Copy link
Member Author

The v1-test seems to be hanging until timeout, despite being re-tried multiple times.


[2025-06-20T05:22:36Z] WARNING 06-19 22:22:36 [utils.py:2756] Methods determine_num_available_blocks,device_config,get_cache_block_size_bytes not implemented in <vllm.v1.worker.gpu_worker.Worker object at 0x7fbd63e82870>
--
  | [2025-06-20T05:22:36Z] DEBUG 06-19 22:22:36 [config.py:4731] enabled custom ops: Counter()
  | [2025-06-20T05:22:36Z] DEBUG 06-19 22:22:36 [config.py:4733] disabled custom ops: Counter()
  | [2025-06-20T05:22:37Z] DEBUG 06-19 22:22:37 [parallel_state.py:918] world_size=1 rank=0 local_rank=0 distributed_init_method=tcp://172.16.0.2:40627 backend=nccl
  | [2025-06-20T05:22:37Z] INFO 06-19 22:22:37 [parallel_state.py:1072] rank 0 in world size 1 is assigned as DP rank 0, PP rank 0, TP rank 0, EP rank 0
  | [2025-06-20T05:22:37Z] INFO 06-19 22:22:37 [topk_topp_sampler.py:49] Using FlashInfer for top-p & top-k sampling.
  | [2025-06-20T05:22:46Z] DEBUG 06-19 22:22:46 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:22:56Z] DEBUG 06-19 22:22:56 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:23:06Z] DEBUG 06-19 22:23:06 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:23:16Z] DEBUG 06-19 22:23:16 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:23:26Z] DEBUG 06-19 22:23:26 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:23:36Z] DEBUG 06-19 22:23:36 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.
  | [2025-06-20T05:23:46Z] DEBUG 06-19 22:23:46 [utils.py:485] Waiting for 1 local, 0 remote core engine proc(s) to start.


Is this a known issue?

@tdoublep
Copy link
Member Author

nvm, presumably it is solved by this: #19872

have rebased

@aarnphm aarnphm merged commit 7771d1d into vllm-project:main Jun 20, 2025
70 checks passed
@tdoublep tdoublep deleted the tpa-xlam-regex branch June 20, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed tool-calling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants