Skip to content

Don't retry image recommendation API too aggressively. #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Jun 17, 2025

We were retrying the image recommendations API too frequently, which leads to an unintentional error, instead of the proper UI verbiage that informs the user that Image Recs are not available.

https://phabricator.wikimedia.org/T397104

@dbrant dbrant added Minor Minor stuff High Priority Priority code review needed labels Jun 17, 2025
@Williamrai Williamrai merged commit 7b90b40 into main Jun 17, 2025
1 check passed
@Williamrai Williamrai deleted the imageRecRetries branch June 17, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Priority code review needed Minor Minor stuff
Development

Successfully merging this pull request may close these issues.

2 participants