Add support for captcha when logging in. #5692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
added
Ready to merge
cooltey
requested changes
Jun 20, 2025
There was a problem hiding this comment.
Found some issues:
- After entering an incorrect password multiple times, a CAPTCHA appears. However, if I then enter either the wrong CAPTCHA or the wrong password, no error message is displayed.
- After a couple of retries from 1., I entered the correct password and the correct captcha text, but somehow I was unable to log in.
- The link in the message "Can't see the image?..." guides the user to the
Wikipedia:Request an accountpage, not sure if it is the correct wiki page for account login.
Fixed: this will now display an error. However, unfortunately the error when entering an incorrect captcha is still "Incorrect password". This seems to be a limitation of the API, and will need to be addressed in future updates.
I was unable to reproduce this. If you see this behavior again, does it show any errors or messages now?
Agreed - let's remove this message, which will make it consistent with mobile web. |
cooltey
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
It works for me now! Thanks 👍
@Williamrai please help to review and merge if it looks good to you too, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T396403