Gateway GZ80x: Add rtl8723ds bluetooth support
#8351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
It loads the mmc-pwrseq twice and produces pinctrl errors. [ 9.860451] meson-axg-pinctrl ff634000.bus:pinctrl@480: pin BOOT_0 already requested by ffe07000.mmc; cannot claim for ffe07800.nand-controller [ 9.867791] meson-axg-pinctrl ff634000.bus:pinctrl@480: error -EINVAL: pin-11 (ffe07800.nand-controller) [ 9.870272] systemd[1]: Reached target usb-gadget.target - Hardware activated USB gadget. [ 9.877181] meson-axg-pinctrl ff634000.bus:pinctrl@480: error -EINVAL: could not request pin 11 (BOOT_0) from group emmc_nand_d0 on device pinctrl-meson [ 9.898837] meson-nand ffe07800.nand-controller: Error applying setting, reverse things back Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
pyavitz
requested review from
NicoD-SBC,
SteeManMI,
Tonymac32,
adeepn,
clee,
igorpecovnik,
monkaBlyat,
rpardini,
teknoid and
a team
as code owners
WalkthroughThe Gateway GZ80x board configuration was updated with a blacklist for kernel modules ( Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/medium
coderabbitai
bot
added
05
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/boards/gateway-gz80x.conf (1)
17-23: Improve path quoting and error handling.The firmware installation function is functionally correct but could benefit from better practices:
- Inconsistent quoting of the source path variable
- Missing error handling for the copy operation
Apply this diff to improve path quoting and add basic error handling:
function post_family_tweaks_bsp__gateway_gz80x_firmware() { - if [[ -d "$SRC/packages/bsp/gateway-gz80x/rtl_bt" ]]; then + if [[ -d "${SRC}/packages/bsp/gateway-gz80x/rtl_bt" ]]; then mkdir -p "${destination}"/lib/firmware/updates/rtl_bt display_alert "$BOARD" "Installing bluetooth firmware" "info" - cp -fr $SRC/packages/bsp/gateway-gz80x/rtl_bt/* "${destination}"/lib/firmware/updates/rtl_bt/ + cp -fr "${SRC}"/packages/bsp/gateway-gz80x/rtl_bt/* "${destination}"/lib/firmware/updates/rtl_bt/ || { + display_alert "$BOARD" "Failed to install bluetooth firmware" "err" + return 1 + } fi }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (9)
packages/bsp/gateway-gz80x/rtl_bt/rtl8723d_config.binis excluded by!**/*.binpackages/bsp/gateway-gz80x/rtl_bt/rtl8723d_config_1000000_noflow.binis excluded by!**/*.binpackages/bsp/gateway-gz80x/rtl_bt/rtl8723d_fw.binis excluded by!**/*.binpackages/bsp/gateway-gz80x/rtl_bt/rtl8723ds_config.binis excluded by!**/*.binpackages/bsp/gateway-gz80x/rtl_bt/rtl8723ds_fw.binis excluded by!**/*.binpatch/kernel/archive/meson64-6.12/dt/meson-axg-amper-gateway-am-gz80x.dtsis excluded by!patch/**patch/kernel/archive/meson64-6.12/dt/meson-axg-amper-gateway-gz80x.dtsiis excluded by!patch/**patch/kernel/archive/meson64-6.15/dt/meson-axg-amper-gateway-am-gz80x.dtsis excluded by!patch/**patch/kernel/archive/meson64-6.15/dt/meson-axg-amper-gateway-gz80x.dtsiis excluded by!patch/**
📒 Files selected for processing (1)
config/boards/gateway-gz80x.conf(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
config/boards/gateway-gz80x.conf (7)
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: Grippy98
PR: armbian/build#8202
File: config/desktop/trixie/environments/gnome/armbian/create_desktop_package.sh:2-3
Timestamp: 2025-05-16T15:34:34.672Z
Learning: The shell scripts in the Armbian build system's desktop configuration files, such as config/desktop/trixie/environments/gnome/armbian/create_desktop_package.sh, rely on environment variables like $SRC and $destination that are expected to be set externally before the script is executed.
Learnt from: djurny
PR: armbian/build#8315
File: lib/functions/rootfs/distro-agnostic.sh:54-68
Timestamp: 2025-06-22T00:45:26.182Z
Learning: In Armbian build system, external command dependencies like envsubst are handled by adding the required packages (e.g., gettext for envsubst) to host_dependencies in adaptative_prepare_host_dependencies function in lib/functions/host/prepare-host.sh, rather than checking command availability at runtime.
Learnt from: djurny
PR: armbian/build#8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.
Learnt from: EvilOlaf
PR: armbian/build#8298
File: extensions/https_proxy.sh:1-9
Timestamp: 2025-06-14T05:53:10.627Z
Learning: Armbian build framework extensions are NOT designed to run standalone but are called by the supervisor. The framework provides environment variables like USERPATCHES_PATH and SDCARD, and commands are executed with protection via run_host_command_logged and chroot_sdcard functions that use bash -e -o pipefail.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Shell script analysis
- GitHub Check: Check kernel security options
🔇 Additional comments (3)
config/boards/gateway-gz80x.conf (3)
14-14: LGTM! Module blacklisting addresses pinctrl conflicts.The blacklisting of
rtw88_8723d,rtw88_8723ds, andmeson_nandmodules correctly addresses the pin control conflicts described in the PR objectives, preventing the MMC power sequence driver from loading twice and avoiding BOOT_0 pin conflicts.
15-15: LGTM! Bluetooth packages added for rtl8723ds support.The addition of
rfkill,bluetooth,bluez, andbluez-toolspackages properly supports the Bluetooth functionality being added to the Gateway GZ80x platform.
27-27: LGTM! Improved alert message consistency.The change from "Install zwave udev rule" to "Installing zwave udev rule" improves consistency with the present tense used in the new firmware function's alert message.
Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
github-actions
bot
removed
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bluetooth support to the DTS and $board.conf, as well as the needed firmware
Enable
CONFIG_RTL8723DS=min the meson64 defconfig(s)Blacklist
meson_nand, it loads the mmc-pwrseq twice and produces pinctrl errors.