Fix odroid-c4 i2c overlays

[veduco]

Description

The existing odroid-c4 specific i2c overlay files that are shipped with Armbian 25.5.2 bookworm do not enable i2c functionality.
Applying this small modification to the source files, adding to the system and rebooting, i2c functionality is observed and able to be used.

How Has This Been Tested?

• Apply the original dtbo overlays. After a reboot, observe that i2c functionality is not enabled.
• Apply the fixed dts, compile to dtbo. After a reboot, observe that i2c functionality is enabled.

• Using existing overlay files, both meson-sm1-odroid-c4-i2c0.dtbo and meson-sm1-odroid-c4-i2c1.dtbo from /boot/dtb-6.12.32-current-meson64/amlogic/overlay/ with a /boot/armbianEnv.txt like so:

verbosity=1
console=both
overlay_prefix=meson
rootdev=UUID=4d762a48-122d-482b-9803-7eabc89c2bd8
rootfstype=ext4
user_overlays=
overlays=meson-sm1-odroid-c4-i2c0 meson-sm1-odroid-c4-i2c1
usbstoragequirks=0x2537:0x1066:u,0x2537:0x1068:u

After a reboot, observe:

~# ls -al /sys/class/i2c-dev/
total 0
drwxr-xr-x  2 root root 0 Dec 31  1969 .
drwxr-xr-x 72 root root 0 Dec 31  1969 ..
lrwxrwxrwx  1 root root 0 Dec 31  1969 i2c-0 -> ../../devices/platform/soc/ff600000.bus/ff600000.hdmi-tx/i2c-0/i2c-dev/i2c-0

• Using the included fixed overlay files, both meson-sm1-odroid-c4-i2c0.dtso and meson-sm1-odroid-c4-i2c1.dtso (files renamed to *.dts on my test system to allow armbian-add-overlay compatibility) with a /boot/armbianEnv.txt like so:

verbosity=1
console=both
overlay_prefix=meson
rootdev=UUID=4d762a48-122d-482b-9803-7eabc89c2bd8
rootfstype=ext4
user_overlays=meson-sm1-odroid-c4-i2c0 meson-sm1-odroid-c4-i2c1
overlays=
usbstoragequirks=0x2537:0x1066:u,0x2537:0x1068:u

After a reboot, observe:

~# ls -al /sys/class/i2c-dev/
total 0
drwxr-xr-x  2 root root 0 Dec 31  1969 .
drwxr-xr-x 72 root root 0 Dec 31  1969 ..
lrwxrwxrwx  1 root root 0 Dec 31  1969 i2c-0 -> ../../devices/platform/soc/ffd00000.bus/ffd1d000.i2c/i2c-0/i2c-dev/i2c-0
lrwxrwxrwx  1 root root 0 Dec 31  1969 i2c-1 -> ../../devices/platform/soc/ffd00000.bus/ffd1c000.i2c/i2c-1/i2c-dev/i2c-1
lrwxrwxrwx  1 root root 0 Dec 31  1969 i2c-2 -> ../../devices/platform/soc/ff600000.bus/ff600000.hdmi-tx/i2c-2/i2c-dev/i2c-2

We can see that the i2c-0 and i2c-1 devices are now present, and they are aliased as expected to maintain HardKernel compatibility (i.e. i2c2 is aliased to i2c-0 and i2c3 is aliased to i2c-1).

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes generate no new warnings

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

• patch/kernel/archive/meson64-6.12/overlay/meson-sm1-odroid-c4-i2c0.dtso is excluded by !patch/**
• patch/kernel/archive/meson64-6.12/overlay/meson-sm1-odroid-c4-i2c1.dtso is excluded by !patch/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in a Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.