-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix odroid-c4 i2c overlays, meson64-6.15 #8358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add periphs_pinctrl fragment
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This is a follow up of #8352. This PR is for the
meson64-6.15
kernel, where #8352 was formeson64-6.12
.The contents of #8352 are copied below.
Description
The existing odroid-c4 specific i2c overlay files that are shipped with Armbian 25.5.2 bookworm do not enable i2c functionality.
Applying this small modification to the source files, adding to the system and rebooting, i2c functionality is observed and able to be used.
How Has This Been Tested?
meson-sm1-odroid-c4-i2c0.dtbo
andmeson-sm1-odroid-c4-i2c1.dtbo
from/boot/dtb-6.12.32-current-meson64/amlogic/overlay/
with a/boot/armbianEnv.txt
like so:After a reboot, observe:
meson-sm1-odroid-c4-i2c0.dtso
andmeson-sm1-odroid-c4-i2c1.dtso
(files renamed to *.dts on my test system to allowarmbian-add-overlay
compatibility) with a/boot/armbianEnv.txt
like so:After a reboot, observe:
We can see that the i2c-0 and i2c-1 devices are now present, and they are aliased as expected to maintain HardKernel compatibility (i.e. i2c2 is aliased to i2c-0 and i2c3 is aliased to i2c-1).
Checklist: