-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add search pull requests tool #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new search_pull_requests
tool to query GitHub pull requests via the existing search API, wires it into the default toolset, and provides unit tests and snapshots.
- Introduce
SearchPullRequests
inpkg/github/pullrequests.go
- Register the new tool in
DefaultToolsetGroup
- Add
Test_SearchPullRequests
and its schema snapshot
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pkg/github/tools.go | Register SearchPullRequests in the default toolset |
pkg/github/pullrequests.go | Implement SearchPullRequests function |
pkg/github/pullrequests_test.go | Add Test_SearchPullRequests unit tests |
pkg/github/issues.go | Update comment for SearchIssues to remove PR mention |
pkg/github/toolsnaps/search_pull_requests.snap | Add schema snapshot for the new tool |
Comments suppressed due to low confidence (1)
pkg/github/pullrequests_test.go:677
- Update the expected error message to "failed to search pull requests" to match the implementation's error text.
expectedErrMsg: "failed to search issues",
Add description Extract common code Test fixes Updated search description Move search prs to prs toolset Update tools snaps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is much needed!
Add search pull requests tool.
Fixes #462 and #334