-----
-
+---
# Contributing
-Contributions are always welcome, no matter how large or small. Before
-contributing, please read the
-[code of conduct](https://github.com/babel/babel/blob/master/CODE_OF_CONDUCT.md).
+Contributions are always welcome, no matter how large or small! Before contributing, please read the [code of conduct](https://github.com/babel/babel/blob/master/CODE_OF_CONDUCT.md).
## Not sure where to start?
- If you aren't just making a documentation change, you'll probably want to learn a bit about a few topics.
- - [ASTs](https://en.wikipedia.org/wiki/Abstract_syntax_tree) (Abstract Syntax Tree): The Babel AST [spec](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md) is a bit different from [ESTree](https://github.com/estree/estree). The differences are listed [here](https://babeljs.io/docs/en/next/babel-parser.html#output).
- - Check out [`/doc`](https://github.com/babel/babel/tree/master/doc) for information about Babel's internals
- - Check out [the Babel Plugin Handbook](https://github.com/thejameskyle/babel-handbook/blob/master/translations/en/plugin-handbook.md#babel-plugin-handbook) - core plugins are written the same way as any other plugin!
- - Check out [AST Explorer](http://astexplorer.net/#/scUfOmVOG5) to learn more about ASTs or make your own plugin in the browser
+ - [ASTs](https://en.wikipedia.org/wiki/Abstract_syntax_tree) (Abstract Syntax Tree): The Babel AST [spec](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md) is a bit different from [ESTree](https://github.com/estree/estree). The differences are listed [here](https://babeljs.io/docs/en/next/babel-parser.html#output).
+ - Check out [`/doc`](https://github.com/babel/babel/tree/master/doc) for information about Babel's internals
+ - Check out [the Babel Plugin Handbook](https://github.com/thejameskyle/babel-handbook/blob/master/translations/en/plugin-handbook.md#babel-plugin-handbook) - core plugins are written the same way as any other plugin!
+ - Check out [AST Explorer](http://astexplorer.net/#/scUfOmVOG5) to learn more about ASTs or make your own plugin in the browser
- When you feel ready to jump into the Babel source code, a good place to start is to look for issues tagged with [help wanted](https://github.com/babel/babel/labels/help%20wanted) and/or [good first issue](https://github.com/babel/babel/labels/good%20first%20issue).
- Follow along with what we are working on by joining our [Slack](https://babeljs.slack.com) (you can sign-up [here](https://slack.babeljs.io/)
- for an invite), following our announcements on [Twitter](https://twitter.com/babeljs), and reading (or participating!) in our [meeting notes](https://github.com/babel/notes).
+ for an invite), following our announcements on [Twitter](https://twitter.com/babeljs), and reading (or participating!) in our [meeting notes](https://github.com/babel/notes).
- Check out our [website](http://babeljs.io/) and the [repo](https://github.com/babel/website)
+- You can contribute by triaging issues which may include reproducing bug reports or asking for vital information, such as version numbers or reproduction instructions. If you would like to start triaging issues, one easy way to get started is to [subscribe to babel on CodeTriage](https://www.codetriage.com/babel/babel). [![Open Source Helpers](https://www.codetriage.com/babel/babel/badges/users.svg)](https://www.codetriage.com/babel/babel)
## Chat
@@ -39,17 +37,18 @@ Feel free to check out the `#discussion`/`#development` channels on our [Slack](
## Developing
-**Note:** Versions `< 5.1.10` can't be built.
-
-Babel is built for Node 6 and up but we develop using Node 8 and yarn. You can check this with `node -v`.
+*Node*: Check that Node is [installed](https://nodejs.org/en/download/) with version 10 and up. You can check this with `node -v`.
-Make sure that Yarn is installed with version >= `0.28.0`.
-Installation instructions can be found here: https://yarnpkg.com/en/docs/install.
+*Yarn*: Make sure that Yarn 1 is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `1.19.0`.
### Setup
+Fork the `babel` repository to your GitHub Account.
+
+Then, run:
+
```sh
-$ git clone https://github.com/babel/babel
+$ git clone https://github.com//babel
$ cd babel
$ make bootstrap
```
@@ -68,7 +67,7 @@ $ make watch
to have Babel build itself and incrementally build files on change.
-You can access the built files for individual packages from `packages//lib`.
+> You can access the built files for individual packages from `packages//lib`.
If you wish to build a copy of Babel for distribution, then run:
@@ -105,9 +104,7 @@ If you just want to run all tests:
$ make test-only
```
-Most likely you'll want to focus in on a specific issue.
-
-To run tests for a specific package in [packages](https://github.com/babel/babel/tree/master/packages), you can use the `TEST_ONLY` environment variable:
+When working on an issue, you will most likely want to focus on a particular [packages](https://github.com/babel/babel/tree/master/packages). Using `TEST_ONLY` will only run tests for that specific package.
```sh
$ TEST_ONLY=babel-cli make test
@@ -157,12 +154,12 @@ $ ./scripts/test-cov.sh
In case you're not able to reproduce an error on CI locally, it may be due to
- - Node Version: Travis CI runs the tests against all major node versions. If your tests use JavaScript features unsupported by lower versions of node, then use [minNodeVersion option](#writing-tests) in options.json.
- - Timeout: Check the CI log and if the only errors are timeout errors and you are sure that it's not related to the changes you made, ask someone in the slack channel to trigger rebuild on the CI build and it might be resolved
+- Node Version: Travis CI runs the tests against all major node versions. If your tests use JavaScript features unsupported by lower versions of node, then use [minNodeVersion option](#writing-tests) in options.json.
+- Timeout: Check the CI log and if the only errors are timeout errors and you are sure that it's not related to the changes you made, ask someone in the slack channel to trigger rebuild on the CI build and it might be resolved
In case you're locally getting errors which are not on the CI, it may be due to
- - Updates in Dependencies: Make sure you run `make bootstrap` before you run `make build` or `make watch` before you run the tests.
+- Updates in Dependencies: Make sure you run `make bootstrap` before you run `make build` or `make watch` before you run the tests.
### Writing tests
@@ -176,15 +173,16 @@ For example, in [`@babel/plugin-transform-exponentiation-operator/test`](https:/
- There is an `index.js` file. It imports our [test helper](https://github.com/babel/babel/tree/master/packages/babel-helper-plugin-test-runner). (You don't have to worry about this).
- There can be multiple folders under [`/fixtures`](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures)
- - There is an [`options.json`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/options.json) file whose function is similar to a `.babelrc` file, allowing you to pass in the plugins and settings you need for your tests.
- - For this test, we only need the relevant plugin, so it's just `{ "plugins": ["@babel/plugin-transform-exponentiation-operator"] }`.
- - If necessary, you can have an `options.json` with different options in each subfolder.
+
+ - There is an [`options.json`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/options.json) file whose function is similar to a `.babelrc` file, allowing you to pass in the plugins and settings you need for your tests.
+ - For this test, we only need the relevant plugin, so it's just `{ "plugins": ["@babel/plugin-transform-exponentiation-operator"] }`.
+ - If necessary, you can have an `options.json` with different options in each subfolder.
- In each subfolder, you can organize your directory structure by categories of tests. (Example: these folders can be named after the feature you are testing or can reference the issue number they fix)
- Generally, there are two kinds of tests for plugins
- - The first is a simple test of the input and output produced by running Babel on some code. We do this by creating an [`input.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/binary/input.js) file and an [`output.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/binary/output.js) file. This kind of test only works in sub-subdirectories of `/fixtures`, i.e. `/fixtures/exponentian-operator/binary/input.js` and **not** `/fixtures/exponentian-operator/input.js`.
- - If you need to expect an error, you can ignore creating the `output.js` file and pass a new `throws` key to the `options.json` that contains the error string that is created.
- - The second and preferred type is a test that actually evaluates the produced code and asserts that certain properties are true or false. We do this by creating an [`exec.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/comprehensive/exec.js) file.
+ - The first is a simple test of the input and output produced by running Babel on some code. We do this by creating an [`input.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/binary/input.js) file and an [`output.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/binary/output.js) file. This kind of test only works in sub-subdirectories of `/fixtures`, i.e. `/fixtures/exponentian-operator/binary/input.js` and **not** `/fixtures/exponentian-operator/input.js`.
+ - If you need to expect an error, you can ignore creating the `output.js` file and pass a new `throws` key to the `options.json` that contains the error string that is created.
+ - The second and preferred type is a test that actually evaluates the produced code and asserts that certain properties are true or false. We do this by creating an [`exec.js`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/comprehensive/exec.js) file.
In a fixture test, you simply write out the code you want to transform in `input.js`.
@@ -199,6 +197,7 @@ and the expected output after transforming it with your `options.json` in `outpu
// output.js
Math.pow(2, 2);
```
+
In an `exec.js` test, we run or check that the code actually does what it's supposed to do rather than just check the static output.
```js
@@ -234,9 +233,9 @@ Inside the `packages/babel-parser/test/fixtures` folder are categories/groupings
etc.). To add a test, create a folder under one of these groupings (or create a new one) with a
descriptive name, and add the following:
-* Create an `input.js` file that contains the code you want the babel parser to parse.
+- Create an `input.js` file that contains the code you want the babel parser to parse.
-* Add an `output.json` file with the expected parser output. For added convenience, if there is no `output.json` present, the test runner will generate one for you.
+- Add an `output.json` file with the expected parser output. For added convenience, if there is no `output.json` present, the test runner will generate one for you.
After writing tests for @babel/parser, just build it by running:
@@ -316,6 +315,7 @@ Note that the code shown in Chrome DevTools is compiled code and therefore diffe
- Start working about the Babel transform itself!
## Internals
+
- AST spec ([babel-parser/ast/spec.md](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md))
- Versioning ([doc/design/versioning.md](https://github.com/babel/babel/blob/master/doc/design/versioning.md))
- Monorepo ([doc/design/monorepo.md](https://github.com/babel/babel/blob/master/doc/design/monorepo.md))
diff --git a/Gulpfile.js b/Gulpfile.js
index 5df9882ca3f2..5f0b03c04b51 100644
--- a/Gulpfile.js
+++ b/Gulpfile.js
@@ -5,31 +5,29 @@ const through = require("through2");
const chalk = require("chalk");
const newer = require("gulp-newer");
const babel = require("gulp-babel");
-const gulpWatch = require("gulp-watch");
const fancyLog = require("fancy-log");
const filter = require("gulp-filter");
const gulp = require("gulp");
const path = require("path");
-const webpack = require("webpack");
-const merge = require("merge-stream");
const rollup = require("rollup");
const rollupBabel = require("rollup-plugin-babel");
+const rollupBabelSource = require("./scripts/rollup-plugin-babel-source");
+const rollupCommonJs = require("rollup-plugin-commonjs");
+const rollupJson = require("@rollup/plugin-json");
+const rollupNodeBuiltins = require("rollup-plugin-node-builtins");
+const rollupNodeGlobals = require("rollup-plugin-node-globals");
const rollupNodeResolve = require("rollup-plugin-node-resolve");
const rollupReplace = require("rollup-plugin-replace");
-const { registerStandalonePackageTask } = require("./scripts/gulp-tasks");
+const { terser: rollupTerser } = require("rollup-plugin-terser");
-const sources = ["codemods", "packages"];
+const defaultSourcesGlob = "./@(codemods|packages|eslint)/*/src/**/*.js";
function swapSrcWithLib(srcPath) {
const parts = srcPath.split(path.sep);
- parts[1] = "lib";
+ parts[2] = "lib";
return parts.join(path.sep);
}
-function getGlobFromSource(source) {
- return `./${source}/*/src/**/*.js`;
-}
-
function getIndexFromPackage(name) {
return `${name}/src/index.js`;
}
@@ -56,68 +54,178 @@ function rename(fn) {
});
}
-function buildBabel(exclude) {
- return merge(
- sources.map(source => {
- const base = path.join(__dirname, source);
-
- let stream = gulp.src(getGlobFromSource(source), { base: base });
-
- if (exclude) {
- const filters = exclude.map(p => `!**/${p}/**`);
- filters.unshift("**");
- stream = stream.pipe(filter(filters));
- }
-
- return stream
- .pipe(errorsLogger())
- .pipe(newer({ dest: base, map: swapSrcWithLib }))
- .pipe(compilationLogger())
- .pipe(babel())
- .pipe(
- // Passing 'file.relative' because newer() above uses a relative
- // path and this keeps it consistent.
- rename(file => path.resolve(file.base, swapSrcWithLib(file.relative)))
- )
- .pipe(gulp.dest(base));
- })
- );
+function buildBabel(exclude, sourcesGlob = defaultSourcesGlob) {
+ const base = __dirname;
+
+ let stream = gulp.src(sourcesGlob, { base: __dirname });
+
+ if (exclude) {
+ const filters = exclude.map(p => `!**/${p.src}/**`);
+ filters.unshift("**");
+ stream = stream.pipe(filter(filters));
+ }
+
+ return stream
+ .pipe(errorsLogger())
+ .pipe(newer({ dest: base, map: swapSrcWithLib }))
+ .pipe(compilationLogger())
+ .pipe(babel())
+ .pipe(
+ // Passing 'file.relative' because newer() above uses a relative
+ // path and this keeps it consistent.
+ rename(file => path.resolve(file.base, swapSrcWithLib(file.relative)))
+ )
+ .pipe(gulp.dest(base));
}
+let babelVersion = require("./packages/babel-core/package.json").version;
function buildRollup(packages) {
+ const sourcemap = process.env.NODE_ENV === "production";
+ const minify = !!process.env.IS_PUBLISH;
return Promise.all(
- packages.map(pkg => {
- const input = getIndexFromPackage(pkg);
- fancyLog(`Compiling '${chalk.cyan(input)}' with rollup ...`);
- return rollup
- .rollup({
- input,
- plugins: [
- rollupReplace({
- "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
- }),
- rollupBabel({
- envName: "babel-parser",
- }),
- rollupNodeResolve(),
- ],
- })
- .then(bundle => {
- return bundle.write({
- file: path.join(pkg, "lib/index.js"),
- format: "cjs",
- name: "babel-parser",
- sourcemap: process.env.NODE_ENV !== "production",
+ packages.map(
+ ({ src, format, dest, name, filename, version = babelVersion }) => {
+ const extraPlugins = [];
+ let nodeResolveBrowser = false,
+ babelEnvName = "rollup";
+ switch (src) {
+ case "packages/babel-standalone":
+ nodeResolveBrowser = true;
+ babelEnvName = "standalone";
+ if (minify) {
+ extraPlugins.push(
+ rollupTerser({
+ include: /^.+\.min\.js$/,
+ })
+ );
+ }
+ break;
+ }
+ // If this build is part of a pull request, include the pull request number in
+ // the version number.
+ if (process.env.CIRCLE_PR_NUMBER) {
+ const prVersion = "+pr." + process.env.CIRCLE_PR_NUMBER;
+ babelVersion += prVersion;
+ version += prVersion;
+ }
+ const input = getIndexFromPackage(src);
+ fancyLog(`Compiling '${chalk.cyan(input)}' with rollup ...`);
+ return rollup
+ .rollup({
+ input,
+ plugins: [
+ ...extraPlugins,
+ rollupBabelSource(),
+ rollupReplace({
+ "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
+ BABEL_VERSION: JSON.stringify(babelVersion),
+ VERSION: JSON.stringify(version),
+ }),
+ rollupBabel({
+ envName: babelEnvName,
+ babelrc: false,
+ extends: "./babel.config.js",
+ }),
+ rollupNodeResolve({
+ browser: nodeResolveBrowser,
+ preferBuiltins: true,
+ //todo: When Yarn workspaces is enabled, remove `dedupe` option
+ dedupe(importee) {
+ return (
+ importee.startsWith("lodash/") ||
+ [
+ "babel-plugin-dynamic-import-node/utils",
+ "esutils",
+ "semver",
+ "source-map",
+ ].includes(importee)
+ );
+ },
+ }),
+ rollupCommonJs({
+ include: [
+ /node_modules/,
+ "packages/babel-runtime/regenerator/**",
+ "packages/babel-preset-env/data/*.js",
+ // Rollup doesn't read export maps, so it loads the cjs fallback
+ "packages/babel-compat-data/*.js",
+ ],
+ namedExports: {
+ "babel-plugin-dynamic-import-node/utils.js": [
+ "createDynamicImportTransform",
+ "getImportSource",
+ ],
+ "@babel/standalone": ["availablePlugins", "registerPlugin"],
+ },
+ }),
+ rollupJson(),
+ rollupNodeBuiltins(),
+ rollupNodeGlobals({ sourceMap: sourcemap }),
+ ],
+ })
+ .then(bundle => {
+ const outputFile = path.resolve(src, dest, filename || "index.js");
+ return bundle
+ .write({
+ file: outputFile,
+ format,
+ name,
+ sourcemap: sourcemap,
+ })
+ .then(() => {
+ if (!process.env.IS_PUBLISH) {
+ fancyLog(
+ chalk.yellow(
+ `Skipped minification of '${chalk.cyan(
+ path.relative(path.join(__dirname, ".."), outputFile)
+ )}' because not publishing`
+ )
+ );
+ return undefined;
+ }
+ fancyLog(
+ `Minifying '${chalk.cyan(
+ path.relative(path.join(__dirname, ".."), outputFile)
+ )}'...`
+ );
+
+ return bundle.write({
+ file: outputFile.replace(/\.js$/, ".min.js"),
+ format,
+ name,
+ sourcemap: sourcemap,
+ });
+ });
});
- });
- })
+ }
+ )
);
}
-const bundles = ["packages/babel-parser"];
+const libBundles = [
+ {
+ src: "packages/babel-parser",
+ format: "cjs",
+ dest: "lib",
+ version: require("./packages/babel-parser/package").version,
+ },
+];
+
+const standaloneBundle = [
+ {
+ src: "packages/babel-standalone",
+ format: "umd",
+ name: "Babel",
+ filename: "babel.js",
+ dest: "",
+ version: require("./packages/babel-core/package").version,
+ },
+];
+
+gulp.task("build-rollup", () => buildRollup(libBundles));
+gulp.task("build-babel-standalone", () => buildRollup(standaloneBundle));
-gulp.task("build-rollup", () => buildRollup(bundles));
-gulp.task("build-babel", () => buildBabel(/* exclude */ bundles));
+gulp.task("build-babel", () => buildBabel(/* exclude */ libBundles));
gulp.task("build", gulp.parallel("build-rollup", "build-babel"));
gulp.task("default", gulp.series("build"));
@@ -127,48 +235,6 @@ gulp.task("build-no-bundle", () => buildBabel());
gulp.task(
"watch",
gulp.series("build-no-bundle", function watch() {
- gulpWatch(
- sources.map(getGlobFromSource),
- { debounceDelay: 200 },
- gulp.task("build-no-bundle")
- );
+ gulp.watch(defaultSourcesGlob, gulp.task("build-no-bundle"));
})
);
-
-registerStandalonePackageTask(
- gulp,
- "babel",
- "Babel",
- path.join(__dirname, "packages"),
- require("./packages/babel-standalone/package.json").version
-);
-
-const presetEnvWebpackPlugins = [
- new webpack.NormalModuleReplacementPlugin(
- /\.\/available-plugins/,
- require.resolve(
- path.join(
- __dirname,
- "./packages/babel-preset-env-standalone/src/available-plugins"
- )
- )
- ),
- new webpack.NormalModuleReplacementPlugin(
- /caniuse-lite\/data\/regions\/.+/,
- require.resolve(
- path.join(
- __dirname,
- "./packages/babel-preset-env-standalone/src/caniuse-lite-regions"
- )
- )
- ),
-];
-
-registerStandalonePackageTask(
- gulp,
- "babel-preset-env",
- "babelPresetEnv",
- path.join(__dirname, "packages"),
- require("./packages/babel-preset-env-standalone/package.json").version,
- presetEnvWebpackPlugins
-);
diff --git a/Makefile b/Makefile
index 5fa5cb0cfdbf..69c97e5eff66 100644
--- a/Makefile
+++ b/Makefile
@@ -1,67 +1,133 @@
-MAKEFLAGS = -j1
-FLOW_COMMIT = 09669846b7a7ca5a6c23c12d56bb3bebdafd67e9
-TEST262_COMMIT = de567d3aa5de4eaa11e00131d26b9fe77997dfb0
+FLOW_COMMIT = a1f9a4c709dcebb27a5084acf47755fbae699c25
+TEST262_COMMIT = 28b4fcca4b1b1d278dfe0cc0e69c7d9d59b31aab
+TYPESCRIPT_COMMIT = 5fc917be2e4dd64c8e9504d36615cd7fbfdd4cd3
+
+FORCE_PUBLISH = "@babel/runtime,@babel/runtime-corejs2,@babel/runtime-corejs3,@babel/standalone"
# Fix color output until TravisCI fixes https://github.com/travis-ci/travis-ci/issues/7967
export FORCE_COLOR = true
-SOURCES = packages codemods
+SOURCES = packages codemods eslint
+
+COMMA := ,
+EMPTY :=
+SPACE := $(EMPTY) $(EMPTY)
+COMMA_SEPARATED_SOURCES = $(subst $(SPACE),$(COMMA),$(SOURCES))
+
+YARN := yarn --silent
+NODE := $(YARN) node
+
.PHONY: build build-dist watch lint fix clean test-clean test-only test test-ci publish bootstrap
-build: clean clean-lib
- ./node_modules/.bin/gulp build
- node ./packages/babel-standalone/scripts/generate.js
- node ./packages/babel-types/scripts/generateTypeHelpers.js
- # call build again as the generated files might need to be compiled again.
- ./node_modules/.bin/gulp build
- # generate flow and typescript typings
- node packages/babel-types/scripts/generators/flow.js > ./packages/babel-types/lib/index.js.flow
- node packages/babel-types/scripts/generators/typescript.js > ./packages/babel-types/lib/index.d.ts
+build: build-bundle
ifneq ("$(BABEL_COVERAGE)", "true")
- make build-standalone
- make build-preset-env-standalone
+ $(MAKE) build-standalone
endif
-build-standalone:
- ./node_modules/.bin/gulp build-babel-standalone
+build-bundle: clean clean-lib
+ $(YARN) gulp build
+ $(MAKE) generate-standalone generate-type-helpers
+ # call build again as the generated files might need to be compiled again.
+ $(YARN) gulp build
+ $(MAKE) build-typings
+ $(MAKE) build-dist
+
+build-bundle-ci: bootstrap-only
+ $(MAKE) build-bundle
+
+generate-standalone:
+ $(NODE) packages/babel-standalone/scripts/generate.js
+
+generate-type-helpers:
+ $(NODE) packages/babel-types/scripts/generateTypeHelpers.js
+
+build-typings: build-flow-typings build-typescript-typings
+
+build-flow-typings:
+ $(NODE) packages/babel-types/scripts/generators/flow.js > packages/babel-types/lib/index.js.flow
+
+build-typescript-typings:
+ $(NODE) packages/babel-types/scripts/generators/typescript.js > packages/babel-types/lib/index.d.ts
+
+build-standalone: build-babel-standalone
+
+build-standalone-ci: build-bundle-ci
+ $(MAKE) build-standalone
-build-preset-env-standalone:
- ./node_modules/.bin/gulp build-babel-preset-env-standalone
+build-babel-standalone:
+ $(YARN) gulp build-babel-standalone
prepublish-build-standalone:
- BABEL_ENV=production IS_PUBLISH=true ./node_modules/.bin/gulp build-babel-standalone
+ BABEL_ENV=production IS_PUBLISH=true $(YARN) gulp build-babel-standalone
-prepublish-build-preset-env-standalone:
- BABEL_ENV=production IS_PUBLISH=true ./node_modules/.bin/gulp build-babel-preset-env-standalone
+build-dist: build-polyfill-dist build-plugin-transform-runtime-dist
-build-dist: build
+build-polyfill-dist:
cd packages/babel-polyfill; \
scripts/build-dist.sh
- cd packages/babel-plugin-transform-runtime; \
- node scripts/build-dist.js
-watch: clean clean-lib
+build-plugin-transform-runtime-dist:
+ cd packages/babel-plugin-transform-runtime; \
+ $(NODE) scripts/build-dist.js
+build-no-bundle: clean clean-lib
+ BABEL_ENV=development $(YARN) gulp build-no-bundle
# Ensure that build artifacts for types are created during local
# development too.
- BABEL_ENV=development ./node_modules/.bin/gulp build-no-bundle
- node ./packages/babel-types/scripts/generateTypeHelpers.js
- node packages/babel-types/scripts/generators/flow.js > ./packages/babel-types/lib/index.js.flow
- node packages/babel-types/scripts/generators/typescript.js > ./packages/babel-types/lib/index.d.ts
- BABEL_ENV=development ./node_modules/.bin/gulp watch
+ $(MAKE) generate-type-helpers
+ $(MAKE) build-typings
+
+build-no-bundle-ci: bootstrap-only
+ $(MAKE) build-no-bundle
+
+watch: build-no-bundle
+ BABEL_ENV=development $(YARN) gulp watch
+
+code-quality-ci: flowcheck-ci lint-ci
+
+flowcheck-ci: bootstrap-flowcheck
+ $(MAKE) flow
+
+code-quality: flow lint
flow:
- ./node_modules/.bin/flow check --strip-root
+ $(YARN) flow check --strip-root
+
+bootstrap-flowcheck: build-no-bundle-ci
+
+lint-ci: lint-js-ci lint-ts-ci check-compat-data-ci
+
+lint-js-ci: bootstrap-only
+ $(MAKE) lint-js
+
+lint-ts-ci: bootstrap-flowcheck
+ $(MAKE) lint-ts
+
+check-compat-data-ci: build-no-bundle-ci
+ $(MAKE) check-compat-data
+
+lint: lint-js lint-ts
-lint:
- ./node_modules/.bin/eslint scripts $(SOURCES) '*.js' --format=codeframe
+lint-js:
+ BABEL_ENV=test $(YARN) eslint scripts $(SOURCES) '*.js' --format=codeframe
-fix: fix-json
- ./node_modules/.bin/eslint scripts $(SOURCES) '*.js' --format=codeframe --fix
+lint-ts:
+ scripts/lint-ts-typings.sh
+
+fix: fix-json fix-js
+
+fix-js:
+ $(YARN) eslint scripts $(SOURCES) '*.js' --format=codeframe --fix
fix-json:
- ./node_modules/.bin/prettier "{packages,codemod}/*/test/fixtures/**/options.json" --write --loglevel warn
+ $(YARN) prettier "{$(COMMA_SEPARATED_SOURCES)}/*/test/fixtures/**/options.json" --write --loglevel warn
+
+check-compat-data:
+ cd packages/babel-compat-data; CHECK_COMPAT_DATA=true $(YARN) run build-data
+
+build-compat-data:
+ cd packages/babel-compat-data; $(YARN) run build-data
clean: test-clean
rm -f .npmrc
@@ -74,72 +140,92 @@ test-clean:
$(foreach source, $(SOURCES), \
$(call clean-source-test, $(source)))
+# Does not work on Windows; use "$(YARN) jest" instead
test-only:
BABEL_ENV=test ./scripts/test.sh
- make test-clean
+ $(MAKE) test-clean
test: lint test-only
-test-ci: bootstrap test-only
+test-ci: jest-ci
+jest-ci: build-standalone-ci
+ BABEL_ENV=test $(YARN) jest --maxWorkers=4 --ci
+ $(MAKE) test-clean
+
+# Does not work on Windows
test-ci-coverage: SHELL:=/bin/bash
test-ci-coverage:
- BABEL_COVERAGE=true BABEL_ENV=test make bootstrap
+ BABEL_COVERAGE=true BABEL_ENV=test $(MAKE) bootstrap
BABEL_ENV=test TEST_TYPE=cov ./scripts/test-cov.sh
bash <(curl -s https://codecov.io/bash) -f coverage/coverage-final.json
bootstrap-flow:
- rm -rf ./build/flow
- mkdir -p ./build
- git clone --branch=master --single-branch --shallow-since=2018-11-01 https://github.com/facebook/flow.git ./build/flow
+ rm -rf build/flow
+ mkdir -p build
+ git clone --branch=master --single-branch --shallow-since=2018-11-01 https://github.com/facebook/flow.git build/flow
cd build/flow && git checkout $(FLOW_COMMIT)
test-flow:
- node scripts/tests/flow/run_babel_parser_flow_tests.js
+ $(NODE) scripts/parser-tests/flow
-test-flow-ci: bootstrap test-flow
+test-flow-ci: build-bundle-ci bootstrap-flow
+ $(MAKE) test-flow
test-flow-update-whitelist:
- node scripts/tests/flow/run_babel_parser_flow_tests.js --update-whitelist
+ $(NODE) scripts/parser-tests/flow --update-whitelist
-bootstrap-test262:
- rm -rf ./build/test262
+bootstrap-typescript:
+ rm -rf ./build/typescript
mkdir -p ./build
- git clone --branch=master --single-branch --shallow-since=2019-01-01 https://github.com/tc39/test262.git ./build/test262
+ git clone --branch=master --single-branch --shallow-since=2019-09-01 https://github.com/microsoft/TypeScript.git ./build/typescript
+ cd build/typescript && git checkout $(TYPESCRIPT_COMMIT)
+
+test-typescript:
+ $(NODE) scripts/parser-tests/typescript
+
+test-typescript-ci: build-bundle-ci bootstrap-typescript
+ $(MAKE) test-typescript
+
+test-typescript-update-whitelist:
+ $(NODE) scripts/parser-tests/typescript --update-whitelist
+
+bootstrap-test262:
+ rm -rf build/test262
+ mkdir -p build
+ git clone --branch=master --single-branch --shallow-since=2019-12-01 https://github.com/tc39/test262.git build/test262
cd build/test262 && git checkout $(TEST262_COMMIT)
test-test262:
- node scripts/tests/test262/run_babel_parser_test262.js
+ $(NODE) scripts/parser-tests/test262
-test-test262-ci: bootstrap test-test262
+test-test262-ci: build-bundle-ci bootstrap-test262
+ $(MAKE) test-test262
test-test262-update-whitelist:
- node scripts/tests/test262/run_babel_parser_test262.js --update-whitelist
+ $(NODE) scripts/parser-tests/test262 --update-whitelist
+# Does not work on Windows
clone-license:
./scripts/clone-license.sh
-prepublish-build:
- make clean-lib
- rm -rf packages/babel-runtime/helpers
- rm -rf packages/babel-runtime-corejs2/helpers
- rm -rf packages/babel-runtime-corejs2/core-js
- NODE_ENV=production BABEL_ENV=production make build-dist
- make clone-license
+prepublish-build: clean-lib clean-runtime-helpers
+ NODE_ENV=production BABEL_ENV=production $(MAKE) build
+ $(MAKE) clone-license
prepublish:
- make bootstrap-only
- make prepublish-build
- make test
+ $(MAKE) bootstrap-only
+ $(MAKE) prepublish-build
+ IS_PUBLISH=true $(MAKE) test
new-version:
git pull --rebase
- ./node_modules/.bin/lerna version --force-publish="@babel/runtime,@babel/runtime-corejs2,@babel/runtime-corejs3,@babel/standalone,@babel/preset-env-standalone"
+ $(YARN) lerna version --force-publish=$(FORCE_PUBLISH)
# NOTE: Run make new-version first
publish: prepublish
- ./node_modules/.bin/lerna publish from-git --require-scripts
- make clean
+ $(YARN) lerna publish from-git
+ $(MAKE) clean
publish-ci: prepublish
ifneq ("$(NPM_TOKEN)", "")
@@ -148,23 +234,47 @@ else
echo "Missing NPM_TOKEN env var"
exit 1
endif
- ./node_modules/.bin/lerna publish from-git --require-scripts --yes
+ $(YARN) lerna publish from-git --yes
rm -f .npmrc
- make clean
+ $(MAKE) clean
-bootstrap-only: clean-all
+publish-test:
+ifneq ("$(I_AM_USING_VERDACCIO)", "I_AM_SURE")
+ echo "You probably don't know what you are doing"
+ exit 1
+endif
+ $(MAKE) prepublish-build
+ $(YARN) lerna version $(VERSION) --force-publish=$(FORCE_PUBLISH) --no-push --yes --tag-version-prefix="version-e2e-test-"
+ $(YARN) lerna publish from-git --registry http://localhost:4873 --yes --tag-version-prefix="version-e2e-test-"
+ $(MAKE) clean
+
+publish-eslint:
+ $(call set-json-field, ./eslint/$(PKG)/package.json, private, false)
+ cd eslint/$(PKG); yarn publish
+ $(call set-json-field, ./eslint/$(PKG)/package.json, private, true)
+
+bootstrap-only: lerna-bootstrap
+
+yarn-install: clean-all
yarn --ignore-engines
- ./node_modules/.bin/lerna bootstrap -- --ignore-engines
+
+lerna-bootstrap: yarn-install
+# todo: remove `-- -- --ignore-engines` in Babel 8
+ $(YARN) lerna bootstrap -- -- --ignore-engines
bootstrap: bootstrap-only
- make build
- cd packages/babel-plugin-transform-runtime; \
- node scripts/build-dist.js
+ $(MAKE) build
clean-lib:
$(foreach source, $(SOURCES), \
$(call clean-source-lib, $(source)))
+clean-runtime-helpers:
+ rm -f packages/babel-runtime/helpers/**/*.js
+ rm -f packages/babel-runtime-corejs2/helpers/**/*.js
+ rm -f packages/babel-runtime-corejs3/helpers/**/*.js
+ rm -rf packages/babel-runtime-corejs2/core-js
+
clean-all:
rm -rf node_modules
rm -rf package-lock.json
@@ -173,7 +283,13 @@ clean-all:
$(foreach source, $(SOURCES), \
$(call clean-source-all, $(source)))
- make clean
+ $(MAKE) clean
+
+update-env-corejs-fixture:
+ rm -rf packages/babel-preset-env/node_modules/core-js-compat
+ $(YARN) lerna bootstrap
+ $(MAKE) build-bundle
+ OVERWRITE=true $(YARN) jest packages/babel-preset-env
define clean-source-lib
rm -rf $(1)/*/lib
@@ -187,8 +303,15 @@ define clean-source-test
endef
define clean-source-all
- rm -rf $(1)/*/lib
+ $(call clean-source-lib, $1)
rm -rf $(1)/*/node_modules
rm -rf $(1)/*/package-lock.json
endef
+
+define set-json-field
+ $(NODE) -e "\
+ require('fs').writeFileSync('$1'.trim(), \
+ JSON.stringify({ ...require('$1'.trim()), $2: $3 }, null, 2) + '\\n' \
+ )"
+endef
diff --git a/README.md b/README.md
index 579b85a7cd88..0b17712e2e75 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@
-
+
@@ -80,14 +80,14 @@ Try it out at our [REPL](https://babeljs.io/repl/build/master#?code_lz=NoRgNATGD
Mostly a handful of volunteers, funded by you! Please check out our [team page](https://babeljs.io/team)!
-### Looking for support?
-
-For questions and support please join our [Slack Community](https://slack.babeljs.io/) (you can sign-up [here](https://slack.babeljs.io/) for an invite), ask a question on [Stack Overflow](https://stackoverflow.com/questions/tagged/babeljs), or ping us on [Twitter](https://twitter.com/babeljs).
-
### Is there a Babel song?
I'm so glad you asked: [Hallelujah —— In Praise of Babel](SONG.md) by [@angus-c](https://github.com/angus-c), [audio version](https://youtu.be/40abpedBKK8) by [@swyx](https://twitter.com/@swyx). Tweet us your recordings!
+### Looking for support?
+
+For questions and support please join our [Slack Community](https://slack.babeljs.io/) (you can sign-up [here](https://slack.babeljs.io/) for an invite), ask a question on [Stack Overflow](https://stackoverflow.com/questions/tagged/babeljs), or ping us on [Twitter](https://twitter.com/babeljs).
+
### Where are the docs?
Check out our website: [babeljs.io](https://babeljs.io/), and report issues/features at [babel/website](https://github.com/babel/website/issues).
@@ -98,12 +98,19 @@ Please read through our [CONTRIBUTING.md](CONTRIBUTING.md) and fill out the issu
### Want to contribute to Babel?
-Check out our [CONTRIBUTING.md](CONTRIBUTING.md) to get started with setting up the repo.
+Check out:
+
+- Our [#development](https://babeljs.slack.com/messages/development) Slack channel and say hi ([signup](https://slack.babeljs.io))!
+- Issues with the [good first issue](https://github.com/babel/babel/labels/good%20first%20issue) and [help wanted](https://github.com/babel/babel/labels/help%20wanted) label. We suggest also looking at the [closed ones](https://github.com/babel/babel/issues?utf8=%E2%9C%93&q=is%3Aclosed+label%3A%22good+first+issue%22) to get a sense of the kinds of issues you can tackle.
+
+Some resources:
-- If you have already joined Slack, join our [#development](https://babeljs.slack.com/messages/development) channel and say hi!
-- Check out the issues with the [good first issue](https://github.com/babel/babel/labels/good%20first%20issue) and [help wanted](https://github.com/babel/babel/labels/help%20wanted) label. We suggest also looking at the closed ones to get a sense of the kinds of issues you can tackle.
+- Our [CONTRIBUTING.md](CONTRIBUTING.md) to get started with setting up the repo.
- Our discussions/notes/roadmap: [babel/notes](https://github.com/babel/notes)
- Our progress on TC39 proposals: [babel/proposals](https://github.com/babel/proposals)
+- Our blog which contains release posts and explanations: [/blog](https://babeljs.io/blog)
+- Our videos page with talks about open source and Babel: [/videos](https://babeljs.io/videos)
+- Our [podcast](https://podcast.babeljs.io)
### How is the repo structured?
diff --git a/babel.config.js b/babel.config.js
index 82966a7f07ca..b66ad8e143e3 100644
--- a/babel.config.js
+++ b/babel.config.js
@@ -8,28 +8,48 @@ module.exports = function(api) {
const envOptsNoTargets = {
loose: true,
modules: false,
+ shippedProposals: true,
exclude: ["transform-typeof-symbol"],
};
const envOpts = Object.assign({}, envOptsNoTargets);
+ const compileDynamicImport = env === "test" || env === "development";
+
let convertESM = true;
let ignoreLib = true;
- let includeRuntime = false;
+ let includeRegeneratorRuntime = false;
+
+ let transformRuntimeOptions;
+
const nodeVersion = "6.9";
+ // The vast majority of our src files are modules, but we use
+ // unambiguous to keep things simple until we get around to renaming
+ // the modules to be more easily distinguished from CommonJS
+ const unambiguousSources = [
+ "packages/*/src",
+ "packages/*/test",
+ "codemods/*/src",
+ "codemods/*/test",
+ "eslint/*/src",
+ "eslint/*/test",
+ ];
switch (env) {
// Configs used during bundling builds.
- case "babel-parser":
- convertESM = false;
- ignoreLib = false;
- envOpts.targets = {
- node: nodeVersion,
- };
- break;
case "standalone":
+ includeRegeneratorRuntime = true;
+ unambiguousSources.push("packages/babel-runtime/regenerator");
+ // fall through
+ case "rollup":
convertESM = false;
ignoreLib = false;
- includeRuntime = true;
+ // rollup-commonjs will converts node_modules to ESM
+ unambiguousSources.push(
+ "**/node_modules",
+ "packages/babel-preset-env/data",
+ "packages/babel-compat-data"
+ );
+ if (env === "rollup") envOpts.targets = { node: nodeVersion };
break;
case "production":
// Config during builds before publish.
@@ -50,6 +70,16 @@ module.exports = function(api) {
break;
}
+ if (includeRegeneratorRuntime) {
+ const babelRuntimePkgPath = require.resolve("@babel/runtime/package.json");
+
+ transformRuntimeOptions = {
+ helpers: false, // Helpers are handled by rollup when needed
+ regenerator: true,
+ version: require(babelRuntimePkgPath).version,
+ };
+ }
+
const config = {
// Our dependencies are all standard CommonJS, along with all sorts of
// other random files in Babel's codebase, so we use script as the default,
@@ -63,7 +93,6 @@ module.exports = function(api) {
"packages/*/test/fixtures",
ignoreLib ? "packages/*/lib" : null,
"packages/babel-standalone/babel.js",
- "packages/babel-preset-env-standalone/babel-preset-env.js",
].filter(Boolean),
presets: [["@babel/env", envOpts]],
plugins: [
@@ -72,60 +101,46 @@ module.exports = function(api) {
"@babel/plugin-transform-flow-strip-types",
["@babel/proposal-class-properties", { loose: true }],
"@babel/proposal-export-namespace-from",
- "@babel/proposal-numeric-separator",
[
"@babel/proposal-object-rest-spread",
{ useBuiltIns: true, loose: true },
],
+ compileDynamicImport ? dynamicImportUrlToPath : null,
+ compileDynamicImport ? "@babel/plugin-proposal-dynamic-import" : null,
- // Explicitly use the lazy version of CommonJS modules.
- convertESM ? ["@babel/transform-modules-commonjs", { lazy: true }] : null,
+ convertESM ? "@babel/transform-modules-commonjs" : null,
].filter(Boolean),
overrides: [
{
- test: "packages/babel-parser",
+ test: [
+ "packages/babel-parser",
+ "packages/babel-helper-validator-identifier",
+ ],
plugins: [
"babel-plugin-transform-charcodes",
["@babel/transform-for-of", { assumeArray: true }],
],
},
{
- test: "./packages/babel-register",
+ test: ["./packages/babel-cli", "./packages/babel-core"],
plugins: [
- // Override the root options to disable lazy imports for babel-register
- // because otherwise the require hook will try to lazy-import things
- // leading to dependency cycles.
- convertESM ? "@babel/transform-modules-commonjs" : null,
+ // Explicitly use the lazy version of CommonJS modules.
+ convertESM
+ ? ["@babel/transform-modules-commonjs", { lazy: true }]
+ : null,
].filter(Boolean),
},
{
test: "./packages/babel-polyfill",
presets: [["@babel/env", envOptsNoTargets]],
- plugins: [["@babel/transform-modules-commonjs", { lazy: false }]],
},
{
- // The vast majority of our src files are modules, but we use
- // unambiguous to keep things simple until we get around to renaming
- // the modules to be more easily distinguished from CommonJS
- test: [
- "packages/*/src",
- "packages/*/test",
- "codemods/*/src",
- "codemods/*/test",
- ],
+ test: unambiguousSources,
sourceType: "unambiguous",
},
- {
- // The runtime transform shouldn't process its own runtime or core-js.
- exclude: [
- "packages/babel-runtime",
- /[\\/]node_modules[\\/](?:@babel\/runtime|babel-runtime|core-js)[\\/]/,
- ],
- plugins: [
- includeRuntime
- ? ["@babel/transform-runtime", { version: "7.4.4" }]
- : null,
- ].filter(Boolean),
+ includeRegeneratorRuntime && {
+ exclude: /regenerator-runtime/,
+ plugins: [["@babel/transform-runtime", transformRuntimeOptions]],
},
].filter(Boolean),
};
@@ -138,3 +153,45 @@ module.exports = function(api) {
return config;
};
+
+// !!! WARNING !!! Hacks are coming
+
+// import() uses file:// URLs for absolute imports, while require() uses
+// file paths.
+// Since this isn't handled by @babel/plugin-transform-modules-commonjs,
+// we must handle it here.
+// However, fileURLToPath is only supported starting from Node.js 10.
+// In older versions, we can remove the pathToFileURL call so that it keeps
+// the original absolute path.
+// NOTE: This plugin must run before @babel/plugin-transform-modules-commonjs,
+// and assumes that the target is the current node version.
+function dynamicImportUrlToPath({ template }) {
+ const currentNodeSupportsURL = !!require("url").pathToFileURL;
+
+ if (currentNodeSupportsURL) {
+ return {
+ visitor: {
+ CallExpression(path) {
+ if (path.get("callee").isImport()) {
+ path.get("arguments.0").replaceWith(
+ template.expression.ast`
+ require("url").fileURLToPath(${path.node.arguments[0]})
+ `
+ );
+ }
+ },
+ },
+ };
+ } else {
+ // TODO: Remove in Babel 8 (it's not needed when using Node 10)
+ return {
+ visitor: {
+ CallExpression(path) {
+ if (path.get("callee").isIdentifier({ name: "pathToFileURL" })) {
+ path.replaceWith(path.get("arguments.0"));
+ }
+ },
+ },
+ };
+ }
+}
diff --git a/codecov.yml b/codecov.yml
index ed4545a1bf7d..17d3dfb026d0 100644
--- a/codecov.yml
+++ b/codecov.yml
@@ -5,7 +5,7 @@ coverage:
status:
project:
default:
- target: "80%"
+ target: "90%"
patch:
enabled: false
ignore:
diff --git a/codemods/babel-plugin-codemod-object-assign-to-object-spread/package.json b/codemods/babel-plugin-codemod-object-assign-to-object-spread/package.json
index 747fa0fe68e7..e432a89a4486 100644
--- a/codemods/babel-plugin-codemod-object-assign-to-object-spread/package.json
+++ b/codemods/babel-plugin-codemod-object-assign-to-object-spread/package.json
@@ -1,6 +1,6 @@
{
"name": "@babel/plugin-codemod-object-assign-to-object-spread",
- "version": "7.0.0",
+ "version": "7.7.4",
"description": "Transforms Object.assign into object spread syntax",
"repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-object-assign-to-object-spread",
"license": "MIT",
@@ -13,16 +13,13 @@
"@babel/plugin"
],
"dependencies": {
- "@babel/plugin-syntax-object-rest-spread": "^7.0.0"
+ "@babel/plugin-syntax-object-rest-spread": "^7.7.4"
},
"peerDependencies": {
"@babel/core": "^7.0.0-0"
},
"devDependencies": {
- "@babel/core": "^7.0.0",
- "@babel/helper-plugin-test-runner": "^7.0.0"
- },
- "publishConfig": {
- "access": "public"
+ "@babel/core": "^7.7.4",
+ "@babel/helper-plugin-test-runner": "^7.7.4"
}
}
diff --git a/codemods/babel-plugin-codemod-optional-catch-binding/package.json b/codemods/babel-plugin-codemod-optional-catch-binding/package.json
index 45913353021c..68196e27c1ba 100644
--- a/codemods/babel-plugin-codemod-optional-catch-binding/package.json
+++ b/codemods/babel-plugin-codemod-optional-catch-binding/package.json
@@ -1,6 +1,6 @@
{
"name": "@babel/plugin-codemod-optional-catch-binding",
- "version": "7.0.0",
+ "version": "7.7.4",
"description": "Remove unused catch bindings",
"repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-remove-unused-catch-binding",
"license": "MIT",
@@ -13,13 +13,13 @@
"@babel/plugin"
],
"dependencies": {
- "@babel/plugin-syntax-optional-catch-binding": "^7.0.0"
+ "@babel/plugin-syntax-optional-catch-binding": "^7.7.4"
},
"peerDependencies": {
"@babel/core": "^7.0.0-0"
},
"devDependencies": {
- "@babel/core": "^7.0.0",
- "@babel/helper-plugin-test-runner": "^7.0.0"
+ "@babel/core": "^7.7.4",
+ "@babel/helper-plugin-test-runner": "^7.7.4"
}
}
diff --git a/codemods/babel-plugin-codemod-optional-catch-binding/test/fixtures/codemod-optional-catch-binding/try-catch-finally-used-binding/options.json b/codemods/babel-plugin-codemod-optional-catch-binding/test/fixtures/codemod-optional-catch-binding/try-catch-finally-used-binding/options.json
index 0587911559c4..cbe0e9893752 100644
--- a/codemods/babel-plugin-codemod-optional-catch-binding/test/fixtures/codemod-optional-catch-binding/try-catch-finally-used-binding/options.json
+++ b/codemods/babel-plugin-codemod-optional-catch-binding/test/fixtures/codemod-optional-catch-binding/try-catch-finally-used-binding/options.json
@@ -1,3 +1,3 @@
{
- "plugins": ["../../../../lib"]
- }
+ "plugins": ["../../../../lib"]
+}
diff --git a/doc/design/monorepo.md b/doc/design/monorepo.md
index d10cc9741b76..0460dcd82b73 100644
--- a/doc/design/monorepo.md
+++ b/doc/design/monorepo.md
@@ -15,7 +15,7 @@ This is quite taboo but let's look at the pros and cons:
* Easy to coordinate changes across modules.
* Single place to report issues.
* Easier to setup a development environment.
- * Tests across modules are run together which finds bugs that touch multiple modules easier.
+ * Tests across modules are run together which finds bugs that touch multiple modules more easily.
**Cons:**
diff --git a/eslint/babel-eslint-config-internal/.npmignore b/eslint/babel-eslint-config-internal/.npmignore
new file mode 100644
index 000000000000..ad69326ce8c2
--- /dev/null
+++ b/eslint/babel-eslint-config-internal/.npmignore
@@ -0,0 +1,4 @@
+src
+test
+.*
+*.log
diff --git a/eslint/babel-eslint-config-internal/README.md b/eslint/babel-eslint-config-internal/README.md
new file mode 100644
index 000000000000..20d79ebc44bb
--- /dev/null
+++ b/eslint/babel-eslint-config-internal/README.md
@@ -0,0 +1,4 @@
+## @babel/eslint-config-internal
+---
+
+ESLint config for the Babel codebase (originally taken from `eslint-config-kittens`)
diff --git a/eslint/babel-eslint-config-internal/index.js b/eslint/babel-eslint-config-internal/index.js
new file mode 100644
index 000000000000..6bf24402795c
--- /dev/null
+++ b/eslint/babel-eslint-config-internal/index.js
@@ -0,0 +1,33 @@
+"use strict";
+
+module.exports = {
+ parser: "babel-eslint",
+ extends: "eslint:recommended",
+ plugins: ["flowtype"],
+ parserOptions: {
+ ecmaVersion: 2020,
+ sourceType: "module",
+ },
+ globals: {
+ // Flow
+ Iterator: true,
+ $Keys: true,
+ },
+ env: {
+ node: true,
+ es2020: true,
+ browser: true,
+ },
+ rules: {
+ curly: ["error", "multi-line"],
+ "linebreak-style": ["error", "unix"],
+ "no-case-declarations": "error",
+ "no-confusing-arrow": "error",
+ "no-empty": ["error", { allowEmptyCatch: true }],
+ "no-process-exit": "error",
+ "no-var": "error",
+ "prefer-const": "error",
+ "flowtype/define-flow-type": "warn",
+ "flowtype/use-flow-type": "warn",
+ },
+};
diff --git a/eslint/babel-eslint-config-internal/package.json b/eslint/babel-eslint-config-internal/package.json
new file mode 100644
index 000000000000..93324f718152
--- /dev/null
+++ b/eslint/babel-eslint-config-internal/package.json
@@ -0,0 +1,15 @@
+{
+ "name": "@babel/eslint-config-internal",
+ "version": "0.0.0",
+ "description": "The Babel Team's ESLint configuration. Since it's internal, it might not respect semver.",
+ "author": "Sebastian McKenzie ",
+ "homepage": "https://babeljs.io/",
+ "license": "MIT",
+ "private": true,
+ "repository": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-config-internal",
+ "main": "index.js",
+ "peerDependencies": {
+ "babel-eslint": "^10.0.0 || ^11.0.0-0",
+ "eslint-plugin-flowtype": "^3.0.0"
+ }
+}
diff --git a/eslint/babel-eslint-parser/.npmignore b/eslint/babel-eslint-parser/.npmignore
new file mode 100644
index 000000000000..c3aafe7a7721
--- /dev/null
+++ b/eslint/babel-eslint-parser/.npmignore
@@ -0,0 +1,4 @@
+src
+test
+.*
+*.log
\ No newline at end of file
diff --git a/eslint/babel-eslint-parser/README.md b/eslint/babel-eslint-parser/README.md
new file mode 100644
index 000000000000..d9ebe61f3f64
--- /dev/null
+++ b/eslint/babel-eslint-parser/README.md
@@ -0,0 +1,127 @@
+# @babel/eslint-parser [![npm](https://img.shields.io/npm/v/@babel/eslint-parser.svg)](https://www.npmjs.com/package/@babel/eslint-parser) [![travis](https://img.shields.io/travis/babel/@babel/eslint-parser/master.svg)](https://travis-ci.org/babel/@babel/eslint-parser) [![npm-downloads](https://img.shields.io/npm/dm/@babel/eslint-parser.svg)](https://www.npmjs.com/package/@babel/eslint-parser)
+
+
+## This project is still experimental and will be released with Babel v8. You can track our progress [here](https://github.com/babel/babel/issues/10752)! Please use [babel-eslint](https://github.com/babel/babel-eslint) in the meantime.
+
+**@babel/eslint-parser** allows you to lint **ALL** valid Babel code with the fantastic
+[ESLint](https://github.com/eslint/eslint).
+
+## When should I use @babel/eslint-parser?
+
+ESLint's default parser and core rules [only support the latest final ECMAScript standard](https://github.com/eslint/eslint/blob/a675c89573836adaf108a932696b061946abf1e6/README.md#what-about-experimental-features) and do not support experimental (such as new features) and non-standard (such as Flow or TypeScript types) syntax provided by Babel. @babel/eslint-parser is a parser that allows ESLint to run on source code that is transformed by Babel.
+
+**Note:** You only need to use @babel/parser-eslint if you are using Babel to transform your code. If this is not the case, please use the relevant parser for your chosen flavor of ECMAScript (note that the default parser supports all non-experimental syntax as well as JSX).
+
+## How does it work?
+
+ESLint allows for the use of [custom parsers](https://eslint.org/docs/developer-guide/working-with-custom-parsers). When using this plugin, your code is parsed by Babel's parser (using the configuration specified in your [Babel configuration file](https://babeljs.io/docs/en/configuration)) and the resulting AST is
+transformed into an [ESTree](https://github.com/estree/estree)-compliant structure that ESLint can understand. All location info such as line numbers,
+columns is also retained so you can track down errors with ease.
+
+**Note:** ESLint's core rules do not support experimental syntax and may therefore not work as expected when using `@babel/eslint-parser`. Please use the companion [`@babel/eslint-plugin`](https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin) plugin for core rules that you have issues with.
+
+## Usage
+
+### Installation
+
+```sh
+$ npm install eslint @babel/core @babel/eslint-parser --save-dev
+# or
+$ yarn add eslint @babel/core @babel/eslint-parser -D
+```
+
+**Note:** @babel/eslint-parser requires `@babel/core@>=7.2.0` and a valid Babel configuration file to run. If you do not have this already set up, please see the [Babel Usage Guide](https://babeljs.io/docs/en/usage).
+
+### Setup
+
+To use @babel/eslint-parser, `"@babel/eslint-parser"` must be specified as the `parser` in your ESLint configuration file (see [here](https://eslint.org/docs/user-guide/configuring#specifying-parser) for more detailed information).
+
+**.eslintrc.js**
+
+```js
+module.exports = {
+ parser: "@babel/eslint-parser",
+};
+```
+
+With the parser set, your configuration can be configured as described in the [Configuring ESLint](https://eslint.org/docs/user-guide/configuring) documentation.
+
+**Note:** The `parserOptions` described in the [official documentation](https://eslint.org/docs/user-guide/configuring#specifying-parser-options) are for the default parser and are not necessarily supported by @babel/eslint-parser. Please see the section directly below for supported `parserOptions`.
+
+### Additional parser configuration
+
+Additional configuration options can be set in your ESLint configuration under the `parserOptions` key. Please note that the `ecmaFeatures` config property may still be required for ESLint to work properly with features not in ECMAScript 5 by default.
+
+- `requireConfigFile` (default `true`) can be set to `false` to allow @babel/eslint-parser to run on files that do not have a Babel configuration associated with them. This can be useful for linting files that are not transformed by Babel (such as tooling configuration files), though we recommend using the default parser via [glob-based configuration](https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns). Note: @babel/eslint-parser will not parse any experimental syntax when no configuration file is found.
+- `sourceType` can be set to `"module"`(default) or `"script"` if your code isn't using ECMAScript modules.
+- `allowImportExportEverywhere` (default `false`) can be set to `true` to allow import and export declarations to appear anywhere a statement is allowed if your build environment supports that. Otherwise import and export declarations can only appear at a program's top level.
+- `ecmaFeatures.globalReturn` (default `false`) allow return statements in the global scope when used with `sourceType: "script"`.
+- `babelOptions` passes through Babel's configuration [loading](https://babeljs.io/docs/en/options#config-loading-options) and [merging](https://babeljs.io/docs/en/options#config-merging-options) options (for instance, in case of a monorepo). When not defined, @babel/eslint-parser will use Babel's default configuration file resolution logic.
+
+**.eslintrc.js**
+
+```js
+module.exports = {
+ parser: "@babel/eslint-parser",
+ parserOptions: {
+ sourceType: "module",
+ allowImportExportEverywhere: false,
+ ecmaFeatures: {
+ globalReturn: false,
+ },
+ babelOptions: {
+ configFile: "path/to/config.js",
+ },
+ },
+};
+```
+
+**.eslintrc.js using glob-based configuration**
+
+This configuration would use the default parser for all files except for those found by the `"files/transformed/by/babel/*.js"` glob.
+
+```js
+module.exports = {
+ rules: {
+ indent: "error"
+ },
+ overrides: [
+ {
+ files: ["files/transformed/by/babel/*.js"],
+ parser: "@babel/eslint-parser",
+ }
+ ]
+};
+```
+
+### Run
+
+```sh
+$ ./node_modules/.bin/eslint yourfile.js
+```
+
+## Known issues
+
+Flow:
+
+> Check out [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype): An `eslint` plugin that makes flow type annotations global variables and marks declarations as used. Solves the problem of false positives with `no-undef` and `no-unused-vars`.
+
+- `no-undef` for global flow types: `ReactElement`, `ReactClass` [#130](https://github.com/babel/@babel/eslint-parser/issues/130#issuecomment-111215076)
+ - Workaround: define types as globals in `.eslintrc` or define types and import them `import type ReactElement from './types'`
+- `no-unused-vars/no-undef` with Flow declarations (`declare module A {}`) [#132](https://github.com/babel/@babel/eslint-parser/issues/132#issuecomment-112815926)
+
+Modules/strict mode
+
+- `no-unused-vars: ["error", { vars: local }]` [#136](https://github.com/babel/@babel/eslint-parser/issues/136)
+
+Please check out [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) for React/JSX issues.
+
+- `no-unused-vars` with jsx
+
+Please check out [eslint-plugin-babel](https://github.com/babel/eslint-plugin-babel) for other issues.
+
+## Questions and support
+
+If you have an issue, please first check if it can be reproduced with the default parser and with the latest versions of `eslint` and `@babel/eslint-parser`. If it is not reproducible with the default parser, it is most likely an issue with `@babel/eslint-parser`.
+
+For questions and support please visit the [`#discussion`](https://babeljs.slack.com/messages/discussion/) Babel Slack channel (sign up [here](https://github.com/babel/notes/issues/38)) or the ESLint [Gitter](https://gitter.im/eslint/eslint).
diff --git a/eslint/babel-eslint-parser/package.json b/eslint/babel-eslint-parser/package.json
new file mode 100644
index 000000000000..36218eb13c84
--- /dev/null
+++ b/eslint/babel-eslint-parser/package.json
@@ -0,0 +1,37 @@
+{
+ "name": "@babel/eslint-parser",
+ "version": "0.0.0",
+ "description": "ESLint parser that allows for linting of experimental syntax transformed by Babel",
+ "author": "Sebastian McKenzie ",
+ "license": "MIT",
+ "private": true,
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/babel/babel.git",
+ "directory": "eslint/babel-eslint-parser"
+ },
+ "bugs": {
+ "url": "https://github.com/babel/babel/issues"
+ },
+ "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-parser",
+ "engines": {
+ "node": ">=10.9"
+ },
+ "main": "lib/index.js",
+ "peerDependencies": {
+ "@babel/core": ">=7.2.0",
+ "eslint": ">=6.0.0"
+ },
+ "dependencies": {
+ "eslint-scope": "5.0.0",
+ "eslint-visitor-keys": "^1.1.0",
+ "semver": "^6.3.0"
+ },
+ "devDependencies": {
+ "@babel/core": "^7.2.0",
+ "@babel/eslint-shared-fixtures": "*",
+ "dedent": "^0.7.0",
+ "eslint": "^6.0.1",
+ "lodash.clonedeep": "^4.5.0"
+ }
+}
diff --git a/eslint/babel-eslint-parser/src/analyze-scope.js b/eslint/babel-eslint-parser/src/analyze-scope.js
new file mode 100644
index 000000000000..2a520438546b
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/analyze-scope.js
@@ -0,0 +1,344 @@
+import { types as t } from "@babel/core";
+import escope from "eslint-scope";
+import { Definition } from "eslint-scope/lib/definition";
+import OriginalPatternVisitor from "eslint-scope/lib/pattern-visitor";
+import OriginalReferencer from "eslint-scope/lib/referencer";
+import { getKeys as fallback } from "eslint-visitor-keys";
+import childVisitorKeys from "./visitor-keys";
+
+const flowFlippedAliasKeys = t.FLIPPED_ALIAS_KEYS.Flow.concat([
+ "ArrayPattern",
+ "ClassDeclaration",
+ "ClassExpression",
+ "FunctionDeclaration",
+ "FunctionExpression",
+ "Identifier",
+ "ObjectPattern",
+ "RestElement",
+]);
+
+const visitorKeysMap = Object.entries(t.VISITOR_KEYS).reduce(
+ (acc, [key, value]) => {
+ if (!flowFlippedAliasKeys.includes(value)) {
+ acc[key] = value;
+ }
+ return acc;
+ },
+ {},
+);
+
+const propertyTypes = {
+ // loops
+ callProperties: { type: "loop", values: ["value"] },
+ indexers: { type: "loop", values: ["key", "value"] },
+ properties: { type: "loop", values: ["argument", "value"] },
+ types: { type: "loop" },
+ params: { type: "loop" },
+ // single property
+ argument: { type: "single" },
+ elementType: { type: "single" },
+ qualification: { type: "single" },
+ rest: { type: "single" },
+ returnType: { type: "single" },
+ // others
+ typeAnnotation: { type: "typeAnnotation" },
+ typeParameters: { type: "typeParameters" },
+ id: { type: "id" },
+};
+
+class PatternVisitor extends OriginalPatternVisitor {
+ ArrayPattern(node) {
+ node.elements.forEach(this.visit, this);
+ }
+
+ ObjectPattern(node) {
+ node.properties.forEach(this.visit, this);
+ }
+}
+
+class Referencer extends OriginalReferencer {
+ // inherits.
+ visitPattern(node, options, callback) {
+ if (!node) {
+ return;
+ }
+
+ // Visit type annotations.
+ this._checkIdentifierOrVisit(node.typeAnnotation);
+ if (t.isAssignmentPattern(node)) {
+ this._checkIdentifierOrVisit(node.left.typeAnnotation);
+ }
+
+ // Overwrite `super.visitPattern(node, options, callback)` in order to not visit `ArrayPattern#typeAnnotation` and `ObjectPattern#typeAnnotation`.
+ if (typeof options === "function") {
+ callback = options;
+ options = { processRightHandNodes: false };
+ }
+
+ const visitor = new PatternVisitor(this.options, node, callback);
+ visitor.visit(node);
+
+ // Process the right hand nodes recursively.
+ if (options.processRightHandNodes) {
+ visitor.rightHandNodes.forEach(this.visit, this);
+ }
+ }
+
+ // inherits.
+ visitClass(node) {
+ // Decorators.
+ this._visitArray(node.decorators);
+
+ // Flow type parameters.
+ const typeParamScope = this._nestTypeParamScope(node);
+
+ // Flow super types.
+ this._visitTypeAnnotation(node.implements);
+ this._visitTypeAnnotation(
+ node.superTypeParameters && node.superTypeParameters.params,
+ );
+
+ // Basic.
+ super.visitClass(node);
+
+ // Close the type parameter scope.
+ if (typeParamScope) {
+ this.close(node);
+ }
+ }
+
+ // inherits.
+ visitFunction(node) {
+ const typeParamScope = this._nestTypeParamScope(node);
+
+ // Flow return types.
+ this._checkIdentifierOrVisit(node.returnType);
+
+ // Basic.
+ super.visitFunction(node);
+
+ // Close the type parameter scope.
+ if (typeParamScope) {
+ this.close(node);
+ }
+ }
+
+ // inherits.
+ visitProperty(node) {
+ if (node.value?.type === "TypeCastExpression") {
+ this._visitTypeAnnotation(node.value);
+ }
+ this._visitArray(node.decorators);
+ super.visitProperty(node);
+ }
+
+ InterfaceDeclaration(node) {
+ this._createScopeVariable(node, node.id);
+
+ const typeParamScope = this._nestTypeParamScope(node);
+
+ // TODO: Handle mixins
+ this._visitArray(node.extends);
+ this.visit(node.body);
+
+ if (typeParamScope) {
+ this.close(node);
+ }
+ }
+
+ TypeAlias(node) {
+ this._createScopeVariable(node, node.id);
+
+ const typeParamScope = this._nestTypeParamScope(node);
+
+ this.visit(node.right);
+
+ if (typeParamScope) {
+ this.close(node);
+ }
+ }
+
+ ClassProperty(node) {
+ this._visitClassProperty(node);
+ }
+
+ ClassPrivateProperty(node) {
+ this._visitClassProperty(node);
+ }
+
+ // TODO: Update to visit type annotations when TypeScript/Flow support this syntax.
+ ClassPrivateMethod(node) {
+ super.MethodDefinition(node);
+ }
+
+ DeclareModule(node) {
+ this._visitDeclareX(node);
+ }
+
+ DeclareFunction(node) {
+ this._visitDeclareX(node);
+ }
+
+ DeclareVariable(node) {
+ this._visitDeclareX(node);
+ }
+
+ DeclareClass(node) {
+ this._visitDeclareX(node);
+ }
+
+ // visit OptionalMemberExpression as a MemberExpression.
+ OptionalMemberExpression(node) {
+ super.MemberExpression(node);
+ }
+
+ _visitClassProperty(node) {
+ this._visitTypeAnnotation(node.typeAnnotation);
+ this.visitProperty(node);
+ }
+
+ _visitDeclareX(node) {
+ if (node.id) {
+ this._createScopeVariable(node, node.id);
+ }
+
+ const typeParamScope = this._nestTypeParamScope(node);
+ if (typeParamScope) {
+ this.close(node);
+ }
+ }
+
+ _createScopeVariable(node, name) {
+ this.currentScope().variableScope.__define(
+ name,
+ new Definition("Variable", name, node, null, null, null),
+ );
+ }
+
+ _nestTypeParamScope(node) {
+ if (!node.typeParameters) {
+ return null;
+ }
+
+ const parentScope = this.scopeManager.__currentScope;
+ const scope = new escope.Scope(
+ this.scopeManager,
+ "type-parameters",
+ parentScope,
+ node,
+ false,
+ );
+
+ this.scopeManager.__nestScope(scope);
+ for (let j = 0; j < node.typeParameters.params.length; j++) {
+ const name = node.typeParameters.params[j];
+ scope.__define(name, new Definition("TypeParameter", name, name));
+ if (name.typeAnnotation) {
+ this._checkIdentifierOrVisit(name);
+ }
+ }
+ scope.__define = function() {
+ return parentScope.__define.apply(parentScope, arguments);
+ };
+
+ return scope;
+ }
+
+ _visitTypeAnnotation(node) {
+ if (!node) {
+ return;
+ }
+ if (Array.isArray(node)) {
+ node.forEach(this._visitTypeAnnotation, this);
+ return;
+ }
+
+ // get property to check (params, id, etc...)
+ const visitorValues = visitorKeysMap[node.type];
+ if (!visitorValues) {
+ return;
+ }
+
+ // can have multiple properties
+ for (let i = 0; i < visitorValues.length; i++) {
+ const visitorValue = visitorValues[i];
+ const propertyType = propertyTypes[visitorValue];
+ const nodeProperty = node[visitorValue];
+ // check if property or type is defined
+ if (propertyType == null || nodeProperty == null) {
+ continue;
+ }
+ if (propertyType.type === "loop") {
+ for (let j = 0; j < nodeProperty.length; j++) {
+ if (Array.isArray(propertyType.values)) {
+ for (let k = 0; k < propertyType.values.length; k++) {
+ const loopPropertyNode = nodeProperty[j][propertyType.values[k]];
+ if (loopPropertyNode) {
+ this._checkIdentifierOrVisit(loopPropertyNode);
+ }
+ }
+ } else {
+ this._checkIdentifierOrVisit(nodeProperty[j]);
+ }
+ }
+ } else if (propertyType.type === "single") {
+ this._checkIdentifierOrVisit(nodeProperty);
+ } else if (propertyType.type === "typeAnnotation") {
+ this._visitTypeAnnotation(node.typeAnnotation);
+ } else if (propertyType.type === "typeParameters") {
+ for (let l = 0; l < node.typeParameters.params.length; l++) {
+ this._checkIdentifierOrVisit(node.typeParameters.params[l]);
+ }
+ } else if (propertyType.type === "id") {
+ if (node.id.type === "Identifier") {
+ this._checkIdentifierOrVisit(node.id);
+ } else {
+ this._visitTypeAnnotation(node.id);
+ }
+ }
+ }
+ }
+
+ _checkIdentifierOrVisit(node) {
+ if (node?.typeAnnotation) {
+ this._visitTypeAnnotation(node.typeAnnotation);
+ } else if (node?.type === "Identifier") {
+ this.visit(node);
+ } else {
+ this._visitTypeAnnotation(node);
+ }
+ }
+
+ _visitArray(nodeList) {
+ if (nodeList) {
+ for (const node of nodeList) {
+ this.visit(node);
+ }
+ }
+ }
+}
+
+export default function analyzeScope(ast, parserOptions) {
+ const options = {
+ ignoreEval: true,
+ optimistic: false,
+ directive: false,
+ nodejsScope:
+ ast.sourceType === "script" &&
+ (parserOptions.ecmaFeatures &&
+ parserOptions.ecmaFeatures.globalReturn) === true,
+ impliedStrict: false,
+ sourceType: ast.sourceType,
+ ecmaVersion: parserOptions.ecmaVersion,
+ fallback,
+ };
+
+ options.childVisitorKeys = childVisitorKeys;
+
+ const scopeManager = new escope.ScopeManager(options);
+ const referencer = new Referencer(options, scopeManager);
+
+ referencer.visit(ast);
+
+ return scopeManager;
+}
diff --git a/eslint/babel-eslint-parser/src/configuration.js b/eslint/babel-eslint-parser/src/configuration.js
new file mode 100644
index 000000000000..e6d036372f12
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/configuration.js
@@ -0,0 +1,61 @@
+import { loadPartialConfig } from "@babel/core";
+
+export function normalizeESLintConfig(options) {
+ const defaultOptions = {
+ babelOptions: {},
+ ecmaVersion: 2020,
+ sourceType: "module",
+ allowImportExportEverywhere: false,
+ };
+
+ return Object.assign(defaultOptions, options);
+}
+
+export function normalizeBabelParseConfig(options) {
+ const parseOptions = {
+ sourceType: options.sourceType,
+ filename: options.filePath,
+ cwd: options.babelOptions.cwd,
+ root: options.babelOptions.root,
+ rootMode: options.babelOptions.rootMode,
+ envName: options.babelOptions.envName,
+ configFile: options.babelOptions.configFile,
+ babelrc: options.babelOptions.babelrc,
+ babelrcRoots: options.babelOptions.babelrcRoots,
+ extends: options.babelOptions.extends,
+ env: options.babelOptions.env,
+ overrides: options.babelOptions.overrides,
+ test: options.babelOptions.test,
+ include: options.babelOptions.include,
+ exclude: options.babelOptions.exclude,
+ ignore: options.babelOptions.ignore,
+ only: options.babelOptions.only,
+ parserOpts: {
+ allowImportExportEverywhere: options.allowImportExportEverywhere,
+ allowReturnOutsideFunction: true,
+ allowSuperOutsideMethod: true,
+ ranges: true,
+ tokens: true,
+ plugins: ["estree"],
+ },
+ caller: {
+ name: "@babel/eslint-parser",
+ },
+ };
+
+ if (options.requireConfigFile !== false) {
+ const config = loadPartialConfig(parseOptions);
+
+ if (config !== null) {
+ if (!config.hasFilesystemConfig()) {
+ throw new Error(
+ `No Babel config file detected for ${config.options.filename}. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files.`,
+ );
+ }
+
+ return config.options;
+ }
+ }
+
+ return parseOptions;
+}
diff --git a/eslint/babel-eslint-parser/src/convert/convertAST.js b/eslint/babel-eslint-parser/src/convert/convertAST.js
new file mode 100644
index 000000000000..4cee65d0f6f7
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/convert/convertAST.js
@@ -0,0 +1,138 @@
+import { types as t, traverse } from "@babel/core";
+
+function convertNodes(ast, code) {
+ const astTransformVisitor = {
+ noScope: true,
+ enter(path) {
+ const { node } = path;
+
+ if (node.innerComments) {
+ delete node.innerComments;
+ }
+
+ if (node.trailingComments) {
+ delete node.trailingComments;
+ }
+
+ if (node.leadingComments) {
+ delete node.leadingComments;
+ }
+ },
+ exit(path) {
+ const { node } = path;
+
+ // Used internally by @babel/parser.
+ if (node.extra) {
+ delete node.extra;
+ }
+
+ if (node?.loc.identifierName) {
+ delete node.loc.identifierName;
+ }
+
+ if (path.isTypeParameter()) {
+ node.type = "Identifier";
+ node.typeAnnotation = node.bound;
+ delete node.bound;
+ }
+
+ // flow: prevent "no-undef"
+ // for "Component" in: "let x: React.Component"
+ if (path.isQualifiedTypeIdentifier()) {
+ delete node.id;
+ }
+ // for "b" in: "var a: { b: Foo }"
+ if (path.isObjectTypeProperty()) {
+ delete node.key;
+ }
+ // for "indexer" in: "var a: {[indexer: string]: number}"
+ if (path.isObjectTypeIndexer()) {
+ delete node.id;
+ }
+ // for "param" in: "var a: { func(param: Foo): Bar };"
+ if (path.isFunctionTypeParam()) {
+ delete node.name;
+ }
+
+ // modules
+ if (path.isImportDeclaration()) {
+ delete node.isType;
+ }
+
+ // template string range fixes
+ if (path.isTemplateLiteral()) {
+ for (let i = 0; i < node.quasis.length; i++) {
+ const q = node.quasis[i];
+ q.range[0] -= 1;
+ if (q.tail) {
+ q.range[1] += 1;
+ } else {
+ q.range[1] += 2;
+ }
+ q.loc.start.column -= 1;
+ if (q.tail) {
+ q.loc.end.column += 1;
+ } else {
+ q.loc.end.column += 2;
+ }
+ }
+ }
+ },
+ };
+ const state = { source: code };
+
+ // Monkey patch visitor keys in order to be able to traverse the estree nodes
+ t.VISITOR_KEYS.Property = t.VISITOR_KEYS.ObjectProperty;
+ t.VISITOR_KEYS.MethodDefinition = [
+ "key",
+ "value",
+ "decorators",
+ "returnType",
+ "typeParameters",
+ ];
+
+ traverse(ast, astTransformVisitor, null, state);
+
+ // These can be safely deleted because they are not defined in the original visitor keys.
+ delete t.VISITOR_KEYS.Property;
+ delete t.VISITOR_KEYS.MethodDefinition;
+}
+
+function convertProgramNode(ast) {
+ ast.type = "Program";
+ ast.sourceType = ast.program.sourceType;
+ ast.body = ast.program.body;
+ delete ast.program;
+ delete ast.errors;
+
+ if (ast.comments.length) {
+ const lastComment = ast.comments[ast.comments.length - 1];
+
+ if (ast.tokens.length) {
+ const lastToken = ast.tokens[ast.tokens.length - 1];
+
+ if (lastComment.end > lastToken.end) {
+ // If there is a comment after the last token, the program ends at the
+ // last token and not the comment
+ ast.range[1] = lastToken.end;
+ ast.loc.end.line = lastToken.loc.end.line;
+ ast.loc.end.column = lastToken.loc.end.column;
+ }
+ }
+ } else {
+ if (!ast.tokens.length) {
+ ast.loc.start.line = 1;
+ ast.loc.end.line = 1;
+ }
+ }
+
+ if (ast.body && ast.body.length > 0) {
+ ast.loc.start.line = ast.body[0].loc.start.line;
+ ast.range[0] = ast.body[0].start;
+ }
+}
+
+export default function convertAST(ast, code) {
+ convertNodes(ast, code);
+ convertProgramNode(ast);
+}
diff --git a/eslint/babel-eslint-parser/src/convert/convertComments.js b/eslint/babel-eslint-parser/src/convert/convertComments.js
new file mode 100644
index 000000000000..854c3440c590
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/convert/convertComments.js
@@ -0,0 +1,14 @@
+export default function convertComments(comments) {
+ for (const comment of comments) {
+ if (comment.type === "CommentBlock") {
+ comment.type = "Block";
+ } else if (comment.type === "CommentLine") {
+ comment.type = "Line";
+ }
+ // sometimes comments don't get ranges computed,
+ // even with options.ranges === true
+ if (!comment.range) {
+ comment.range = [comment.start, comment.end];
+ }
+ }
+}
diff --git a/eslint/babel-eslint-parser/src/convert/convertTokens.js b/eslint/babel-eslint-parser/src/convert/convertTokens.js
new file mode 100644
index 000000000000..402f02ebe6c6
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/convert/convertTokens.js
@@ -0,0 +1,185 @@
+import { tokTypes as tt } from "@babel/core";
+
+function convertTemplateType(tokens) {
+ let curlyBrace = null;
+ let templateTokens = [];
+ const result = [];
+
+ function addTemplateType() {
+ const start = templateTokens[0];
+ const end = templateTokens[templateTokens.length - 1];
+
+ const value = templateTokens.reduce((result, token) => {
+ if (token.value) {
+ result += token.value;
+ } else if (token.type !== tt.template) {
+ result += token.type.label;
+ }
+
+ return result;
+ }, "");
+
+ result.push({
+ type: "Template",
+ value: value,
+ start: start.start,
+ end: end.end,
+ loc: {
+ start: start.loc.start,
+ end: end.loc.end,
+ },
+ });
+
+ templateTokens = [];
+ }
+
+ tokens.forEach(token => {
+ switch (token.type) {
+ case tt.backQuote:
+ if (curlyBrace) {
+ result.push(curlyBrace);
+ curlyBrace = null;
+ }
+
+ templateTokens.push(token);
+
+ if (templateTokens.length > 1) {
+ addTemplateType();
+ }
+
+ break;
+
+ case tt.dollarBraceL:
+ templateTokens.push(token);
+ addTemplateType();
+ break;
+
+ case tt.braceR:
+ if (curlyBrace) {
+ result.push(curlyBrace);
+ }
+
+ curlyBrace = token;
+ break;
+
+ case tt.template:
+ if (curlyBrace) {
+ templateTokens.push(curlyBrace);
+ curlyBrace = null;
+ }
+
+ templateTokens.push(token);
+ break;
+
+ case tt.eof:
+ if (curlyBrace) {
+ result.push(curlyBrace);
+ }
+
+ break;
+
+ default:
+ if (curlyBrace) {
+ result.push(curlyBrace);
+ curlyBrace = null;
+ }
+
+ result.push(token);
+ }
+ });
+
+ return result;
+}
+
+function convertToken(token, source) {
+ const type = token.type;
+ token.range = [token.start, token.end];
+
+ if (type === tt.name) {
+ token.type = "Identifier";
+ } else if (
+ type === tt.semi ||
+ type === tt.comma ||
+ type === tt.parenL ||
+ type === tt.parenR ||
+ type === tt.braceL ||
+ type === tt.braceR ||
+ type === tt.slash ||
+ type === tt.dot ||
+ type === tt.bracketL ||
+ type === tt.bracketR ||
+ type === tt.ellipsis ||
+ type === tt.arrow ||
+ type === tt.pipeline ||
+ type === tt.star ||
+ type === tt.incDec ||
+ type === tt.colon ||
+ type === tt.question ||
+ type === tt.questionDot ||
+ type === tt.template ||
+ type === tt.backQuote ||
+ type === tt.dollarBraceL ||
+ type === tt.at ||
+ type === tt.logicalOR ||
+ type === tt.logicalAND ||
+ type === tt.nullishCoalescing ||
+ type === tt.bitwiseOR ||
+ type === tt.bitwiseXOR ||
+ type === tt.bitwiseAND ||
+ type === tt.equality ||
+ type === tt.relational ||
+ type === tt.bitShift ||
+ type === tt.plusMin ||
+ type === tt.modulo ||
+ type === tt.exponent ||
+ type === tt.bang ||
+ type === tt.tilde ||
+ type === tt.doubleColon ||
+ type === tt.hash ||
+ type.isAssign
+ ) {
+ token.type = "Punctuator";
+ if (!token.value) token.value = type.label;
+ } else if (type === tt.jsxTagStart) {
+ token.type = "Punctuator";
+ token.value = "<";
+ } else if (type === tt.jsxTagEnd) {
+ token.type = "Punctuator";
+ token.value = ">";
+ } else if (type === tt.jsxName) {
+ token.type = "JSXIdentifier";
+ } else if (type === tt.jsxText) {
+ token.type = "JSXText";
+ } else if (type.keyword === "null") {
+ token.type = "Null";
+ } else if (type.keyword === "false" || type.keyword === "true") {
+ token.type = "Boolean";
+ } else if (type.keyword) {
+ token.type = "Keyword";
+ } else if (type === tt.num) {
+ token.type = "Numeric";
+ token.value = source.slice(token.start, token.end);
+ } else if (type === tt.string) {
+ token.type = "String";
+ token.value = source.slice(token.start, token.end);
+ } else if (type === tt.regexp) {
+ token.type = "RegularExpression";
+ const value = token.value;
+ token.regex = {
+ pattern: value.pattern,
+ flags: value.flags,
+ };
+ token.value = `/${value.pattern}/${value.flags}`;
+ } else if (type === tt.bigint) {
+ token.type = "Numeric";
+ token.value = `${token.value}n`;
+ }
+
+ return token;
+}
+
+export default function convertTokens(tokens, code) {
+ return convertTemplateType(tokens)
+ .filter(t => t.type !== "CommentLine" && t.type !== "CommentBlock")
+ .map(t => convertToken(t, code));
+}
diff --git a/eslint/babel-eslint-parser/src/convert/index.js b/eslint/babel-eslint-parser/src/convert/index.js
new file mode 100644
index 000000000000..7a9de2b4cc0b
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/convert/index.js
@@ -0,0 +1,9 @@
+import convertTokens from "./convertTokens";
+import convertComments from "./convertComments";
+import convertAST from "./convertAST";
+
+export default function(ast, code) {
+ ast.tokens = convertTokens(ast.tokens, code);
+ convertComments(ast.comments);
+ convertAST(ast, code);
+}
diff --git a/eslint/babel-eslint-parser/src/index.js b/eslint/babel-eslint-parser/src/index.js
new file mode 100644
index 000000000000..2d54014b4468
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/index.js
@@ -0,0 +1,26 @@
+import semver from "semver";
+import { version as CURRENT_BABEL_VERSION } from "@babel/core";
+import parseWithScope from "./parse-with-scope";
+import { normalizeESLintConfig } from "./configuration";
+import packageJson from "../package.json";
+
+const SUPPORTED_BABEL_VERSION_RANGE =
+ packageJson.peerDependencies["@babel/core"];
+const IS_RUNNING_SUPPORTED_VERSION = semver.satisfies(
+ CURRENT_BABEL_VERSION,
+ SUPPORTED_BABEL_VERSION_RANGE,
+);
+
+export function parse(code, options) {
+ return parseForESLint(code, options).ast;
+}
+
+export function parseForESLint(code, options = {}) {
+ if (!IS_RUNNING_SUPPORTED_VERSION) {
+ throw new Error(
+ `babel-eslint@${packageJson.version} does not support @babel/core@${CURRENT_BABEL_VERSION}. Please downgrade to babel-eslint@^10 or upgrade to @babel/core@${SUPPORTED_BABEL_VERSION_RANGE}`,
+ );
+ }
+
+ return parseWithScope(code, normalizeESLintConfig(options));
+}
diff --git a/eslint/babel-eslint-parser/src/parse-with-scope.js b/eslint/babel-eslint-parser/src/parse-with-scope.js
new file mode 100644
index 000000000000..9d29b67f10d7
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/parse-with-scope.js
@@ -0,0 +1,10 @@
+import visitorKeys from "./visitor-keys";
+import analyzeScope from "./analyze-scope";
+import parse from "./parse";
+
+export default function parseWithScope(code, options) {
+ const ast = parse(code, options);
+ const scopeManager = analyzeScope(ast, options);
+
+ return { ast, scopeManager, visitorKeys };
+}
diff --git a/eslint/babel-eslint-parser/src/parse.js b/eslint/babel-eslint-parser/src/parse.js
new file mode 100644
index 000000000000..9410fcba01d3
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/parse.js
@@ -0,0 +1,23 @@
+import { parseSync as babelParse } from "@babel/core";
+import convert from "./convert";
+import { normalizeBabelParseConfig } from "./configuration";
+
+export default function parse(code, options) {
+ const parseOptions = normalizeBabelParseConfig(options);
+ let ast;
+
+ try {
+ ast = babelParse(code, parseOptions);
+ } catch (err) {
+ if (err instanceof SyntaxError) {
+ err.lineNumber = err.loc.line;
+ err.column = err.loc.column;
+ }
+
+ throw err;
+ }
+
+ convert(ast, code);
+
+ return ast;
+}
diff --git a/eslint/babel-eslint-parser/src/visitor-keys.js b/eslint/babel-eslint-parser/src/visitor-keys.js
new file mode 100644
index 000000000000..6676a86602e3
--- /dev/null
+++ b/eslint/babel-eslint-parser/src/visitor-keys.js
@@ -0,0 +1,15 @@
+import { types as t } from "@babel/core";
+import { KEYS as ESLINT_VISITOR_KEYS } from "eslint-visitor-keys";
+
+const { VISITOR_KEYS: BABEL_VISITOR_KEYS } = t;
+
+export default Object.assign(
+ {
+ Literal: ESLINT_VISITOR_KEYS.Literal,
+ MethodDefinition: ["decorators"].concat(
+ ESLINT_VISITOR_KEYS.MethodDefinition,
+ ),
+ Property: ["decorators"].concat(ESLINT_VISITOR_KEYS.Property),
+ },
+ BABEL_VISITOR_KEYS,
+);
diff --git a/eslint/babel-eslint-parser/test/index.js b/eslint/babel-eslint-parser/test/index.js
new file mode 100644
index 000000000000..6fd61c84142c
--- /dev/null
+++ b/eslint/babel-eslint-parser/test/index.js
@@ -0,0 +1,596 @@
+import path from "path";
+import { pathToFileURL } from "url";
+import escope from "eslint-scope";
+import unpad from "dedent";
+import { parseForESLint } from "../src";
+
+const BABEL_OPTIONS = {
+ configFile: require.resolve(
+ "@babel/eslint-shared-fixtures/config/babel.config.js",
+ ),
+};
+const PROPS_TO_REMOVE = [
+ "importKind",
+ "exportKind",
+ "variance",
+ "typeArguments",
+];
+// We can remove needing to drop "exported" if null once this lands:
+// https://github.com/acornjs/acorn/pull/889
+const PROPS_TO_REMOVE_IF_NULL = ["exported"];
+
+function deeplyRemoveProperties(obj, props, propsIfNull) {
+ for (const [k, v] of Object.entries(obj)) {
+ if (typeof v === "object") {
+ if (Array.isArray(v)) {
+ for (const el of v) {
+ if (el != null) {
+ deeplyRemoveProperties(el, props, propsIfNull);
+ }
+ }
+ }
+
+ if (props.includes(k) || (propsIfNull.includes(k) && v === null)) {
+ delete obj[k];
+ } else if (v != null) {
+ deeplyRemoveProperties(v, props, propsIfNull);
+ }
+ continue;
+ }
+
+ if (props.includes(k) || (propsIfNull.includes(k) && v === null)) {
+ delete obj[k];
+ }
+ }
+}
+
+describe("Babel and Espree", () => {
+ let espree;
+
+ function parseAndAssertSame(code) {
+ code = unpad(code);
+ const espreeAST = espree.parse(code, {
+ ecmaFeatures: {
+ // enable JSX parsing
+ jsx: true,
+ // enable return in global scope
+ globalReturn: true,
+ // enable implied strict mode (if ecmaVersion >= 5)
+ impliedStrict: true,
+ // allow experimental object rest/spread
+ experimentalObjectRestSpread: true,
+ },
+ tokens: true,
+ loc: true,
+ range: true,
+ comment: true,
+ ecmaVersion: 2020,
+ sourceType: "module",
+ });
+ const babelAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ deeplyRemoveProperties(babelAST, PROPS_TO_REMOVE, PROPS_TO_REMOVE_IF_NULL);
+ expect(babelAST).toEqual(espreeAST);
+ }
+
+ beforeAll(async () => {
+ // Use the version of Espree that is a dependency of
+ // the version of ESLint we are testing against.
+ const espreePath = require.resolve("espree", {
+ paths: [path.dirname(require.resolve("eslint"))],
+ });
+
+ espree = await import(pathToFileURL(espreePath));
+ });
+
+ describe("compatibility", () => {
+ it("should allow ast.analyze to be called without options", function() {
+ const ast = parseForESLint("`test`", {
+ eslintScopeManager: true,
+ eslintVisitorKeys: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(() => {
+ escope.analyze(ast);
+ }).not.toThrow(new TypeError("Should allow no options argument."));
+ });
+ });
+
+ describe("templates", () => {
+ it("empty template string", () => {
+ parseAndAssertSame("``");
+ });
+
+ it("template string", () => {
+ parseAndAssertSame("`test`");
+ });
+
+ it("template string using $", () => {
+ parseAndAssertSame("`$`");
+ });
+
+ it("template string with expression", () => {
+ parseAndAssertSame("`${a}`");
+ });
+
+ it("template string with multiple expressions", () => {
+ parseAndAssertSame("`${a}${b}${c}`");
+ });
+
+ it("template string with expression and strings", () => {
+ parseAndAssertSame("`a${a}a`");
+ });
+
+ it("template string with binary expression", () => {
+ parseAndAssertSame("`a${a + b}a`");
+ });
+
+ it("tagged template", () => {
+ parseAndAssertSame("jsx``");
+ });
+
+ it("tagged template with expression", () => {
+ parseAndAssertSame("jsx``");
+ });
+
+ it("tagged template with new operator", () => {
+ parseAndAssertSame("new raw`42`");
+ });
+
+ it("template with nested function/object", () => {
+ parseAndAssertSame(
+ "`outer${{x: {y: 10}}}bar${`nested${function(){return 1;}}endnest`}end`",
+ );
+ });
+
+ it("template with braces inside and outside of template string #96", () => {
+ parseAndAssertSame(
+ "if (a) { var target = `{}a:${webpackPort}{}}}}`; } else { app.use(); }",
+ );
+ });
+
+ it("template also with braces #96", () => {
+ parseAndAssertSame(`
+ export default function f1() {
+ function f2(foo) {
+ const bar = 3;
+ return \`\${foo} \${bar}\`;
+ }
+ return f2;
+ }
+ `);
+ });
+
+ it("template with destructuring #31", () => {
+ parseAndAssertSame(`
+ module.exports = {
+ render() {
+ var {name} = this.props;
+ return Math.max(null, \`Name: \${name}, Name: \${name}\`);
+ }
+ };
+ `);
+ });
+
+ it("template with arrow returning template #603", () => {
+ parseAndAssertSame(`
+ var a = \`\${() => {
+ \`\${''}\`
+ }}\`;
+ `);
+ });
+
+ it("template string with object with template string inside", () => {
+ parseAndAssertSame("`${ { a:`${2}` } }`");
+ });
+ });
+
+ it("simple expression", () => {
+ parseAndAssertSame("a = 1");
+ });
+
+ it("logical NOT", () => {
+ parseAndAssertSame("!0");
+ });
+
+ it("bitwise NOT", () => {
+ parseAndAssertSame("~0");
+ });
+
+ it("class declaration", () => {
+ parseAndAssertSame("class Foo {}");
+ });
+
+ it("class expression", () => {
+ parseAndAssertSame("var a = class Foo {}");
+ });
+
+ it("jsx expression", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsx expression with 'this' as identifier", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsx expression with a dynamic attribute", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsx expression with a member expression as identifier", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsx expression with spread", () => {
+ parseAndAssertSame("var myDivElement = ;");
+ });
+
+ it("empty jsx text", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsx text with content", () => {
+ parseAndAssertSame("Hello, world!");
+ });
+
+ it("nested jsx", () => {
+ parseAndAssertSame("
\n
Wat
\n
");
+ });
+
+ it("default import", () => {
+ parseAndAssertSame('import foo from "foo";');
+ });
+
+ it("import specifier", () => {
+ parseAndAssertSame('import { foo } from "foo";');
+ });
+
+ it("import specifier with name", () => {
+ parseAndAssertSame('import { foo as bar } from "foo";');
+ });
+
+ it("import bare", () => {
+ parseAndAssertSame('import "foo";');
+ });
+
+ it("export default class declaration", () => {
+ parseAndAssertSame("export default class Foo {}");
+ });
+
+ it("export default class expression", () => {
+ parseAndAssertSame("export default class {}");
+ });
+
+ it("export default function declaration", () => {
+ parseAndAssertSame("export default function Foo() {}");
+ });
+
+ it("export default function expression", () => {
+ parseAndAssertSame("export default function () {}");
+ });
+
+ it("export all", () => {
+ parseAndAssertSame('export * from "foo";');
+ });
+
+ // Espree doesn't support `export * as ns` yet
+ it("export * as ns", () => {
+ const code = 'export * as Foo from "foo";';
+ const babylonAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(babylonAST.tokens[1].type).toEqual("Punctuator");
+ });
+
+ it("export named", () => {
+ parseAndAssertSame("var foo = 1;export { foo };");
+ });
+
+ it("export named alias", () => {
+ parseAndAssertSame("var foo = 1;export { foo as bar };");
+ });
+
+ // Espree doesn't support the optional chaining operator yet
+ it("optional chaining operator (token)", () => {
+ const code = "foo?.bar";
+ const babylonAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(babylonAST.tokens[1].type).toEqual("Punctuator");
+ });
+
+ // Espree doesn't support the nullish coalescing operator yet
+ it("nullish coalescing operator (token)", () => {
+ const code = "foo ?? bar";
+ const babylonAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(babylonAST.tokens[1].type).toEqual("Punctuator");
+ });
+
+ // Espree doesn't support the pipeline operator yet
+ it("pipeline operator (token)", () => {
+ const code = "foo |> bar";
+ const babylonAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(babylonAST.tokens[1].type).toEqual("Punctuator");
+ });
+
+ // Espree doesn't support private fields yet
+ it("hash (token)", () => {
+ const code = "class A { #x }";
+ const babylonAST = parseForESLint(code, {
+ eslintVisitorKeys: true,
+ eslintScopeManager: true,
+ babelOptions: BABEL_OPTIONS,
+ }).ast;
+ expect(babylonAST.tokens[3].type).toEqual("Punctuator");
+ expect(babylonAST.tokens[3].value).toEqual("#");
+ });
+
+ it("empty program with line comment", () => {
+ parseAndAssertSame("// single comment");
+ });
+
+ it("empty program with block comment", () => {
+ parseAndAssertSame(" /* multiline\n * comment\n*/");
+ });
+
+ it("line comments", () => {
+ parseAndAssertSame(`
+ // single comment
+ var foo = 15; // comment next to statement
+ // second comment after statement
+ `);
+ });
+
+ it("block comments", () => {
+ parseAndAssertSame(`
+ /* single comment */
+ var foo = 15; /* comment next to statement */
+ /*
+ * multiline
+ * comment
+ */
+ `);
+ });
+
+ it("block comments #124", () => {
+ parseAndAssertSame(`
+ React.createClass({
+ render() {
+ // return (
+ //
+ // ); // <-- this is the line that is reported
+ }
+ });
+ `);
+ });
+
+ it("null", () => {
+ parseAndAssertSame("null");
+ });
+
+ it("boolean", () => {
+ parseAndAssertSame("if (true) {} else if (false) {}");
+ });
+
+ it("regexp", () => {
+ parseAndAssertSame("/affix-top|affix-bottom|affix|[a-z]/");
+ });
+
+ it("regexp", () => {
+ parseAndAssertSame("const foo = /foo/;");
+ });
+
+ it("regexp y flag", () => {
+ parseAndAssertSame("const foo = /foo/y;");
+ });
+
+ it("regexp u flag", () => {
+ parseAndAssertSame("const foo = /foo/u;");
+ });
+
+ it("regexp in a template string", () => {
+ parseAndAssertSame('`${/\\d/.exec("1")[0]}`');
+ });
+
+ it("first line is empty", () => {
+ parseAndAssertSame('\nimport Immutable from "immutable";');
+ });
+
+ it("empty", () => {
+ parseAndAssertSame("");
+ });
+
+ it("jsdoc", () => {
+ parseAndAssertSame(`
+ /**
+ * @param {object} options
+ * @return {number}
+ */
+ const test = function({ a, b, c }) {
+ return a + b + c;
+ };
+ module.exports = test;
+ `);
+ });
+
+ it("empty block with comment", () => {
+ parseAndAssertSame(`
+ function a () {
+ try {
+ b();
+ } catch (e) {
+ // asdf
+ }
+ }
+ `);
+ });
+
+ describe("babel tests", () => {
+ it("MethodDefinition", () => {
+ parseAndAssertSame(`
+ export default class A {
+ a() {}
+ }
+ `);
+ });
+
+ it("MethodDefinition 2", () => {
+ parseAndAssertSame(
+ "export default class Bar { get bar() { return 42; }}",
+ );
+ });
+
+ it("ClassMethod", () => {
+ parseAndAssertSame(`
+ class A {
+ constructor() {
+ }
+ }
+ `);
+ });
+
+ it("ClassMethod multiple params", () => {
+ parseAndAssertSame(`
+ class A {
+ constructor(a, b, c) {
+ }
+ }
+ `);
+ });
+
+ it("ClassMethod multiline", () => {
+ parseAndAssertSame(`
+ class A {
+ constructor (
+ a,
+ b,
+ c
+ )
+
+ {
+
+ }
+ }
+ `);
+ });
+
+ it("ClassMethod oneline", () => {
+ parseAndAssertSame("class A { constructor(a, b, c) {} }");
+ });
+
+ it("ObjectMethod", () => {
+ parseAndAssertSame(`
+ var a = {
+ b(c) {
+ }
+ }
+ `);
+ });
+
+ it("do not allow import export everywhere", () => {
+ expect(() => {
+ parseAndAssertSame('function F() { import a from "a"; }');
+ }).toThrow(
+ new SyntaxError(
+ "'import' and 'export' may only appear at the top level",
+ ),
+ );
+ });
+
+ it("return outside function", () => {
+ parseAndAssertSame("return;");
+ });
+
+ it("super outside method", () => {
+ expect(() => {
+ parseAndAssertSame("function F() { super(); }");
+ }).toThrow(new SyntaxError("'super' keyword outside a method"));
+ });
+
+ it("StringLiteral", () => {
+ parseAndAssertSame("");
+ parseAndAssertSame("");
+ parseAndAssertSame("a");
+ });
+
+ it("getters and setters", () => {
+ parseAndAssertSame("class A { get x ( ) { ; } }");
+ parseAndAssertSame(`
+ class A {
+ get x(
+ )
+ {
+ ;
+ }
+ }
+ `);
+ parseAndAssertSame("class A { set x (a) { ; } }");
+ parseAndAssertSame(`
+ class A {
+ set x(a
+ )
+ {
+ ;
+ }
+ }
+ `);
+ parseAndAssertSame(`
+ var B = {
+ get x () {
+ return this.ecks;
+ },
+ set x (ecks) {
+ this.ecks = ecks;
+ }
+ };
+ `);
+ });
+
+ it("RestOperator", () => {
+ parseAndAssertSame("var { a, ...b } = c");
+ parseAndAssertSame("var [ a, ...b ] = c");
+ parseAndAssertSame("var a = function (...b) {}");
+ });
+
+ it("SpreadOperator", () => {
+ parseAndAssertSame("var a = { b, ...c }");
+ parseAndAssertSame("var a = [ a, ...b ]");
+ parseAndAssertSame("var a = sum(...b)");
+ });
+
+ it("Async/Await", () => {
+ parseAndAssertSame(`
+ async function a() {
+ await 1;
+ }
+ `);
+ });
+
+ it("BigInt", () => {
+ parseAndAssertSame(`
+ const a = 1n;
+ `);
+ });
+
+ it("Dynamic Import", () => {
+ parseAndAssertSame(`
+ const a = import('a');
+ `);
+ });
+ });
+});
diff --git a/eslint/babel-eslint-plugin-development/.npmignore b/eslint/babel-eslint-plugin-development/.npmignore
new file mode 100644
index 000000000000..c3aafe7a7721
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/.npmignore
@@ -0,0 +1,4 @@
+src
+test
+.*
+*.log
\ No newline at end of file
diff --git a/eslint/babel-eslint-plugin-development/README.md b/eslint/babel-eslint-plugin-development/README.md
new file mode 100644
index 000000000000..12cc354b7470
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/README.md
@@ -0,0 +1,38 @@
+# @babel/eslint-plugin-development
+
+A set of eslint rules to enforce best practices in the development of Babel plugins.
+
+## Installation
+
+You'll first need to install [ESLint](http://eslint.org):
+
+```
+$ npm install --save-dev eslint
+```
+
+Next, install `@babel/eslint-plugin-development`:
+
+```
+$ npm install --save-dev @babel/eslint-plugin-development
+```
+
+Then, load the plugin in your `.eslintrc` configuration file. You can omit the `eslint-plugin-` prefix:
+
+```json
+{
+ "plugins": ["@babel/development"]
+}
+```
+
+## Supported Rules
+
+> Note: Rules marked with :wrench: are autofixable.
+
+* `@babel/development/no-deprecated-clone` (:wrench:): Disallows using the deprecated
+ `t.clone(node)` and `t.cloneDeep(node)` methods from `@babel/types`. Those
+ calls are replaced with `t.cloneNode(node)` when using `eslint --fix`.
+* `@babel/development/no-undefined-identifier`: Disallows using
+ `t.identifier("undefined")` to create a node which represents an `undefined`
+ value, since it might cause problem if `undefined` is redeclared.
+* `@babel/development/plugin-name`: Requires plugins to have a `name` property, which
+ can be useful for debugging purposes.
diff --git a/eslint/babel-eslint-plugin-development/package.json b/eslint/babel-eslint-plugin-development/package.json
new file mode 100644
index 000000000000..d59704a25597
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/package.json
@@ -0,0 +1,36 @@
+{
+ "name": "@babel/eslint-plugin-development",
+ "version": "1.0.1",
+ "description": "ESLint rules that enforce best practices in the development of Babel plugins.",
+ "private": true,
+ "keywords": [
+ "eslint",
+ "eslintplugin",
+ "eslint-plugin"
+ ],
+ "author": {
+ "name": "Nicolò Ribaudo",
+ "email": "nicolo.ribaudo@gmail.com",
+ "url": "https://github.com/nicolo-ribaudo"
+ },
+ "main": "lib/index.js",
+ "devDependencies": {
+ "eslint": "^5.9.0"
+ },
+ "engines": {
+ "node": ">=10.9"
+ },
+ "publishConfig": {
+ "access": "public"
+ },
+ "license": "MIT",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/babel/babel.git",
+ "directory": "eslint/babel-eslint-plugin-development"
+ },
+ "bugs": {
+ "url": "https://github.com/babel/babel/issues"
+ },
+ "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-development"
+}
diff --git a/eslint/babel-eslint-plugin-development/src/index.js b/eslint/babel-eslint-plugin-development/src/index.js
new file mode 100644
index 000000000000..ae6662710684
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/index.js
@@ -0,0 +1,11 @@
+import noDeprecatedClone from "./rules/no-deprecated-clone";
+import noUndefinedIdentifier from "./rules/no-undefined-identifier";
+import pluginName from "./rules/plugin-name";
+
+export default {
+ rules: {
+ "no-deprecated-clone": noDeprecatedClone,
+ "no-undefined-identifier": noUndefinedIdentifier,
+ "plugin-name": pluginName,
+ },
+};
diff --git a/eslint/babel-eslint-plugin-development/src/rules/no-deprecated-clone.js b/eslint/babel-eslint-plugin-development/src/rules/no-deprecated-clone.js
new file mode 100644
index 000000000000..dddc5eb3b729
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/rules/no-deprecated-clone.js
@@ -0,0 +1,39 @@
+import getReferenceOrigin from "../utils/get-reference-origin";
+import isFromBabelTypes from "../utils/is-from-babel-types";
+
+export default {
+ meta: {
+ schema: [],
+ fixable: "code",
+ },
+ create(context) {
+ return {
+ CallExpression(node) {
+ const { callee } = node;
+ const scope = context.getScope();
+
+ const origin = getReferenceOrigin(callee, scope);
+ if (!origin) return;
+
+ const { name } = origin;
+ if (
+ (name === "clone" || name === "cloneDeep") &&
+ isFromBabelTypes(origin, scope)
+ ) {
+ const isMemberExpression = callee.type === "MemberExpression";
+ const id = isMemberExpression ? callee.property : callee;
+
+ context.report({
+ node: id,
+ message: `t.${name}() is deprecated. Use t.cloneNode() instead.`,
+ fix(fixer) {
+ if (isMemberExpression) {
+ return fixer.replaceText(id, "cloneNode");
+ }
+ },
+ });
+ }
+ },
+ };
+ },
+};
diff --git a/eslint/babel-eslint-plugin-development/src/rules/no-undefined-identifier.js b/eslint/babel-eslint-plugin-development/src/rules/no-undefined-identifier.js
new file mode 100644
index 000000000000..33e154be8979
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/rules/no-undefined-identifier.js
@@ -0,0 +1,39 @@
+import getReferenceOrigin from "../utils/get-reference-origin";
+import isFromBabelTypes from "../utils/is-from-babel-types";
+
+function firstArgumentIsUndefinedString(argumentsArray) {
+ return (
+ argumentsArray.length > 0 &&
+ argumentsArray[0].type === "Literal" &&
+ argumentsArray[0].value === "undefined"
+ );
+}
+
+export default {
+ meta: {
+ schema: [],
+ },
+ create(context) {
+ return {
+ CallExpression(node) {
+ const { callee } = node;
+ const scope = context.getScope();
+
+ const origin = getReferenceOrigin(callee, scope);
+ if (!origin) return;
+
+ const { name } = origin;
+ if (
+ (name === "identifier" || name === "Identifier") &&
+ firstArgumentIsUndefinedString(node.arguments) &&
+ isFromBabelTypes(origin, scope)
+ ) {
+ context.report(
+ node,
+ "Use path.scope.buildUndefinedNode() to create an undefined identifier directly.",
+ );
+ }
+ },
+ };
+ },
+};
diff --git a/eslint/babel-eslint-plugin-development/src/rules/plugin-name.js b/eslint/babel-eslint-plugin-development/src/rules/plugin-name.js
new file mode 100644
index 000000000000..df14476cd43b
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/rules/plugin-name.js
@@ -0,0 +1,50 @@
+import isBabelPluginFactory from "../utils/is-babel-plugin-factory";
+
+function getReturnValue(node) {
+ const { body } = node;
+
+ if (body.type === "BlockStatement") {
+ const returnNode = body.body.find(n => n.type === "ReturnStatement");
+ return returnNode && returnNode.argument;
+ }
+
+ // Arrow functions with implicit return
+ return body;
+}
+
+export default {
+ meta: {
+ schema: [],
+ },
+ create(context /*: Context */) {
+ let pluginFound = false;
+
+ return {
+ FunctionDeclaration: functionVisitor,
+ FunctionExpression: functionVisitor,
+ ArrowFunctionExpression: functionVisitor,
+
+ "Program:exit"(node) {
+ if (!pluginFound) {
+ context.report(node, "This file does not export a Babel plugin.");
+ }
+ },
+ };
+
+ function functionVisitor(node) {
+ if (!isBabelPluginFactory(node, context.getScope())) return;
+
+ const returnValue = getReturnValue(node);
+ if (!returnValue || returnValue.type !== "ObjectExpression") return;
+
+ pluginFound = true;
+
+ if (!returnValue.properties.some(p => p.key.name === "name")) {
+ context.report(
+ returnValue,
+ "This Babel plugin doesn't have a 'name' property.",
+ );
+ }
+ }
+ },
+};
diff --git a/eslint/babel-eslint-plugin-development/src/utils/get-export-name.js b/eslint/babel-eslint-plugin-development/src/utils/get-export-name.js
new file mode 100644
index 000000000000..2d75e3e46a4d
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/utils/get-export-name.js
@@ -0,0 +1,22 @@
+export default function getExportName(node) {
+ const { parent } = node;
+
+ if (parent.type === "ExportDefaultDeclaration") {
+ return "default";
+ }
+
+ if (parent.type === "ExportNamedDeclaration") {
+ return node.id.name;
+ }
+
+ if (
+ parent.type === "AssignmentExpression" &&
+ parent.left.type === "MemberExpression" &&
+ parent.left.object.type === "Identifier" &&
+ parent.left.object.name === "module" &&
+ parent.left.property.type === "Identifier" &&
+ parent.left.property.name === "exports"
+ ) {
+ return "module.exports";
+ }
+}
diff --git a/eslint/babel-eslint-plugin-development/src/utils/get-reference-origin.js b/eslint/babel-eslint-plugin-development/src/utils/get-reference-origin.js
new file mode 100644
index 000000000000..25fd7b0a541f
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/utils/get-reference-origin.js
@@ -0,0 +1,141 @@
+/*::
+type ReferenceOriginImport = { kind: "import", source: string, name: string };
+type ReferenceOriginParam = {
+ kind: "param",
+ index: number,
+ functionNode: Node,
+};
+
+type ReferenceOrigin =
+ | ReferenceOriginImport
+ | ReferenceOriginParam
+ | { kind: "import *", source: string }
+ | {
+ kind: "property",
+ base: ReferenceOriginImport | ReferenceOriginParam,
+ path: string,
+ name: string,
+ };
+*/
+
+// Given a node and a context, returns a description of where its value comes
+// from.
+// It resolves imports, parameters of exported functions and property accesses.
+// See the ReferenceOrigin type for more informations.
+export default function getReferenceOrigin(
+ node,
+ scope,
+) /*: ?ReferenceOrigin */ {
+ if (node.type === "Identifier") {
+ const variable = getVariableDefinition(node.name, scope);
+ if (!variable) return null;
+
+ const definition = variable.definition;
+ const defNode = definition.node;
+
+ if (definition.type === "ImportBinding") {
+ if (defNode.type === "ImportSpecifier") {
+ return {
+ kind: "import",
+ source: definition.parent.source.value,
+ name: defNode.imported.name,
+ };
+ }
+ if (defNode.type === "ImportNamespaceSpecifier") {
+ return {
+ kind: "import *",
+ source: definition.parent.source.value,
+ };
+ }
+ }
+
+ if (definition.type === "Variable" && defNode.init) {
+ const origin = getReferenceOrigin(defNode.init, variable.scope);
+ return origin && patternToProperty(definition.name, origin);
+ }
+
+ if (definition.type === "Parameter") {
+ return patternToProperty(definition.name, {
+ kind: "param",
+ index: definition.index,
+ functionNode: definition.node,
+ });
+ }
+ }
+
+ if (node.type === "MemberExpression" && !node.computed) {
+ const origin = getReferenceOrigin(node.object, scope);
+ return origin && addProperty(origin, node.property.name);
+ }
+
+ return null;
+}
+
+function getVariableDefinition(name, scope) {
+ let currentScope = scope;
+ do {
+ const variable = currentScope.set.get(name);
+ if (variable && variable.defs[0]) {
+ return { scope: currentScope, definition: variable.defs[0] };
+ }
+ } while ((currentScope = currentScope.upper));
+}
+
+function patternToProperty(id, base) {
+ const path = getPatternPath(id);
+ return path && path.reduce(addProperty, base);
+}
+
+// Adds a property to a given origin. If it was a namespace import it becomes
+// a named import, so that `import * as x from "foo"; x.bar` and
+// `import { bar } from "foo"` have the same origin.
+function addProperty(origin, name) {
+ if (origin.kind === "import *") {
+ return {
+ kind: "import",
+ source: origin.source,
+ name,
+ };
+ }
+ if (origin.kind === "property") {
+ return {
+ kind: "property",
+ base: origin.base,
+ path: origin.path + "." + name,
+ name,
+ };
+ }
+ return {
+ kind: "property",
+ base: origin,
+ path: name,
+ name,
+ };
+}
+
+// if "node" is c of { a: { b: c } }, the result is ["a","b"]
+function getPatternPath(node) {
+ let current = node;
+ const path = [];
+
+ // Unshift keys to path while going up
+ do {
+ const property = current.parent;
+ if (
+ property.type === "ArrayPattern" ||
+ property.type === "AssignmentPattern" ||
+ property.computed
+ ) {
+ // These nodes are not supported.
+ return null;
+ }
+ if (property.type === "Property") {
+ path.unshift(property.key.name);
+ } else {
+ // The destructuring pattern is finished
+ break;
+ }
+ } while ((current = current.parent.parent));
+
+ return path;
+}
diff --git a/eslint/babel-eslint-plugin-development/src/utils/is-babel-plugin-factory.js b/eslint/babel-eslint-plugin-development/src/utils/is-babel-plugin-factory.js
new file mode 100644
index 000000000000..19d889bffe21
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/utils/is-babel-plugin-factory.js
@@ -0,0 +1,24 @@
+import getReferenceOrigin from "./get-reference-origin";
+import getExportName from "./get-export-name";
+
+export default function isBabelPluginFactory(node, scope) {
+ const { parent } = node;
+
+ if (parent.type === "CallExpression") {
+ const calleeOrigin = getReferenceOrigin(parent.callee, scope);
+
+ // Using "declare" from "@babel/helper-plugin-utils"
+ return !!(
+ calleeOrigin &&
+ calleeOrigin.kind === "import" &&
+ calleeOrigin.name === "declare" &&
+ calleeOrigin.source === "@babel/helper-plugin-utils"
+ );
+ }
+
+ const exportName = getExportName(node);
+
+ // export default function ({ types: t }) {}
+ // module.exports = function ({ types: t }) {}
+ return exportName === "default" || exportName === "module.exports";
+}
diff --git a/eslint/babel-eslint-plugin-development/src/utils/is-from-babel-types.js b/eslint/babel-eslint-plugin-development/src/utils/is-from-babel-types.js
new file mode 100644
index 000000000000..4a7a24bca040
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/src/utils/is-from-babel-types.js
@@ -0,0 +1,33 @@
+import isBabelPluginFactory from "./is-babel-plugin-factory";
+
+// Check if a ReferenceOrigin (returned by ./get-reference-origin.js)
+// is a reference to a @babel/types export.
+export default function isFromBabelTypes(
+ origin /*: ReferenceOrigin */,
+ scope /*: Scope */,
+) {
+ if (origin.kind === "import" && origin.source === "@babel/types") {
+ // imported from @babel/types
+ return true;
+ }
+
+ if (
+ origin.kind === "property" &&
+ origin.base.kind === "import" &&
+ origin.base.name === "types" &&
+ origin.base.source === "@babel/core"
+ ) {
+ // imported from @babel/core
+ return true;
+ }
+
+ if (
+ origin.kind === "property" &&
+ origin.base.kind === "param" &&
+ origin.base.index === 0
+ ) {
+ return isBabelPluginFactory(origin.base.functionNode, scope);
+ }
+
+ return false;
+}
diff --git a/eslint/babel-eslint-plugin-development/test/rules/no-deprecated-clone.js b/eslint/babel-eslint-plugin-development/test/rules/no-deprecated-clone.js
new file mode 100644
index 000000000000..9905bc170f0c
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/test/rules/no-deprecated-clone.js
@@ -0,0 +1,136 @@
+import rule from "../../src/rules/no-deprecated-clone";
+import { RuleTester } from "eslint";
+
+const cloneError = "t.clone() is deprecated. Use t.cloneNode() instead.";
+const cloneDeepError =
+ "t.cloneDeep() is deprecated. Use t.cloneNode() instead.";
+
+const ruleTester = new RuleTester({
+ parserOptions: { sourceType: "module" },
+});
+
+ruleTester.run("no-deprecated-clone", rule, {
+ valid: [
+ `_.clone(obj)`,
+ `_.cloneDeep(obj)`,
+ `import * as t from "lib"; t.clone();`,
+ `import * as t from "lib"; t.cloneDeep();`,
+ `function f(_) { _.types.clone(); }`,
+ `function f(_) { _.types.cloneDeep(); }`,
+ `import * as t from "@babel/types"; t.cloneNode();`,
+ ],
+ invalid: [
+ {
+ code: `import { clone } from "@babel/types"; clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { cloneDeep } from "@babel/types"; cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import { clone } from "@babel/types"; var clone2 = clone; clone2();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { cloneDeep } from "@babel/types"; var cloneDeep2 = cloneDeep; cloneDeep2();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import * as t from "@babel/types"; t.clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import * as t from "@babel/types"; t.cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import * as t from "@babel/types"; var { clone } = t; clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import * as t from "@babel/types"; var { cloneDeep } = t; cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import { clone as c } from "@babel/types"; c();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { cloneDeep as cD } from "@babel/types"; cD();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import * as babel from "@babel/core"; babel.types.clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import * as babel from "@babel/core"; babel.types.cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import { types } from "@babel/core"; types.clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { types } from "@babel/core"; types.cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import { types as t } from "@babel/core"; t.clone();`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { types as t } from "@babel/core"; t.cloneDeep();`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `export default function plugin(babel) { babel.types.clone() }`,
+ errors: [cloneError],
+ },
+ {
+ code: `export default function plugin(babel) { babel.types.cloneDeep() }`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `export default function plugin({ types }) { types.clone() }`,
+ errors: [cloneError],
+ },
+ {
+ code: `export default function plugin({ types }) { types.cloneDeep() }`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `export default function plugin({ types: t }) { t.clone() }`,
+ errors: [cloneError],
+ },
+ {
+ code: `export default function plugin({ types: t }) { t.cloneDeep() }`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `export default ({ types }) => { types.clone() }`,
+ errors: [cloneError],
+ },
+ {
+ code: `export default ({ types }) => { types.cloneDeep() }`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `module.exports = function plugin({ types }) { types.clone() }`,
+ errors: [cloneError],
+ },
+ {
+ code: `module.exports = function plugin({ types }) { types.cloneDeep() }`,
+ errors: [cloneDeepError],
+ },
+ {
+ code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.clone() });`,
+ errors: [cloneError],
+ },
+ {
+ code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.cloneDeep() });`,
+ errors: [cloneDeepError],
+ },
+ ],
+});
diff --git a/eslint/babel-eslint-plugin-development/test/rules/no-undefined-identifier.js b/eslint/babel-eslint-plugin-development/test/rules/no-undefined-identifier.js
new file mode 100644
index 000000000000..d6d8c6b28b6b
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/test/rules/no-undefined-identifier.js
@@ -0,0 +1,78 @@
+import rule from "../../src/rules/no-undefined-identifier";
+import { RuleTester } from "eslint";
+
+const error =
+ "Use path.scope.buildUndefinedNode() to create an undefined identifier directly.";
+
+const ruleTester = new RuleTester({
+ parserOptions: { sourceType: "module" },
+});
+
+ruleTester.run("no-undefined-identifier", rule, {
+ valid: [
+ `_.identifier("undefined")`,
+ `_.Identifier("undefined")`,
+ `import * as t from "lib"; t.identifier("undefined");`,
+ `function f(_) { _.types.identifier("undefined"); }`,
+ `import * as t from "@babel/types"; t.identifier("not_undefined");`,
+ `path.scope.buildUndefinedNode();`,
+ ],
+ invalid: [
+ {
+ code: `import { identifier } from "@babel/types"; identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import { Identifier } from "@babel/types"; Identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import * as t from "@babel/types"; t.identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import * as t from "@babel/types"; var { identifier } = t; identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import { identifier as id } from "@babel/types"; id("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import * as babel from "@babel/core"; babel.types.identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import { types } from "@babel/core"; types.identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `import { types as t } from "@babel/core"; t.identifier("undefined");`,
+ errors: [error],
+ },
+ {
+ code: `export default function plugin(babel) { babel.types.identifier("undefined") }`,
+ errors: [error],
+ },
+ {
+ code: `export default function plugin({ types }) { types.identifier("undefined") }`,
+ errors: [error],
+ },
+ {
+ code: `export default function plugin({ types: t }) { t.identifier("undefined") }`,
+ errors: [error],
+ },
+ {
+ code: `export default ({ types }) => { types.identifier("undefined") }`,
+ errors: [error],
+ },
+ {
+ code: `module.exports = function plugin({ types }) { types.identifier("undefined") }`,
+ errors: [error],
+ },
+ {
+ code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.identifier("undefined") });`,
+ errors: [error],
+ },
+ ],
+});
diff --git a/eslint/babel-eslint-plugin-development/test/rules/plugin-name.js b/eslint/babel-eslint-plugin-development/test/rules/plugin-name.js
new file mode 100644
index 000000000000..d39924efe752
--- /dev/null
+++ b/eslint/babel-eslint-plugin-development/test/rules/plugin-name.js
@@ -0,0 +1,52 @@
+import rule from "../../src/rules/plugin-name";
+import { RuleTester } from "eslint";
+
+const missingPluginError = "This file does not export a Babel plugin.";
+const missingNameError = "This Babel plugin doesn't have a 'name' property.";
+
+const ruleTester = new RuleTester({
+ parserOptions: { sourceType: "module" },
+});
+
+ruleTester.run("plugin-name", rule, {
+ valid: [
+ `export default function () { return { name: "test-plugin" } }`,
+ `import { declare } from "@babel/helper-plugin-utils"; declare(() => { return { name: "test-plugin" } })`,
+ `import { declare } from "@babel/helper-plugin-utils"; declare(() => ({ name: "test-plugin" }))`,
+ `module.exports = function () { return { name: "foo" }; }`,
+ ],
+ invalid: [
+ {
+ code: `function fn() { return { name: "foo" } }`,
+ errors: [missingPluginError],
+ },
+ {
+ code: `export function fn() { return { name: "foo" } }`,
+ errors: [missingPluginError],
+ },
+ {
+ code: `(function fn() { return { name: "foo" } })`,
+ errors: [missingPluginError],
+ },
+ {
+ code: `() => { return { name: "foo" } }`,
+ errors: [missingPluginError],
+ },
+ {
+ code: `export default function fn() {}`,
+ errors: [missingPluginError],
+ },
+ {
+ code: `export default function fn() { return {} }`,
+ errors: [missingNameError],
+ },
+ {
+ code: `import { declare } from "@babel/helper-plugin-utils"; declare(() => ({}))`,
+ errors: [missingNameError],
+ },
+ {
+ code: `module.exports = function () { return {} }`,
+ errors: [missingNameError],
+ },
+ ],
+});
diff --git a/eslint/babel-eslint-plugin/.npmignore b/eslint/babel-eslint-plugin/.npmignore
new file mode 100644
index 000000000000..ad69326ce8c2
--- /dev/null
+++ b/eslint/babel-eslint-plugin/.npmignore
@@ -0,0 +1,4 @@
+src
+test
+.*
+*.log
diff --git a/eslint/babel-eslint-plugin/LICENSE b/eslint/babel-eslint-plugin/LICENSE
new file mode 100644
index 000000000000..3d0e2f3067b8
--- /dev/null
+++ b/eslint/babel-eslint-plugin/LICENSE
@@ -0,0 +1,23 @@
+Copyright (c) 2014-2015 Jason Quense
+Original work by respective rule authors; copywrites noted in files.
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
\ No newline at end of file
diff --git a/eslint/babel-eslint-plugin/README.md b/eslint/babel-eslint-plugin/README.md
new file mode 100644
index 000000000000..cb9eb4e4df43
--- /dev/null
+++ b/eslint/babel-eslint-plugin/README.md
@@ -0,0 +1,49 @@
+# @babel/eslint-plugin
+
+## This project is still experimental and will be released with Babel v8. You can track our progress [here](https://github.com/babel/babel/issues/10752)! Please use [eslint-plugin-babel](https://github.com/babel/eslint-plugin-babel) in the meantime.
+
+Companion rules for `@babel/eslint-parser`. `@babel/eslint-parser` does a great job at adapting `eslint`
+for use with Babel, but it can't change the built-in rules to support experimental features.
+`@babel/eslint-plugin` re-implements problematic rules so they do not give false positives or negatives.
+
+> Requires Node 10.9 or greater
+
+### Install
+
+```sh
+npm install @babel/eslint-plugin --save-dev
+```
+
+Load the plugin in your `.eslintrc.json` file:
+
+```json
+{
+ "plugins": ["@babel/eslint-plugin"]
+}
+```
+
+Finally enable all the rules you would like to use (remember to disable the
+original ones as well!).
+
+```json
+{
+ "rules": {
+ "babel/new-cap": "error",
+ "babel/no-invalid-this": "error",
+ "babel/no-unused-expressions": "error",
+ "babel/object-curly-spacing": "error",
+ "babel/semi": "error",
+ }
+}
+```
+### Rules
+
+Each rule corresponds to a core `eslint` rule and has the same options.
+
+🛠: means it's autofixable with `--fix`.
+
+- `babel/new-cap`: handles decorators (`@Decorator`)
+- `babel/no-invalid-this`: handles class fields and private class methods (`class A { a = this.b; }`)
+- `babel/no-unused-expressions`: handles `do` expressions
+- `babel/object-curly-spacing`: handles `export * as x from "mod";` (🛠)
+- `babel/semi`: Handles class properties (🛠)
diff --git a/eslint/babel-eslint-plugin/package.json b/eslint/babel-eslint-plugin/package.json
new file mode 100644
index 000000000000..f259174f472b
--- /dev/null
+++ b/eslint/babel-eslint-plugin/package.json
@@ -0,0 +1,41 @@
+{
+ "name": "@babel/eslint-plugin",
+ "version": "0.0.0",
+ "description": "Companion rules for @babel/eslint-parser",
+ "main": "lib/index.js",
+ "repository": {
+ "type": "git",
+ "url": "git+https://github.com/babel/babel.git",
+ "directory": "eslint/babel-eslint-plugin"
+ },
+ "keywords": [
+ "babel",
+ "eslint",
+ "eslintplugin",
+ "eslint-plugin",
+ "babel-eslint"
+ ],
+ "author": "Jason Quense @monasticpanic",
+ "license": "MIT",
+ "private": true,
+ "engines": {
+ "node": ">=10.9"
+ },
+ "bugs": {
+ "url": "https://github.com/babel/babel/issues"
+ },
+ "homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin",
+ "peerDependencies": {
+ "@babel/eslint-parser": "0.0.0",
+ "eslint": ">=6.0.0"
+ },
+ "dependencies": {
+ "eslint-rule-composer": "^0.3.0"
+ },
+ "devDependencies": {
+ "@babel/eslint-shared-fixtures": "*",
+ "@babel/eslint-parser": "*",
+ "eslint": "^6.0.0",
+ "lodash.clonedeep": "^4.5.0"
+ }
+}
diff --git a/eslint/babel-eslint-plugin/src/index.js b/eslint/babel-eslint-plugin/src/index.js
new file mode 100644
index 000000000000..96fd40caf70e
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/index.js
@@ -0,0 +1,22 @@
+import newCap from "./rules/new-cap";
+import noInvalidThis from "./rules/no-invalid-this";
+import noUnusedExpressions from "./rules/no-unused-expressions";
+import objectCurlySpacing from "./rules/object-curly-spacing";
+import semi from "./rules/semi";
+
+module.exports = {
+ rules: {
+ "new-cap": newCap,
+ "no-invalid-this": noInvalidThis,
+ "no-unused-expressions": noUnusedExpressions,
+ "object-curly-spacing": objectCurlySpacing,
+ semi,
+ },
+ rulesConfig: {
+ "new-cap": "off",
+ "no-invalid-this": "off",
+ "no-unused-expressions": "off",
+ "object-curly-spacing": "off",
+ semi: "off",
+ },
+};
diff --git a/eslint/babel-eslint-plugin/src/rules/new-cap.js b/eslint/babel-eslint-plugin/src/rules/new-cap.js
new file mode 100644
index 000000000000..1fddf1a43b5a
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/rules/new-cap.js
@@ -0,0 +1,18 @@
+import ruleComposer from "eslint-rule-composer";
+import eslint from "eslint";
+
+const rule = new eslint.Linter().getRules().get("new-cap");
+
+/**
+ * Returns whether a node is under a decorator or not.
+ * @param {ASTNode} node CallExpression node
+ * @returns {Boolean} Returns true if the node is under a decorator.
+ */
+function isDecorator(node) {
+ return node.parent.type === "Decorator";
+}
+
+export default ruleComposer.filterReports(
+ rule,
+ problem => !isDecorator(problem.node),
+);
diff --git a/eslint/babel-eslint-plugin/src/rules/no-invalid-this.js b/eslint/babel-eslint-plugin/src/rules/no-invalid-this.js
new file mode 100644
index 000000000000..4c6434235c2a
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/rules/no-invalid-this.js
@@ -0,0 +1,20 @@
+import ruleComposer from "eslint-rule-composer";
+import eslint from "eslint";
+
+const noInvalidThisRule = new eslint.Linter().getRules().get("no-invalid-this");
+
+export default ruleComposer.filterReports(noInvalidThisRule, problem => {
+ let inClassProperty = false;
+ let node = problem.node;
+
+ while (node) {
+ if (node.type === "ClassProperty" || node.type === "ClassPrivateProperty") {
+ inClassProperty = true;
+ return;
+ }
+
+ node = node.parent;
+ }
+
+ return !inClassProperty;
+});
diff --git a/eslint/babel-eslint-plugin/src/rules/no-unused-expressions.js b/eslint/babel-eslint-plugin/src/rules/no-unused-expressions.js
new file mode 100644
index 000000000000..a313b0743245
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/rules/no-unused-expressions.js
@@ -0,0 +1,64 @@
+import ruleComposer from "eslint-rule-composer";
+import eslint from "eslint";
+
+const rule = new eslint.Linter().getRules().get("no-unused-expressions");
+
+/**
+ * @param {ASTNode} node - any node
+ * @returns {boolean} whether the given node is either an IfStatement or an
+ * ExpressionStatement and is the last node in the body of a BlockStatement
+ */
+function isFinalStatementInBlockStatement(node) {
+ const parent = node.parent;
+ return (
+ /^(?:If|Expression)Statement$/.test(node.type) &&
+ parent.type === "BlockStatement" &&
+ parent.body[parent.body.length - 1] === node
+ );
+}
+
+/**
+ * @param {ASTNode} node - any node
+ * @returns {boolean} whether the given node represents an unbroken chain of
+ * tail ExpressionStatements and IfStatements within a DoExpression
+ * https://github.com/tc39/proposal-do-expressions
+ */
+function isInDoStatement(node) {
+ if (!node) return false;
+
+ if (node.type === "DoExpression") return true;
+
+ // this is an `else if`
+ if (
+ node.type === "IfStatement" &&
+ node.parent &&
+ node.parent.type === "IfStatement"
+ ) {
+ return isInDoStatement(node.parent);
+ }
+
+ if (isFinalStatementInBlockStatement(node)) {
+ return isInDoStatement(node.parent.parent);
+ }
+
+ return false;
+}
+
+/**
+ * @param {ASTNode} node - any node
+ * @returns {boolean} whether the given node is an optional call expression,
+ * https://github.com/tc39/proposal-optional-chaining
+ */
+function isOptionalCallExpression(node) {
+ return (
+ !!node &&
+ node.type === "ExpressionStatement" &&
+ node.expression.type === "OptionalCallExpression"
+ );
+}
+
+export default ruleComposer.filterReports(
+ rule,
+ problem =>
+ !isInDoStatement(problem.node) && !isOptionalCallExpression(problem.node),
+);
diff --git a/eslint/babel-eslint-plugin/src/rules/object-curly-spacing.js b/eslint/babel-eslint-plugin/src/rules/object-curly-spacing.js
new file mode 100644
index 000000000000..210f7a9fe5fa
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/rules/object-curly-spacing.js
@@ -0,0 +1,20 @@
+import ruleComposer from "eslint-rule-composer";
+import eslint from "eslint";
+
+const rule = new eslint.Linter().getRules().get("object-curly-spacing");
+
+export default ruleComposer.filterReports(rule, problem => {
+ const node = problem.node;
+
+ // Allow exportDefaultFrom syntax:
+ // export x from '...';
+ if (
+ node.type === "ExportNamedDeclaration" &&
+ node.specifiers.length === 1 &&
+ node.specifiers[0].type === "ExportDefaultSpecifier"
+ ) {
+ return false;
+ }
+
+ return true;
+});
diff --git a/eslint/babel-eslint-plugin/src/rules/semi.js b/eslint/babel-eslint-plugin/src/rules/semi.js
new file mode 100644
index 000000000000..f8cc783ac64a
--- /dev/null
+++ b/eslint/babel-eslint-plugin/src/rules/semi.js
@@ -0,0 +1,105 @@
+import ruleComposer from "eslint-rule-composer";
+import eslint from "eslint";
+
+const OPT_OUT_PATTERN = /^[-[(/+`]/; // One of [(/+-`
+
+const rule = new eslint.Linter().getRules().get("semi");
+
+function isSemicolon(token) {
+ return token.type === "Punctuator" && token.value === ";";
+}
+
+function isUnnecessarySemicolon(context, lastToken) {
+ if (!isSemicolon(lastToken)) {
+ return false;
+ }
+
+ const nextToken = context.getSourceCode().getTokenAfter(lastToken);
+
+ if (!nextToken) {
+ return true;
+ }
+
+ const lastTokenLine = lastToken.loc.end.line;
+ const nextTokenLine = nextToken.loc.start.line;
+ const isOptOutToken =
+ OPT_OUT_PATTERN.test(nextToken.value) &&
+ nextToken.value !== "++" &&
+ nextToken.value !== "--";
+ const isDivider = nextToken.value === "}" || nextToken.value === ";";
+
+ return (lastTokenLine !== nextTokenLine && !isOptOutToken) || isDivider;
+}
+
+function isOneLinerBlock(context, node) {
+ const nextToken = context.getSourceCode().getTokenAfter(node);
+
+ if (!nextToken || nextToken.value !== "}") {
+ return false;
+ }
+
+ const parent = node.parent;
+
+ return (
+ parent &&
+ parent.type === "BlockStatement" &&
+ parent.loc.start.line === parent.loc.end.line
+ );
+}
+
+function report(context, node, missing) {
+ const lastToken = context.getSourceCode().getLastToken(node);
+
+ let message,
+ fix,
+ loc = lastToken.loc;
+
+ if (!missing) {
+ message = "Missing semicolon.";
+ loc = loc.end;
+ fix = function(fixer) {
+ return fixer.insertTextAfter(lastToken, ";");
+ };
+ } else {
+ message = "Extra semicolon.";
+ loc = loc.start;
+ fix = function(fixer) {
+ return fixer.remove(lastToken);
+ };
+ }
+
+ context.report({
+ node,
+ loc,
+ message,
+ fix,
+ });
+}
+
+export default ruleComposer.joinReports([
+ rule,
+ context => ({
+ ClassProperty(node) {
+ const options = context.options[1];
+ const exceptOneLine = options && options.omitLastInOneLineBlock === true;
+ const sourceCode = context.getSourceCode();
+ const lastToken = sourceCode.getLastToken(node);
+
+ if (context.options[0] === "never") {
+ if (isUnnecessarySemicolon(context, lastToken)) {
+ report(context, node, true);
+ }
+ } else {
+ if (!isSemicolon(lastToken)) {
+ if (!exceptOneLine || !isOneLinerBlock(context, node)) {
+ report(context, node);
+ }
+ } else {
+ if (exceptOneLine && isOneLinerBlock(context, node)) {
+ report(context, node, true);
+ }
+ }
+ }
+ },
+ }),
+]);
diff --git a/eslint/babel-eslint-plugin/test/helpers/RuleTester.js b/eslint/babel-eslint-plugin/test/helpers/RuleTester.js
new file mode 100644
index 000000000000..47166bd51185
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/helpers/RuleTester.js
@@ -0,0 +1,14 @@
+import { RuleTester } from "eslint";
+
+RuleTester.setDefaultConfig({
+ parser: require.resolve("@babel/eslint-parser"),
+ parserOptions: {
+ babelOptions: {
+ configFile: require.resolve(
+ "@babel/eslint-shared-fixtures/config/babel.config.js",
+ ),
+ },
+ },
+});
+
+export default RuleTester;
diff --git a/eslint/babel-eslint-plugin/test/rules/new-cap.js b/eslint/babel-eslint-plugin/test/rules/new-cap.js
new file mode 100644
index 000000000000..d5e44984152e
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/rules/new-cap.js
@@ -0,0 +1,12 @@
+import rule from "../../src/rules/new-cap";
+import RuleTester from "../helpers/RuleTester";
+
+const ruleTester = new RuleTester();
+ruleTester.run("@babel/new-cap", rule, {
+ valid: [
+ {
+ code: "@MyDecorator(123) class MyClass{}",
+ },
+ ],
+ invalid: [],
+});
diff --git a/eslint/babel-eslint-plugin/test/rules/no-invalid-this.js b/eslint/babel-eslint-plugin/test/rules/no-invalid-this.js
new file mode 100644
index 000000000000..7773aed80683
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/rules/no-invalid-this.js
@@ -0,0 +1,116 @@
+import cloneDeep from "lodash.clonedeep";
+import rule from "../../src/rules/no-invalid-this";
+import RuleTester from "../helpers/RuleTester";
+
+/**
+ * A constant value for non strict mode environment.
+ * @returns {void}
+ */
+function NORMAL(pattern) {
+ pattern.parserOptions.sourceType = "script";
+}
+
+/**
+ * A constant value for strict mode environment.
+ * This modifies pattern object to make strict mode.
+ * @param {Object} pattern - A pattern object to modify.
+ * @returns {void}
+ */
+function USE_STRICT(pattern) {
+ pattern.code = '"use strict"; ' + pattern.code;
+}
+
+/**
+ * A constant value for implied strict mode.
+ * This modifies pattern object to impose strict mode.
+ * @param {Object} pattern - A pattern object to modify.
+ * @returns {void}
+ */
+function IMPLIED_STRICT(pattern) {
+ pattern.code = "/* implied strict mode */ " + pattern.code;
+ pattern.parserOptions.ecmaFeatures = pattern.parserOptions.ecmaFeatures || {};
+ pattern.parserOptions.ecmaFeatures.impliedStrict = true;
+}
+
+/**
+ * A constant value for modules environment.
+ * This modifies pattern object to make modules.
+ * @param {Object} pattern - A pattern object to modify.
+ * @returns {void}
+ */
+function MODULES(pattern) {
+ pattern.code = "/* modules */ " + pattern.code;
+}
+
+/**
+ * Extracts patterns each condition for a specified type. The type is `valid` or `invalid`.
+ * @param {Object[]} patterns - Original patterns.
+ * @param {string} type - One of `"valid"` or `"invalid"`.
+ * @returns {Object[]} Test patterns.
+ */
+function extractPatterns(patterns, type) {
+ // Clone and apply the pattern environment.
+ const patternsList = patterns.map(function(pattern) {
+ return pattern[type].map(function(applyCondition) {
+ const thisPattern = cloneDeep(pattern);
+
+ applyCondition(thisPattern);
+
+ if (type === "valid") {
+ thisPattern.errors = [];
+ } else {
+ thisPattern.code += " /* should error */";
+ }
+
+ delete thisPattern.invalid;
+ delete thisPattern.valid;
+
+ return thisPattern;
+ });
+ });
+
+ // Flatten.
+ return Array.prototype.concat.apply([], patternsList);
+}
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const patterns = [
+ // Class private fields
+ {
+ code: "class A {a = this.b;};",
+ parserOptions: { ecmaVersion: 6 },
+ valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+ invalid: [],
+ },
+
+ {
+ code: "class A {a = () => {return this.b;};};",
+ parserOptions: { ecmaVersion: 6 },
+ valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+ invalid: [],
+ },
+
+ // Class Private methods
+ {
+ code: "class A {#a = this.b;};",
+ parserOptions: { ecmaVersion: 6 },
+ valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+ invalid: [],
+ },
+
+ {
+ code: "class A {#a = () => {return this.b;};};",
+ parserOptions: { ecmaVersion: 6 },
+ valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
+ invalid: [],
+ },
+];
+
+const ruleTester = new RuleTester();
+ruleTester.run("@babel/no-invalid-this", rule, {
+ valid: extractPatterns(patterns, "valid"),
+ invalid: extractPatterns(patterns, "invalid"),
+});
diff --git a/eslint/babel-eslint-plugin/test/rules/no-unused-expressions.js b/eslint/babel-eslint-plugin/test/rules/no-unused-expressions.js
new file mode 100644
index 000000000000..991bf6fa80b4
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/rules/no-unused-expressions.js
@@ -0,0 +1,37 @@
+import rule from "../../src/rules/no-unused-expressions";
+import RuleTester from "../helpers/RuleTester";
+
+const ruleTester = new RuleTester();
+ruleTester.run("@babel/no-unused-expressions", rule, {
+ valid: [
+ "let a = do { if (foo) { foo.bar; } }",
+ "let a = do { foo; }",
+ "let a = do { let b = 2; foo; }",
+ "let a = do { (foo + 1); }",
+ "let a = do { if (foo) { if (foo.bar) { foo.bar; } } }",
+ "let a = do { if (foo) { if (foo.bar) { foo.bar; } else if (foo.baz) { foo.baz; } } }",
+ "foo.bar?.();",
+ ],
+ invalid: [
+ {
+ code: "let a = do { foo; let b = 2; }",
+ errors: [
+ {
+ message:
+ "Expected an assignment or function call and instead saw an expression.",
+ type: "ExpressionStatement",
+ },
+ ],
+ },
+ {
+ code: "let a = do { if (foo) { foo.bar } else { a; bar.foo } }",
+ errors: [
+ {
+ message:
+ "Expected an assignment or function call and instead saw an expression.",
+ type: "ExpressionStatement",
+ },
+ ],
+ },
+ ],
+});
diff --git a/eslint/babel-eslint-plugin/test/rules/object-curly-spacing.js b/eslint/babel-eslint-plugin/test/rules/object-curly-spacing.js
new file mode 100644
index 000000000000..8a08a09516c7
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/rules/object-curly-spacing.js
@@ -0,0 +1,13 @@
+import rule from "../../src/rules/object-curly-spacing";
+import RuleTester from "../helpers/RuleTester";
+
+const ruleTester = new RuleTester();
+ruleTester.run("@babel/object-curly-spacing", rule, {
+ valid: [
+ {
+ code: 'export x from "mod";',
+ },
+ ],
+
+ invalid: [],
+});
diff --git a/eslint/babel-eslint-plugin/test/rules/semi.js b/eslint/babel-eslint-plugin/test/rules/semi.js
new file mode 100644
index 000000000000..d7a757b62616
--- /dev/null
+++ b/eslint/babel-eslint-plugin/test/rules/semi.js
@@ -0,0 +1,52 @@
+import rule from "../../src/rules/semi";
+import RuleTester from "../helpers/RuleTester";
+
+const ruleTester = new RuleTester();
+
+ruleTester.run("semi", rule, {
+ valid: [
+ "class Foo { bar = 'example'; }",
+ "class Foo { static bar = 'example'; }",
+ {
+ code: "class Foo { bar = () => {}; }",
+ options: ["always", { omitLastInOneLineBlock: true }],
+ },
+
+ // never
+ { code: "class Foo { bar = 'example' }", options: ["never"] },
+ { code: "class Foo { static bar = 'example' }", options: ["never"] },
+ { code: "class Foo { bar = () => {} }", options: ["never"] },
+ ],
+ invalid: [
+ {
+ code: "class Foo { bar = 'example' }",
+ errors: [{ message: "Missing semicolon." }],
+ },
+ {
+ code: "class Foo { static bar = 'example' }",
+ errors: [{ message: "Missing semicolon." }],
+ },
+ {
+ code: "class Foo { bar = () => {} }",
+ options: ["always", { omitLastInOneLineBlock: true }],
+ errors: [{ message: "Missing semicolon." }],
+ },
+
+ // "never"
+ {
+ code: "class Foo { bar = 'example'; }",
+ options: ["never"],
+ errors: [{ message: "Extra semicolon." }],
+ },
+ {
+ code: "class Foo { static bar = 'example'; }",
+ options: ["never"],
+ errors: [{ message: "Extra semicolon." }],
+ },
+ {
+ code: "class Foo { bar = () => {}; }",
+ options: ["never"],
+ errors: [{ message: "Extra semicolon." }],
+ },
+ ],
+});
diff --git a/eslint/babel-eslint-shared-fixtures/config/babel.config.decorators-legacy.js b/eslint/babel-eslint-shared-fixtures/config/babel.config.decorators-legacy.js
new file mode 100644
index 000000000000..dbad846412e6
--- /dev/null
+++ b/eslint/babel-eslint-shared-fixtures/config/babel.config.decorators-legacy.js
@@ -0,0 +1,6 @@
+"use strict";
+
+module.exports = {
+ presets: [["@babel/preset-env", { forceAllTransforms: true }]],
+ plugins: [["@babel/plugin-proposal-decorators", { legacy: true }]],
+};
diff --git a/eslint/babel-eslint-shared-fixtures/config/babel.config.js b/eslint/babel-eslint-shared-fixtures/config/babel.config.js
new file mode 100644
index 000000000000..202b888fe7b1
--- /dev/null
+++ b/eslint/babel-eslint-shared-fixtures/config/babel.config.js
@@ -0,0 +1,24 @@
+"use strict";
+
+module.exports = {
+ presets: [
+ ["@babel/preset-env", { forceAllTransforms: true }],
+ ["@babel/preset-flow", { all: true }],
+ "@babel/preset-react",
+ ],
+ plugins: [
+ "@babel/plugin-syntax-dynamic-import",
+ "@babel/plugin-syntax-import-meta",
+ "@babel/plugin-syntax-export-default-from",
+ "@babel/plugin-proposal-class-properties",
+ "@babel/plugin-proposal-nullish-coalescing-operator",
+ "@babel/plugin-proposal-optional-chaining",
+ "@babel/plugin-syntax-numeric-separator",
+ "@babel/plugin-syntax-export-namespace-from",
+ ["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: false }],
+ ["@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" }],
+ "@babel/plugin-syntax-bigint",
+ "@babel/plugin-proposal-private-methods",
+ "@babel/plugin-proposal-do-expressions",
+ ],
+};
diff --git a/eslint/babel-eslint-shared-fixtures/package.json b/eslint/babel-eslint-shared-fixtures/package.json
new file mode 100644
index 000000000000..96bbb96dde67
--- /dev/null
+++ b/eslint/babel-eslint-shared-fixtures/package.json
@@ -0,0 +1,25 @@
+{
+ "name": "@babel/eslint-shared-fixtures",
+ "version": "0.0.0",
+ "description": "Shared fixtures for testing @babel/eslint-* packages",
+ "license": "MIT",
+ "private": true,
+ "dependencies": {
+ "@babel/plugin-proposal-class-properties": "^7.1.0",
+ "@babel/plugin-proposal-decorators": "^7.1.2",
+ "@babel/plugin-proposal-do-expressions": "^7.7.4",
+ "@babel/plugin-proposal-nullish-coalescing-operator": "^7.0.0",
+ "@babel/plugin-proposal-optional-chaining": "^7.0.0",
+ "@babel/plugin-proposal-pipeline-operator": "^7.0.0",
+ "@babel/plugin-proposal-private-methods": "^7.7.4",
+ "@babel/plugin-syntax-bigint": "^7.7.4",
+ "@babel/plugin-syntax-dynamic-import": "^7.0.0",
+ "@babel/plugin-syntax-export-default-from": "^7.0.0",
+ "@babel/plugin-syntax-export-namespace-from": "^7.0.0",
+ "@babel/plugin-syntax-import-meta": "^7.0.0",
+ "@babel/plugin-syntax-numeric-separator": "^7.0.0",
+ "@babel/preset-env": "^7.1.5",
+ "@babel/preset-flow": "^7.0.0",
+ "@babel/preset-react": "^7.0.0"
+ }
+}
diff --git a/eslint/babel-eslint-tests/package.json b/eslint/babel-eslint-tests/package.json
new file mode 100644
index 000000000000..edcabd8bbe04
--- /dev/null
+++ b/eslint/babel-eslint-tests/package.json
@@ -0,0 +1,15 @@
+{
+ "name": "@babel/eslint-tests",
+ "version": "0.0.0",
+ "description": "Tests for babel/eslint-* packages",
+ "license": "MIT",
+ "private": true,
+ "devDependencies": {
+ "@babel/eslint-parser": "*",
+ "@babel/eslint-plugin": "*",
+ "@babel/eslint-shared-fixtures": "*",
+ "dedent": "^0.7.0",
+ "eslint": "^6.0.0",
+ "eslint-plugin-import": "^2.20.1"
+ }
+}
diff --git a/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/.eslintrc.yml b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/.eslintrc.yml
new file mode 100644
index 000000000000..861dfa917f87
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/.eslintrc.yml
@@ -0,0 +1,7 @@
+root: true
+parser: "@babel/eslint-parser"
+plugins:
+ - import
+rules:
+ import/no-named-as-default: error
+ no-unused-vars: error
diff --git a/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/a.js b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/a.js
new file mode 100644
index 000000000000..e8d96fc4d62d
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/a.js
@@ -0,0 +1 @@
+export default function foo() { }
diff --git a/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/b.js b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/b.js
new file mode 100644
index 000000000000..b3a52f870198
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/b.js
@@ -0,0 +1 @@
+import foo from './a.js';
diff --git a/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/c.js b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/c.js
new file mode 100644
index 000000000000..2beac98f3b74
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/eslint-plugin-import/c.js
@@ -0,0 +1,4 @@
+// @flow
+type Foo = {};
+
+const FlowTypeButton = ({ }: Foo) => { };
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-with.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-with.js
new file mode 100644
index 000000000000..3df7515269d5
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-with.js
@@ -0,0 +1,3 @@
+function x () {
+ "use strict";
+}
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-without.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-without.js
new file mode 100644
index 000000000000..20b3e9e55005
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/function-without.js
@@ -0,0 +1 @@
+function x () {}
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-with.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-with.js
new file mode 100644
index 000000000000..ef682f72c947
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-with.js
@@ -0,0 +1,5 @@
+"use strict";
+
+function x () {
+ "use strict";
+}
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-without.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-without.js
new file mode 100644
index 000000000000..206f708141b7
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with-function-without.js
@@ -0,0 +1,3 @@
+"use strict";
+
+function x () {}
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with.js
new file mode 100644
index 000000000000..e967aa4994d0
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/global-with.js
@@ -0,0 +1,6 @@
+"use strict";
+/*
+The empty statement is intentional. As of now, ESLint won't enforce
+string: [2, "global"] on a program with an empty body. A test for that without
+massaging the AST to ESlint's input format should fail.
+*/
diff --git a/eslint/babel-eslint-tests/test/fixtures/rules/strict/none.js b/eslint/babel-eslint-tests/test/fixtures/rules/strict/none.js
new file mode 100644
index 000000000000..4a6db98f6226
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/fixtures/rules/strict/none.js
@@ -0,0 +1 @@
+"no use strict anywhere";
diff --git a/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js b/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js
new file mode 100644
index 000000000000..3d94edfd7906
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js
@@ -0,0 +1,69 @@
+import eslint from "eslint";
+import unpad from "dedent";
+import * as parser from "@babel/eslint-parser";
+
+export default function verifyAndAssertMessages(
+ code,
+ rules = {},
+ expectedMessages = [],
+ sourceType,
+ overrideConfig,
+) {
+ const linter = new eslint.Linter();
+ linter.defineParser("@babel/eslint-parser", parser);
+
+ const messages = linter.verify(unpad(`${code}`), {
+ parser: "@babel/eslint-parser",
+ rules,
+ env: {
+ node: true,
+ es6: true,
+ },
+ ...overrideConfig,
+ parserOptions: {
+ sourceType,
+ requireConfigFile: false,
+ babelOptions: {
+ configFile: require.resolve(
+ "@babel/eslint-shared-fixtures/config/babel.config.js",
+ ),
+ },
+ ...overrideConfig?.parserOptions,
+ },
+ });
+
+ if (messages.length !== expectedMessages.length) {
+ throw new Error(
+ `Expected ${expectedMessages.length} message(s), got ${
+ messages.length
+ }\n${JSON.stringify(messages, null, 2)}`,
+ );
+ }
+
+ messages.forEach((message, i) => {
+ const formattedMessage = `${message.line}:${message.column} ${
+ message.message
+ }${message.ruleId ? ` ${message.ruleId}` : ""}`;
+ const expectedMessage = expectedMessages[i];
+
+ if (expectedMessage instanceof RegExp) {
+ if (!expectedMessage.test(formattedMessage)) {
+ throw new Error(
+ `
+ Message ${i} does not pass RegExp test:
+ Test: ${expectedMessage}
+ Actual: ${formattedMessage}
+ `,
+ );
+ }
+ } else if (formattedMessage !== expectedMessage) {
+ throw new Error(
+ `
+ Message ${i} does not match:
+ Expected: ${expectedMessage}
+ Actual: ${formattedMessage}
+ `,
+ );
+ }
+ });
+}
diff --git a/eslint/babel-eslint-tests/test/integration/eslint-plugin-import.js b/eslint/babel-eslint-tests/test/integration/eslint-plugin-import.js
new file mode 100644
index 000000000000..28aa3d6ac379
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/integration/eslint-plugin-import.js
@@ -0,0 +1,13 @@
+import eslint from "eslint";
+import path from "path";
+
+describe("https://github.com/babel/babel-eslint/issues/558", () => {
+ it("doesn't crash with eslint-plugin-import", () => {
+ const engine = new eslint.CLIEngine({ ignore: false });
+ engine.executeOnFiles(
+ ["a.js", "b.js", "c.js"].map(file =>
+ path.resolve(__dirname, `../fixtures/eslint-plugin-import/${file}`),
+ ),
+ );
+ });
+});
diff --git a/eslint/babel-eslint-tests/test/integration/eslint/eslint.js b/eslint/babel-eslint-tests/test/integration/eslint/eslint.js
new file mode 100644
index 000000000000..1a62e20f56a9
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/integration/eslint/eslint.js
@@ -0,0 +1,1881 @@
+import verifyAndAssertMessages from "../../helpers/verifyAndAssertMessages";
+
+describe("verify", () => {
+ it("arrow function support (issue #1)", () => {
+ verifyAndAssertMessages("describe('stuff', () => {});");
+ });
+
+ it("EOL validation (issue #2)", () => {
+ verifyAndAssertMessages(
+ 'module.exports = "something";',
+ { "eol-last": 1, semi: 1 },
+ ["1:30 Newline required at end of file but not found. eol-last"],
+ );
+ });
+
+ it("Readable error messages (issue #3)", () => {
+ verifyAndAssertMessages("{ , res }", {}, [
+ /1:2 Parsing error:.*Unexpected token \(1:2\)/,
+ ]);
+ });
+
+ it("Modules support (issue #5)", () => {
+ verifyAndAssertMessages(
+ `
+ import Foo from 'foo';
+ export default Foo;
+ export const c = 'c';
+ export class Store {}
+ `,
+ );
+ });
+
+ it("Rest parameters (issue #7)", () => {
+ verifyAndAssertMessages("function foo(...args) { return args; }", {
+ "no-undef": 1,
+ });
+ });
+
+ it("Exported classes should be used (issue #8)", () => {
+ verifyAndAssertMessages("class Foo {} module.exports = Foo;", {
+ "no-unused-vars": 1,
+ });
+ });
+
+ it("super keyword in class (issue #10)", () => {
+ verifyAndAssertMessages("class Foo { constructor() { super() } }", {
+ "no-undef": 1,
+ });
+ });
+
+ it("Rest parameter in destructuring assignment (issue #11)", () => {
+ verifyAndAssertMessages(
+ "const [a, ...rest] = ['1', '2', '3']; module.exports = rest;",
+ { "no-undef": 1 },
+ );
+ });
+
+ it("JSX attribute names marked as variables (issue #12)", () => {
+ verifyAndAssertMessages('module.exports = ', {
+ "no-undef": 1,
+ });
+ });
+
+ it("Multiple destructured assignment with compound properties (issue #16)", () => {
+ verifyAndAssertMessages("module.exports = { ...a.a, ...a.b };", {
+ "no-dupe-keys": 1,
+ });
+ });
+
+ it("Arrow function with non-block bodies (issue #20)", () => {
+ verifyAndAssertMessages(
+ '"use strict"; () => 1',
+ { strict: [1, "global"] },
+ [],
+ "script",
+ { sourceType: "script" },
+ );
+ });
+
+ it("#242", () => {
+ verifyAndAssertMessages('"use strict"; asdf;', {
+ "no-irregular-whitespace": 1,
+ });
+ });
+
+ it("await keyword (issue #22)", () => {
+ verifyAndAssertMessages("async function foo() { await bar(); }", {
+ "no-unused-expressions": 1,
+ });
+ });
+
+ it("arrow functions (issue #27)", () => {
+ verifyAndAssertMessages("[1, 2, 3].map(i => i * 2);", {
+ "func-names": 1,
+ "space-before-blocks": 1,
+ });
+ });
+
+ it("comment with padded-blocks (issue #33)", () => {
+ verifyAndAssertMessages(
+ `
+ if (a) {
+ // i'm a comment!
+ let b = c
+ }
+ `,
+ { "padded-blocks": [1, "never"] },
+ );
+ });
+
+ describe("flow", () => {
+ it("check regular function", () => {
+ verifyAndAssertMessages(
+ "function a(b, c) { b += 1; c += 1; return b + c; } a;",
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("type alias", () => {
+ verifyAndAssertMessages("type SomeNewType = any;", { "no-undef": 1 });
+ });
+
+ it("type cast expression #102", () => {
+ verifyAndAssertMessages("for (let a of (a: Array)) {}");
+ });
+
+ it("multiple nullable type annotations and return #108", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ function log(foo: ?Foo, foo2: ?Foo2): ?Foo3 {
+ console.log(foo, foo2);
+ }
+ log(1, 2);
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("interface declaration", () => {
+ verifyAndAssertMessages(
+ `
+ interface Foo {};
+ interface Bar {
+ foo: Foo,
+ };
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ ["2:11 'Bar' is defined but never used. no-unused-vars"],
+ );
+ });
+
+ it("type parameter bounds (classes)", () => {
+ verifyAndAssertMessages(
+ `
+ import type {Foo, Foo2} from 'foo';
+ import Base from 'base';
+ class Log extends Base {
+ messages: {[T1]: T2};
+ }
+ new Log();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ ["3:34 'T4' is defined but never used. no-unused-vars"],
+ );
+ });
+
+ it("type parameter scope (classes)", () => {
+ verifyAndAssertMessages(
+ `
+ T;
+ class Foo {}
+ T;
+ new Foo();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "1:1 'T' is not defined. no-undef",
+ "2:11 'T' is defined but never used. no-unused-vars",
+ "3:1 'T' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("type parameter bounds (interfaces)", () => {
+ verifyAndAssertMessages(
+ `
+ import type {Foo, Foo2, Bar} from '';
+ interface Log extends Bar {
+ messages: {[T1]: T2};
+ }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "2:11 'Log' is defined but never used. no-unused-vars",
+ "2:38 'T4' is defined but never used. no-unused-vars",
+ ],
+ );
+ });
+
+ it("type parameter scope (interfaces)", () => {
+ verifyAndAssertMessages(
+ `
+ T;
+ interface Foo {};
+ T;
+ Foo;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "1:1 'T' is not defined. no-undef",
+ "2:15 'T' is defined but never used. no-unused-vars",
+ "3:1 'T' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("type parameter bounds (type aliases)", () => {
+ verifyAndAssertMessages(
+ `
+ import type {Foo, Foo2, Foo3} from 'foo';
+ type Log = {
+ messages: {[T1]: T2};
+ delay: Foo3;
+ };
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "2:6 'Log' is defined but never used. no-unused-vars",
+ "2:29 'T3' is defined but never used. no-unused-vars",
+ ],
+ );
+ });
+
+ it("type parameter scope (type aliases)", () => {
+ verifyAndAssertMessages(
+ `
+ T;
+ type Foo = {};
+ T;
+ Foo;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "1:1 'T' is not defined. no-undef",
+ "2:10 'T' is defined but never used. no-unused-vars",
+ "3:1 'T' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("type parameter bounds (functions)", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ function log(a: T1, b: T2): T3 { return a + b; }
+ log(1, 2);
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ ["3:37 'T4' is defined but never used. no-unused-vars"],
+ );
+ });
+
+ it("type parameter scope (functions)", () => {
+ verifyAndAssertMessages(
+ `
+ T;
+ function log() {}
+ T;
+ log;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "1:1 'T' is not defined. no-undef",
+ "2:14 'T' is defined but never used. no-unused-vars",
+ "3:1 'T' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("nested type annotations", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ function foo(callback: () => Foo) {
+ return callback();
+ }
+ foo();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("type in var declaration", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var x: Foo = 1;
+ x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("object type annotation", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: {numVal: Foo};
+ a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("object property types", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var a = {
+ circle: (null : ?{ setNativeProps(props: Foo): Foo2 })
+ };
+ a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("namespaced types", () => {
+ verifyAndAssertMessages(
+ `
+ var React = require('react-native');
+ var b = {
+ openExternalExample: (null: ?React.Component)
+ };
+ var c = {
+ render(): React.Component {}
+ };
+ b;
+ c;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("ArrayTypeAnnotation", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var x: Foo[]; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("ClassImplements", () => {
+ verifyAndAssertMessages(
+ `
+ import type Bar from 'foo';
+ export default class Foo implements Bar {}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("type alias creates declaration + usage", () => {
+ verifyAndAssertMessages(
+ `
+ type Foo = any;
+ var x : Foo = 1; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("type alias with type parameters", () => {
+ verifyAndAssertMessages(
+ `
+ import type Bar from 'foo';
+ import type Foo3 from 'foo';
+ type Foo = Bar
+ var x : Foo = 1; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("export type alias", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo2 from 'foo';
+ export type Foo = Foo2;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("polymorphic types #109", () => {
+ verifyAndAssertMessages(
+ "export default function groupByEveryN(array: Array, n: number): Array> { n; }",
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("types definition from import", () => {
+ verifyAndAssertMessages(
+ `
+ import type Promise from 'bluebird';
+ type Operation = () => Promise;
+ x: Operation;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("polymorphic/generic types for class #123", () => {
+ verifyAndAssertMessages(
+ `
+ class Box {
+ value: T;
+ }
+ var box = new Box();
+ console.log(box.value);
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("polymorphic/generic types for function #123", () => {
+ verifyAndAssertMessages(
+ `
+ export function identity(value) {
+ var a: T = value; a;
+ }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("polymorphic/generic types for type alias #123", () => {
+ verifyAndAssertMessages(
+ `
+ import Bar from './Bar';
+ type Foo = Bar; var x: Foo = 1; console.log(x);
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("polymorphic/generic types - outside of fn scope #123", () => {
+ verifyAndAssertMessages(
+ `
+ export function foo(value) { value; };
+ var b: T = 1; b;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ [
+ "1:21 'T' is defined but never used. no-unused-vars",
+ "2:8 'T' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("polymorphic/generic types - extending unknown #123", () => {
+ verifyAndAssertMessages(
+ `
+ import Bar from 'bar';
+ export class Foo extends Bar {}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ ["2:30 'T' is not defined. no-undef"],
+ );
+ });
+
+ it("polymorphic/generic types - function calls", () => {
+ verifyAndAssertMessages(
+ `
+ function f(): T {}
+ f();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ ["2:3 'T' is not defined. no-undef"],
+ );
+ });
+
+ it("polymorphic/generic types - function calls #644", () => {
+ verifyAndAssertMessages(
+ `
+ import type {Type} from 'Type';
+ function f(): T {}
+ f();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("support declarations #132", () => {
+ verifyAndAssertMessages(
+ `
+ declare class A { static () : number }
+ declare module B { declare var x: number; }
+ declare function foo(): void;
+ declare var bar
+ A; B; foo(); bar;
+ `,
+ { "no-undef": 1, "no-unused-vars": 1 },
+ );
+ });
+
+ it("supports type spreading", () => {
+ verifyAndAssertMessages(
+ `
+ type U = {};
+ type T = {a: number, ...U, ...V};
+ `,
+ { "no-undef": 1, "no-unused-vars": 1 },
+ [
+ "2:6 'T' is defined but never used. no-unused-vars",
+ "2:31 'V' is not defined. no-undef",
+ ],
+ );
+ });
+
+ it("1", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default function(a: Foo, b: ?Foo2, c){ a; b; c; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("2", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ export default function(a: () => Foo){ a; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("3", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default function(a: (_:Foo) => Foo2){ a; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("4", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ export default function(a: (_1:Foo, _2:Foo2) => Foo3){ a; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("5", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default function(a: (_1:Foo, ...foo:Array) => number){ a; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("6", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ export default function(): Foo {}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("7", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ export default function():() => Foo {}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("8", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default function():(_?:Foo) => Foo2{}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("9", () => {
+ verifyAndAssertMessages(
+ "export default function (a: T1, b: T2) { b; }",
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("10", () => {
+ verifyAndAssertMessages(
+ "var a=function(a: T1, b: T2) {return a + b;}; a;",
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("11", () => {
+ verifyAndAssertMessages("var a={*id(x: T): T { x; }}; a;", {
+ "no-unused-vars": 1,
+ "no-undef": 1,
+ });
+ });
+
+ it("12", () => {
+ verifyAndAssertMessages("var a={async id(x: T): T { x; }}; a;", {
+ "no-unused-vars": 1,
+ "no-undef": 1,
+ });
+ });
+
+ it("13", () => {
+ verifyAndAssertMessages("var a={123(x: T): T { x; }}; a;", {
+ "no-unused-vars": 1,
+ "no-undef": 1,
+ });
+ });
+
+ it("14", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default class Bar {set fooProp(value:Foo):Foo2{ value; }}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("15", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo2 from 'foo';
+ export default class Foo {get fooProp(): Foo2{}}
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("16", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var numVal:Foo; numVal;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("17", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: {numVal: Foo;}; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("18", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ var a: ?{numVal: Foo; [indexer: Foo2]: Foo3}; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("19", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var a: {numVal: Foo; subObj?: ?{strVal: Foo2}}; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("20", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ import type Foo4 from 'foo';
+ var a: { [a: Foo]: Foo2; [b: Foo3]: Foo4; }; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("21", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ var a: {add(x:Foo, ...y:Array): Foo3}; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("22", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ var a: { id(x: Foo2): Foo3; }; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("23", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a:Array = [1, 2, 3]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("24", () => {
+ verifyAndAssertMessages(
+ `
+ import type Baz from 'baz';
+ export default class Bar extends Baz { };
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("25", () => {
+ verifyAndAssertMessages(
+ "export default class Bar { bar(): T { return 42; }}",
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("26", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ export default class Bar { static prop1:Foo; prop2:Foo2; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("27", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var x : Foo | Foo2 = 4; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("28", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var x : () => Foo | () => Foo2; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("29", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var x: typeof Foo | number = Foo2; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("30", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var {x}: {x: Foo; } = { x: 'hello' }; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("31", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var [x]: Array = [ 'hello' ]; x;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("32", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ export default function({x}: { x: Foo; }) { x; }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("33", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ function foo([x]: Array) { x; } foo();
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("34", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var a: Map >; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("35", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: ?Promise[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("36", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ var a:(...rest:Array) => Foo2; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("37", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ import type Foo4 from 'foo';
+ var a: (x: Foo2, ...y:Foo3[]) => Foo4; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("38", () => {
+ verifyAndAssertMessages(
+ `
+ import type {foo, bar} from 'baz';
+ foo; bar;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("39", () => {
+ verifyAndAssertMessages(
+ `
+ import type {foo as bar} from 'baz';
+ bar;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("40", () => {
+ verifyAndAssertMessages(
+ `
+ import type from 'foo';
+ type;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("41", () => {
+ verifyAndAssertMessages(
+ `
+ import type, {foo} from 'bar';
+ type; foo;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("43", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: Foo[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("44", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: ?Foo[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("45", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: (?Foo)[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("46", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: () => Foo[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("47", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: (() => Foo)[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("48", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ var a: typeof Foo[]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("49", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'foo';
+ import type Foo2 from 'foo';
+ import type Foo3 from 'foo';
+ var a : [Foo, Foo2,] = [123, 'duck',]; a;
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+ });
+
+ it("class usage", () => {
+ verifyAndAssertMessages("class Lol {} module.exports = Lol;", {
+ "no-unused-vars": 1,
+ });
+ });
+
+ it("class definition: gaearon/redux#24", () => {
+ verifyAndAssertMessages(
+ `
+ export default function root(stores) {
+ return DecoratedComponent => class ReduxRootDecorator {
+ a() { DecoratedComponent; stores; }
+ };
+ }
+ `,
+ { "no-undef": 1, "no-unused-vars": 1 },
+ );
+ });
+
+ it("class properties #71", () => {
+ verifyAndAssertMessages("class Lol { foo = 'bar'; }", { "no-undef": 1 });
+ });
+
+ it("template strings #31", () => {
+ verifyAndAssertMessages("console.log(`${a}, b`);", { "comma-spacing": 1 });
+ });
+
+ it("template with destructuring #31", () => {
+ verifyAndAssertMessages(
+ `
+ module.exports = {
+ render() {
+ var {name} = this.props;
+ return Math.max(null, \`Name: \${name}, Name: \${name}\`);
+ }
+ };
+ `,
+ { "comma-spacing": 1 },
+ );
+ });
+
+ it("template with arrow returning template #603", () => {
+ verifyAndAssertMessages(
+ `
+ var a = \`\${() => {
+ \`\${''}\`
+ }}\`;
+ `,
+ { indent: 1 },
+ [],
+ );
+ });
+
+ describe("decorators #72 (legacy)", () => {
+ function verifyDecoratorsLegacyAndAssertMessages(
+ code,
+ rules,
+ expectedMessages,
+ sourceType,
+ ) {
+ const overrideConfig = {
+ parserOptions: {
+ sourceType,
+ babelOptions: {
+ configFile: require.resolve(
+ "@babel/eslint-shared-fixtures/config/babel.config.decorators-legacy.js",
+ ),
+ },
+ },
+ };
+ return verifyAndAssertMessages(
+ code,
+ rules,
+ expectedMessages,
+ sourceType,
+ overrideConfig,
+ );
+ }
+
+ it("class declaration", () => {
+ verifyDecoratorsLegacyAndAssertMessages(
+ `
+ import classDeclaration from 'decorator';
+ import decoratorParameter from 'decorator';
+ @classDeclaration((parameter) => parameter)
+ @classDeclaration(decoratorParameter)
+ @classDeclaration
+ export class TextareaAutosize {}
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("method definition", () => {
+ verifyDecoratorsLegacyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ export class TextareaAutosize {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ methodDeclaration(e) {
+ e();
+ }
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("method definition get/set", () => {
+ verifyDecoratorsLegacyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ export class TextareaAutosize {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ get bar() { }
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ set bar(val) { val; }
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("object property", () => {
+ verifyDecoratorsLegacyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ var obj = {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ methodDeclaration(e) {
+ e();
+ }
+ };
+ obj;
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("object property get/set", () => {
+ verifyDecoratorsLegacyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ var obj = {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ get bar() { },
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ set bar(val) { val; }
+ };
+ obj;
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+ });
+
+ describe("decorators #72", () => {
+ it("class declaration", () => {
+ verifyAndAssertMessages(
+ `
+ import classDeclaration from 'decorator';
+ import decoratorParameter from 'decorator';
+ export
+ @classDeclaration((parameter) => parameter)
+ @classDeclaration(decoratorParameter)
+ @classDeclaration
+ class TextareaAutosize {}
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("method definition", () => {
+ verifyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ export class TextareaAutosize {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ methodDeclaration(e) {
+ e();
+ }
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("method definition get/set", () => {
+ verifyAndAssertMessages(
+ `
+ import classMethodDeclarationA from 'decorator';
+ import decoratorParameter from 'decorator';
+ export class TextareaAutosize {
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ get bar() { }
+ @classMethodDeclarationA((parameter) => parameter)
+ @classMethodDeclarationA(decoratorParameter)
+ @classMethodDeclarationA
+ set bar(val) { val; }
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+ });
+
+ it("detects minimal no-unused-vars case #120", () => {
+ verifyAndAssertMessages("var unused;", { "no-unused-vars": 1 }, [
+ "1:5 'unused' is defined but never used. no-unused-vars",
+ ]);
+ });
+
+ // This two tests are disabled, as the feature to visit properties when
+ // there is a spread/rest operator has been removed as it caused problems
+ // with other rules #249
+ // eslint-disable-next-line jest/no-disabled-tests
+ it.skip("visits excluded properties left of spread #95", () => {
+ verifyAndAssertMessages(
+ "var originalObject = {}; var {field1, field2, ...clone} = originalObject;",
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ // eslint-disable-next-line jest/no-disabled-tests
+ it.skip("visits excluded properties left of spread #210", () => {
+ verifyAndAssertMessages(
+ "const props = { yo: 'yo' }; const { ...otherProps } = props;",
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("does not mark spread variables false-positive", () => {
+ verifyAndAssertMessages(
+ "var originalObject = {}; var {field1, field2, ...clone} = originalObject;",
+ { "no-undef": 1, "no-redeclare": 1 },
+ );
+ });
+
+ it("does not mark spread variables false-positive", () => {
+ verifyAndAssertMessages(
+ "const props = { yo: 'yo' }; const { ...otherProps } = props;",
+ { "no-undef": 1, "no-redeclare": 1 },
+ );
+ });
+
+ it("does not mark spread variables as use-before-define #249", () => {
+ verifyAndAssertMessages(
+ "var originalObject = {}; var {field1, field2, ...clone} = originalObject;",
+ { "no-use-before-define": 1 },
+ );
+ });
+
+ it("detects no-unused-vars with object destructuring #142", () => {
+ verifyAndAssertMessages(
+ "const {Bacona} = require('baconjs')",
+ { "no-undef": 1, "no-unused-vars": 1 },
+ ["1:8 'Bacona' is assigned a value but never used. no-unused-vars"],
+ );
+ });
+
+ it("don't warn no-unused-vars with spread #142", () => {
+ verifyAndAssertMessages(
+ `
+ export default function test(data) {
+ return {
+ foo: 'bar',
+ ...data
+ };
+ }
+ `,
+ { "no-undef": 1, "no-unused-vars": 1 },
+ );
+ });
+
+ it("excludes comment tokens #153", () => {
+ verifyAndAssertMessages(
+ `
+ var a = [
+ 1,
+ 2, // a trailing comment makes this line fail comma-dangle (always-multiline)
+ ];
+ `,
+ { "comma-dangle": [2, "always-multiline"] },
+ );
+
+ verifyAndAssertMessages(
+ `
+ switch (a) {
+ // A comment here makes the above line fail brace-style
+ case 1:
+ console.log(a);
+ }
+ `,
+ { "brace-style": 2 },
+ );
+ });
+
+ it("ternary and parens #149", () => {
+ verifyAndAssertMessages("true ? (true) : false;", { "space-infix-ops": 1 });
+ });
+
+ it("line comment space-in-parens #124", () => {
+ verifyAndAssertMessages(
+ `
+ React.createClass({
+ render() {
+ // return (
+ //
+ // ); // <-- this is the line that is reported
+ }
+ });
+ `,
+ { "space-in-parens": 1 },
+ );
+ });
+
+ it("block comment space-in-parens #124", () => {
+ verifyAndAssertMessages(
+ `
+ React.createClass({
+ render() {
+ /*
+ return (
+
+ ); // <-- this is the line that is reported
+ */
+ }
+ });
+ `,
+ { "space-in-parens": 1 },
+ );
+ });
+
+ it("no no-undef error with rest #11", () => {
+ verifyAndAssertMessages("const [a, ...rest] = ['1', '2', '3']; a; rest;", {
+ "no-undef": 1,
+ "no-unused-vars": 1,
+ });
+ });
+
+ it("async function with space-before-function-paren #168", () => {
+ verifyAndAssertMessages("it('handles updates', async function() {});", {
+ "space-before-function-paren": [1, "never"],
+ });
+ });
+
+ it("default param flow type no-unused-vars #184", () => {
+ verifyAndAssertMessages(
+ `
+ type ResolveOptionType = {
+ depth?: number,
+ identifier?: string
+ };
+
+ export default function resolve(
+ options: ResolveOptionType = {}
+ ): Object {
+ options;
+ }
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+
+ it("no-use-before-define #192", () => {
+ verifyAndAssertMessages(
+ `
+ console.log(x);
+ var x = 1;
+ `,
+ { "no-use-before-define": 1 },
+ ["1:13 'x' was used before it was defined. no-use-before-define"],
+ );
+ });
+
+ it("jsx and stringliteral #216", () => {
+ verifyAndAssertMessages("");
+ });
+
+ it("getter/setter #218", () => {
+ verifyAndAssertMessages(
+ `
+ class Person {
+ set a (v) { }
+ }
+ `,
+ {
+ "space-before-function-paren": 1,
+ "keyword-spacing": [1, { before: true }],
+ indent: 1,
+ },
+ );
+ });
+
+ it("getter/setter #220", () => {
+ verifyAndAssertMessages(
+ `
+ var B = {
+ get x () {
+ return this.ecks;
+ },
+ set x (ecks) {
+ this.ecks = ecks;
+ }
+ };
+ `,
+ { "no-dupe-keys": 1 },
+ );
+ });
+
+ it("fixes issues with flow types and ObjectPattern", () => {
+ verifyAndAssertMessages(
+ `
+ import type Foo from 'bar';
+ export default class Foobar {
+ foo({ bar }: Foo) { bar; }
+ bar({ foo }: Foo) { foo; }
+ }
+ `,
+ { "no-unused-vars": 1, "no-shadow": 1 },
+ );
+ });
+
+ it("correctly detects redeclares if in script mode #217", () => {
+ verifyAndAssertMessages(
+ `
+ var a = 321;
+ var a = 123;
+ `,
+ { "no-redeclare": 1 },
+ ["2:5 'a' is already defined. no-redeclare"],
+ "script",
+ );
+ });
+
+ it("correctly detects redeclares if in module mode #217", () => {
+ verifyAndAssertMessages(
+ `
+ var a = 321;
+ var a = 123;
+ `,
+ { "no-redeclare": 1 },
+ ["2:5 'a' is already defined. no-redeclare"],
+ "module",
+ );
+ });
+
+ it("no-implicit-globals in script: globalReturn is false", () => {
+ verifyAndAssertMessages(
+ "var leakedGlobal = 1;",
+ { "no-implicit-globals": 1 },
+ [
+ "1:5 Unexpected 'var' declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable. no-implicit-globals",
+ ],
+ "script",
+ {
+ env: {},
+ parserOptions: {
+ ecmaVersion: 6,
+ sourceType: "script",
+ ecmaFeatures: { globalReturn: false },
+ },
+ },
+ );
+ });
+
+ it("no-implicit-globals in script: globalReturn is true", () => {
+ verifyAndAssertMessages(
+ "var leakedGlobal = 1;",
+ { "no-implicit-globals": 1 },
+ [],
+ "script",
+ {
+ env: {},
+ parserOptions: {
+ ecmaVersion: 6,
+ sourceType: "script",
+ ecmaFeatures: { globalReturn: true },
+ },
+ },
+ );
+ });
+
+ it("no-implicit-globals in module", () => {
+ verifyAndAssertMessages(
+ "var leakedGlobal = 1;",
+ { "no-implicit-globals": 1 },
+ [],
+ "module",
+ {
+ env: {},
+ parserOptions: { ecmaVersion: 6, sourceType: "module" },
+ },
+ );
+ });
+
+ it("no-implicit-globals in default", () => {
+ verifyAndAssertMessages(
+ "var leakedGlobal = 1;",
+ { "no-implicit-globals": 1 },
+ [],
+ undefined,
+ {
+ env: {},
+ parserOptions: { ecmaVersion: 6 },
+ },
+ );
+ });
+
+ it("allowImportExportEverywhere option (#327)", () => {
+ verifyAndAssertMessages(
+ `
+ if (true) { import Foo from 'foo'; }
+ function foo() { import Bar from 'bar'; }
+ switch (a) { case 1: import FooBar from 'foobar'; }
+ `,
+ {},
+ [],
+ "module",
+ {
+ env: {},
+ parserOptions: {
+ ecmaVersion: 6,
+ sourceType: "module",
+ allowImportExportEverywhere: true,
+ },
+ },
+ );
+ });
+
+ it("with does not crash parsing in script mode (strict off) #171", () => {
+ verifyAndAssertMessages("with (arguments) { length; }", {}, [], "script");
+ });
+
+ it("with does crash parsing in module mode (strict on) #171", () => {
+ verifyAndAssertMessages("with (arguments) { length; }", {}, [
+ /'with' in strict mode/,
+ ]);
+ });
+
+ it("new.target is not reported as undef #235", () => {
+ verifyAndAssertMessages("function foo () { return new.target }", {
+ "no-undef": 1,
+ });
+ });
+
+ it("decorator does not create TypeError #229", () => {
+ verifyAndAssertMessages(
+ `
+ class A {
+ @test
+ f() {}
+ }
+ `,
+ { "no-undef": 1 },
+ ["2:4 'test' is not defined. no-undef"],
+ );
+ });
+
+ it("Flow definition does not trigger warnings #223", () => {
+ verifyAndAssertMessages(
+ `
+ import { Map as $Map } from 'immutable';
+ function myFunction($state: $Map, { a, b, c } : { a: ?Object, b: ?Object, c: $Map }) {}
+ `,
+ { "no-dupe-args": 1, "no-redeclare": 1, "no-shadow": 1 },
+ );
+ });
+
+ it("newline-before-return with comments #289", () => {
+ verifyAndAssertMessages(
+ `
+ function a() {
+ if (b) {
+ /* eslint-disable no-console */
+ console.log('test');
+ /* eslint-enable no-console */
+ }
+
+ return hasGlobal;
+ }
+ `,
+ { "newline-before-return": 1 },
+ );
+ });
+
+ it("spaced-comment with shebang #163", () => {
+ verifyAndAssertMessages(
+ `
+ #!/usr/bin/env babel-node
+ import {spawn} from 'foobar';
+ `,
+ { "spaced-comment": 1 },
+ );
+ });
+
+ describe("Class Property Declarations", () => {
+ it("no-redeclare false positive 1", () => {
+ verifyAndAssertMessages(
+ `
+ class Group {
+ static propTypes = {};
+ }
+ class TypicalForm {
+ static propTypes = {};
+ }
+ `,
+ { "no-redeclare": 1 },
+ );
+ });
+
+ it("no-redeclare false positive 2", () => {
+ verifyAndAssertMessages(
+ `
+ function validate() {}
+ class MyComponent {
+ static validate = validate;
+ }
+ `,
+ { "no-redeclare": 1 },
+ );
+ });
+
+ it("check references", () => {
+ verifyAndAssertMessages(
+ `
+ var a;
+ class A {
+ prop1;
+ prop2 = a;
+ prop3 = b;
+ }
+ new A
+ `,
+ { "no-undef": 1, "no-unused-vars": 1, "no-redeclare": 1 },
+ ["5:11 'b' is not defined. no-undef"],
+ );
+ });
+ });
+
+ it("dynamic import support", () => {
+ verifyAndAssertMessages("import('test-module').then(() => {})");
+ });
+
+ it("regex with es6 unicodeCodePointEscapes", () => {
+ verifyAndAssertMessages(
+ "string.replace(/[\u{0000A0}-\u{10FFFF}<>&]/gmiu, (char) => `${char.codePointAt(0).toString(16)};`);",
+ );
+ });
+
+ describe("class field declarations", () => {
+ describe("field declarations", () => {
+ it("should not be undefined", () => {
+ verifyAndAssertMessages(
+ `
+ class C {
+ d = 1;
+ }
+ `,
+ { "no-undef": 1 },
+ );
+ });
+
+ it("should not be unused", () => {
+ verifyAndAssertMessages(
+ `
+ export class C {
+ d = 1;
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+ });
+
+ describe("private field declarations", () => {
+ it("should not be undefined", () => {
+ verifyAndAssertMessages(
+ `
+ class C {
+ #d = 1;
+ }
+ `,
+ { "no-undef": 1 },
+ );
+ });
+
+ it("should not be unused", () => {
+ verifyAndAssertMessages(
+ `
+ export class C {
+ #d = 1;
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+ });
+
+ describe("private methods", () => {
+ it("should not be undefined", () => {
+ verifyAndAssertMessages(
+ `
+ class C {
+ #d() {};
+ }
+ `,
+ { "no-undef": 1 },
+ );
+ });
+
+ it("should not be unused", () => {
+ verifyAndAssertMessages(
+ `
+ export class C {
+ #d() {};
+ }
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+ });
+ });
+
+ describe("optional chaining operator", () => {
+ it("should not be undefined #595", () => {
+ verifyAndAssertMessages(
+ `
+ const foo = {};
+ foo?.bar;
+ `,
+ { "no-undef": 1 },
+ );
+ });
+ });
+
+ it("flow types on class method should be visited correctly", () => {
+ verifyAndAssertMessages(
+ `
+ import type NodeType from 'foo';
+ class NodeUtils {
+ finishNodeAt(node: T): T { return node; }
+ }
+
+ new NodeUtils();
+ `,
+ { "no-unused-vars": 1 },
+ );
+ });
+
+ it("works with dynamicImport", () => {
+ verifyAndAssertMessages(
+ `
+ import('a');
+ `,
+ );
+ });
+
+ it("works with numericSeparator", () => {
+ verifyAndAssertMessages(
+ `
+ 1_000
+ `,
+ );
+ });
+
+ it("works with optionalChaining", () => {
+ verifyAndAssertMessages(
+ `
+ a?.b
+ `,
+ );
+ });
+
+ it("works with import.meta", () => {
+ verifyAndAssertMessages(
+ `
+ import.meta
+ `,
+ );
+ });
+
+ it("works with classPrivateProperties", () => {
+ verifyAndAssertMessages(
+ `
+ class A { #a = 1; }
+ `,
+ );
+ });
+
+ it("works with classPrivateMethods", () => {
+ verifyAndAssertMessages(
+ `
+ class A { #a(b, c) {} }
+ `,
+ );
+ });
+
+ it("works with arrow function classPrivateProperties", () => {
+ verifyAndAssertMessages(
+ `
+ class A { #a = (a, b) => {}; }
+ `,
+ );
+ });
+
+ it("works with optionalCatchBinding", () => {
+ verifyAndAssertMessages(
+ `
+ try {} catch {}
+ try {} catch {} finally {}
+ `,
+ );
+ });
+
+ it("exportDefaultFrom", () => {
+ verifyAndAssertMessages(
+ `
+ export v from "mod"
+ `,
+ );
+ });
+
+ it("exportNamespaceFrom", () => {
+ verifyAndAssertMessages(
+ `
+ export * as ns from "mod"
+ `,
+ );
+ });
+
+ it("ignore eval in scope analysis", () => {
+ verifyAndAssertMessages(
+ `
+ const a = 1;
+ console.log(a);
+ eval('');
+ `,
+ { "no-unused-vars": 1, "no-undef": 1 },
+ );
+ });
+});
diff --git a/eslint/babel-eslint-tests/test/integration/eslint/rules/strict.js b/eslint/babel-eslint-tests/test/integration/eslint/rules/strict.js
new file mode 100644
index 000000000000..1bd83dd597b6
--- /dev/null
+++ b/eslint/babel-eslint-tests/test/integration/eslint/rules/strict.js
@@ -0,0 +1,212 @@
+import eslint from "eslint";
+import fs from "fs";
+import path from "path";
+import * as parser from "@babel/eslint-parser";
+
+eslint.linter.defineParser("@babel/eslint-parser", parser);
+
+const paths = {
+ fixtures: path.join(__dirname, "../../..", "fixtures", "rules"),
+};
+
+const encoding = "utf8";
+const errorLevel = 2;
+
+const baseEslintOpts = {
+ parser: "@babel/eslint-parser",
+ parserOptions: {
+ sourceType: "script",
+ requireConfigFile: false,
+ babelOptions: { configFile: false },
+ },
+};
+
+/**
+ * Load a fixture and run eslint.linter.verify() on it.
+ * Pass the return value to done().
+ * @param object opts
+ * @param function done
+ */
+function lint(opts, done) {
+ readFixture(opts.fixture, (err, src) => {
+ if (err) return done(err);
+ done(null, eslint.linter.verify(src, opts.eslint));
+ });
+}
+
+/**
+ * Read a fixture file, passing the content to done().
+ * @param string|array id
+ * @param function done
+ */
+function readFixture(id, done) {
+ if (Array.isArray(id)) id = path.join.apply(path, id);
+ if (!path.extname(id)) id += ".js";
+ fs.readFile(path.join(paths.fixtures, id), encoding, done);
+}
+// readFixture
+
+describe("Rules:", () => {
+ describe("`strict`", strictSuite);
+});
+
+function strictSuite() {
+ const ruleId = "strict";
+
+ describe("when set to 'never'", () => {
+ const eslintOpts = Object.assign({}, baseEslintOpts, {
+ rules: {},
+ });
+ eslintOpts.rules[ruleId] = [errorLevel, "never"];
+
+ ["global-with", "function-with"].forEach(fixture => {
+ it(`should error on ${fixture.match(/^[^-]+/)[0]} directive`, done => {
+ lint(
+ {
+ fixture: ["strict", fixture],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ done();
+ },
+ );
+ });
+ });
+ });
+
+ describe("when set to 'global'", () => {
+ const eslintOpts = Object.assign({}, baseEslintOpts, {
+ rules: {},
+ });
+ eslintOpts.rules[ruleId] = [errorLevel, "global"];
+
+ it("shouldn't error on single global directive", done => {
+ lint(
+ {
+ fixture: ["strict", "global-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report.length).toBe(0);
+ done();
+ },
+ );
+ });
+
+ it("should error twice on global directive: no and function directive: yes", done => {
+ lint(
+ {
+ fixture: ["strict", "function-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ done();
+ },
+ );
+ });
+
+ it("should error on function directive", done => {
+ lint(
+ {
+ fixture: ["strict", "global-with-function-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ // This is to make sure the test fails prior to adapting Babel AST
+ // directive representation to ESLint format. Otherwise it reports an
+ // error for missing global directive that masquerades as the expected
+ // result of the previous assertion.
+ expect(report[0].nodeType).not.toBe("Program");
+ done();
+ },
+ );
+ });
+
+ it("should error on no directive", done => {
+ lint(
+ {
+ fixture: ["strict", "none"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ done();
+ },
+ );
+ });
+ });
+
+ describe("when set to 'function'", () => {
+ const eslintOpts = Object.assign({}, baseEslintOpts, {
+ rules: {},
+ });
+ eslintOpts.rules[ruleId] = [errorLevel, "function"];
+
+ it("shouldn't error on single function directive", done => {
+ lint(
+ {
+ fixture: ["strict", "function-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report.length).toBe(0);
+ done();
+ },
+ );
+ });
+
+ it("should error twice on function directive: no and global directive: yes", done => {
+ lint(
+ {
+ fixture: ["strict", "global-with-function-without"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ [0, 1].forEach(i => {
+ expect(report[i].ruleId).toBe(ruleId);
+ });
+ done();
+ },
+ );
+ });
+
+ it("should error on only global directive", done => {
+ lint(
+ {
+ fixture: ["strict", "global-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ done();
+ },
+ );
+ });
+
+ it("should error on extraneous global directive", done => {
+ lint(
+ {
+ fixture: ["strict", "global-with-function-with"],
+ eslint: eslintOpts,
+ },
+ (err, report) => {
+ if (err) return done(err);
+ expect(report[0].ruleId).toBe(ruleId);
+ expect(report[0].nodeType.indexOf("Function")).toBe(-1);
+ done();
+ },
+ );
+ });
+ });
+}
diff --git a/jest.config.js b/jest.config.js
new file mode 100644
index 000000000000..7af88ad8ff06
--- /dev/null
+++ b/jest.config.js
@@ -0,0 +1,67 @@
+// These packages undet the @babel namespace aren't in this monorepo.
+const externalBabelPackages = [
+ "plugin-syntax-async-generators",
+ "plugin-syntax-bigint",
+ "plugin-syntax-dynamic-import",
+ "plugin-syntax-json-strings",
+ "plugin-syntax-nullish-coalescing-operator",
+ "plugin-syntax-object-rest-spread",
+ "plugin-syntax-optional-catch-binding",
+ "plugin-syntax-optional-chaining",
+ "plugin-syntax-export-namespace-from",
+];
+
+// prettier-ignore
+const monorepoPackagePattern =
+ `^@babel/(?!eslint-)(?!${externalBabelPackages.join("|")})([a-zA-Z0-9_-]+)$`;
+
+module.exports = {
+ collectCoverageFrom: [
+ "packages/*/src/**/*.mjs",
+ "packages/*/src/**/*.js",
+ "codemods/*/src/**/*.mjs",
+ "codemods/*/src/**/*.js",
+ "eslint/*/src/**/*.mjs",
+ "eslint/*/src/**/*.js",
+ ],
+ // The eslint/* packages use ESLint v6, which has dropped support for Node v6.
+ // TODO: Remove this process.version check in Babel 8.
+ testRegex: `./(packages|codemods${
+ /^v6./u.test(process.version) ? "" : "|eslint"
+ })/[^/]+/test/.+\\.m?js$`,
+ testPathIgnorePatterns: [
+ "/node_modules/",
+ "/test/fixtures/",
+ "/test/debug-fixtures/",
+ "/babel-parser/test/expressions/",
+ "/test/tmp/",
+ "/test/__data__/",
+ "/test/helpers/",
+ "/test/warning\\.js",
+ "/build/",
+ "_browser\\.js",
+ ],
+ testEnvironment: "node",
+ setupFilesAfterEnv: ["/test/testSetupFile.js"],
+ transformIgnorePatterns: [
+ "/node_modules/",
+ "/packages/babel-standalone/babel(\\.min)?\\.js",
+ "/test/(fixtures|tmp|__data__)/",
+ "/(packages|codemods|eslint)/[^/]+/lib/",
+ ],
+ coveragePathIgnorePatterns: [
+ "/node_modules/",
+ "/packages/babel-standalone/babel(\\.min)?\\.js",
+ "/test/(fixtures|tmp|__data__)/",
+ ],
+ modulePathIgnorePatterns: [
+ "/test/fixtures/",
+ "/test/tmp/",
+ "/test/__data__/",
+ "/build/",
+ ],
+ moduleNameMapper: {
+ [monorepoPackagePattern]: "/packages/babel-$1/",
+ "^@babel/eslint-([a-zA-Z0-9_-]+)$": "/eslint/babel-eslint-$1/",
+ },
+};
diff --git a/lerna.json b/lerna.json
index 10d091d9337f..c8a4e6634e7d 100644
--- a/lerna.json
+++ b/lerna.json
@@ -1,5 +1,5 @@
{
- "version": "7.5.5",
+ "version": "7.9.5",
"changelog": {
"repo": "babel/babel",
"cacheDir": ".changelog",
@@ -11,7 +11,8 @@
"PR: Polish :nail_care:": ":nail_care: Polish",
"PR: Docs :memo:": ":memo: Documentation",
"PR: Internal :house:": ":house: Internal",
- "PR: Performance :running_woman:": ":running_woman: Performance"
+ "PR: Performance :running_woman:": ":running_woman: Performance",
+ "PR: Revert :leftwards_arrow_with_hook:": ":leftwards_arrow_with_hook: Revert"
}
},
"command": {
@@ -20,14 +21,18 @@
"*.md",
"*.txt",
"test/**",
+ "**/test/**",
"codemods/**",
- "# We ignore every JSON file, except for built-in-modules, built-ins and plugins defined in babel-preset-env/data.",
- "@(!(built-in-modules|built-ins|plugins|package)).json"
+ "# We ignore every JSON file, except for native-modules, built-ins and plugins defined in babel-preset-env/data.",
+ "@(!(native-modules|built-ins|plugins|package)).json",
+ "# Until the ESLint packages version are aligned with Babel's, we ignore them",
+ "eslint/**"
]
}
},
"packages": [
"codemods/*",
+ "eslint/*",
"packages/*"
],
"npmClient": "yarn",
diff --git a/lib/preset-modules.js.flow b/lib/preset-modules.js.flow
new file mode 100644
index 000000000000..78e460f1bbea
--- /dev/null
+++ b/lib/preset-modules.js.flow
@@ -0,0 +1,18 @@
+declare module "@babel/preset-modules/lib/plugins/transform-async-arrows-in-class" {
+ declare module.exports: Function;
+}
+declare module "@babel/preset-modules/lib/plugins/transform-edge-default-parameters" {
+ declare module.exports: Function;
+}
+declare module "@babel/preset-modules/lib/plugins/transform-edge-function-name" {
+ declare module.exports: Function;
+}
+declare module "@babel/preset-modules/lib/plugins/transform-tagged-template-caching" {
+ declare module.exports: Function;
+}
+declare module "@babel/preset-modules/lib/plugins/transform-safari-block-shadowing" {
+ declare module.exports: Function;
+}
+declare module "@babel/preset-modules/lib/plugins/transform-safari-for-shadowing" {
+ declare module.exports: Function;
+}
diff --git a/lib/third-party-libs.js.flow b/lib/third-party-libs.js.flow
index c21a2797acfe..b41fbe725b4e 100644
--- a/lib/third-party-libs.js.flow
+++ b/lib/third-party-libs.js.flow
@@ -4,6 +4,7 @@
declare module "resolve" {
declare export default {
+ (string, {| basedir: string |}, (err: ?Error, res: string) => void): void;
sync: (string, {| basedir: string |}) => string;
};
}
@@ -165,7 +166,7 @@ declare module "source-map" {
}
declare module "convert-source-map" {
- import type { SourceMap } from "source-map";
+ import type { SourceMap, SourceMapGenerator } from "source-map";
declare class Converter {
toJSON(): string;
@@ -177,11 +178,11 @@ declare module "convert-source-map" {
declare module.exports: {
SourceMap: SourceMap,
Converter: Converter,
- fromObject(obj: SourceMap): Converter,
- fromJSON(str: string): Converter,
+ fromObject(obj: SourceMap | SourceMapGenerator): Converter,
+ fromJSON(str: string | Buffer): Converter,
fromBase64(str: string): Converter,
fromComment(str: string): Converter,
- fromMapFileComment(str: string): Converter,
+ fromMapFileComment(str: string, dir: string): Converter,
fromSource(str: string): Converter,
fromMapFileSource(str: string, dir: string): Converter,
removeComments(str: string): string,
@@ -190,12 +191,6 @@ declare module "convert-source-map" {
};
}
-declare module "js-levenshtein" {
- declare module.exports: {
- (string, string): number,
- };
-}
-
declare module "core-js-compat/data" {
declare type Target = "node" | "chrome" | "opera" | "edge" | "firefox" | "safari" | "ie" | "ios" | "android" | "electron" | "samsung";
diff --git a/package.json b/package.json
index bd04e0638455..24f8db36b6c5 100644
--- a/package.json
+++ b/package.json
@@ -3,79 +3,81 @@
"private": true,
"license": "MIT",
"scripts": {
+ "bootstrap": "make bootstrap",
+ "codesandbox": "make bootstrap-only; make build-no-bundle",
"build": "make build",
"fix": "make fix",
"lint": "make lint",
"test": "make test"
},
"devDependencies": {
- "@babel/cli": "^7.4.4",
- "@babel/core": "^7.4.5",
+ "@babel/cli": "^7.8.4",
+ "@babel/core": "^7.9.0",
"@babel/eslint-plugin-development": "^1.0.1",
- "@babel/plugin-proposal-class-properties": "^7.4.4",
- "@babel/plugin-proposal-export-namespace-from": "^7.2.0",
- "@babel/plugin-proposal-numeric-separator": "^7.2.0",
- "@babel/plugin-transform-modules-commonjs": "^7.4.4",
- "@babel/plugin-transform-runtime": "^7.4.4",
- "@babel/preset-env": "^7.4.5",
- "@babel/preset-flow": "^7.0.0",
- "@babel/register": "^7.4.4",
- "@babel/runtime": "^7.4.5",
- "babel-eslint": "^11.0.0-beta.0",
- "babel-jest": "^24.8.0",
- "babel-loader": "^8.0.6",
+ "@babel/plugin-proposal-class-properties": "^7.8.3",
+ "@babel/plugin-proposal-dynamic-import": "^7.8.3",
+ "@babel/plugin-proposal-export-namespace-from": "^7.8.3",
+ "@babel/plugin-proposal-object-rest-spread": "^7.9.5",
+ "@babel/plugin-transform-flow-strip-types": "^7.9.0",
+ "@babel/plugin-transform-for-of": "^7.9.0",
+ "@babel/plugin-transform-modules-commonjs": "^7.9.0",
+ "@babel/plugin-transform-runtime": "^7.9.0",
+ "@babel/preset-env": "^7.9.5",
+ "@babel/preset-flow": "^7.9.0",
+ "@babel/register": "^7.9.0",
+ "@babel/runtime": "^7.9.2",
+ "@rollup/plugin-json": "4.0.1",
+ "babel-eslint": "^11.0.0-beta.2",
+ "babel-jest": "^24.9.0",
"babel-plugin-transform-charcodes": "^0.2.0",
"browserify": "^16.2.3",
"bundle-collapser": "^1.2.1",
"chalk": "^2.4.2",
"charcodes": "^0.2.0",
"derequire": "^2.0.2",
- "duplicate-package-checker-webpack-plugin": "^2.1.0",
"enhanced-resolve": "^3.0.0",
- "eslint": "^5.16.0",
- "eslint-config-babel": "^9.0.0",
- "eslint-plugin-flowtype": "^3.8.2",
- "eslint-plugin-import": "^2.17.2",
- "eslint-plugin-prettier": "^3.1.0",
+ "eslint": "^6.8.0",
+ "eslint-import-resolver-node": "^0.3.3",
+ "eslint-plugin-flowtype": "^4.6.0",
+ "eslint-plugin-import": "^2.20.1",
+ "eslint-plugin-jest": "^23.8.2",
+ "eslint-plugin-prettier": "^3.1.2",
"fancy-log": "^1.3.3",
- "flow-bin": "^0.94.0",
- "graceful-fs": "^4.1.15",
+ "flow-bin": "^0.108.0",
"gulp": "^4.0.2",
"gulp-babel": "^8.0.0",
"gulp-filter": "^5.1.0",
"gulp-newer": "^1.0.0",
"gulp-plumber": "^1.2.1",
- "gulp-rename": "^1.4.0",
- "gulp-uglify": "^3.0.2",
- "gulp-watch": "^5.0.1",
- "husky": "^2.3.0",
- "jest": "^24.8.0",
- "lerna": "^3.14.2",
+ "husky": "^3.0.0",
+ "jest": "^24.9.0",
+ "lerna": "^3.19.0",
"lerna-changelog": "^0.5.0",
- "lint-staged": "^8.1.7",
+ "lint-staged": "^9.2.0",
"lodash": "^4.17.13",
- "merge-stream": "^1.0.1",
+ "mergeiterator": "^1.2.5",
"output-file-sync": "^2.0.0",
- "prettier": "^1.17.1",
+ "prettier": "^1.19.1",
"pump": "^3.0.0",
"rimraf": "^2.6.3",
- "rollup": "^1.12.0",
- "rollup-plugin-babel": "^4.0.0",
+ "rollup": "^1.32.1",
+ "rollup-plugin-babel": "^4.4.0",
+ "rollup-plugin-commonjs": "^10.1.0",
+ "rollup-plugin-node-builtins": "^2.1.2",
+ "rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-node-resolve": "^5.0.0",
"rollup-plugin-replace": "^2.2.0",
- "test262-stream": "^1.2.0",
+ "rollup-plugin-terser": "^5.3.0",
+ "test262-stream": "^1.3.0",
"through2": "^2.0.0",
- "warnings-to-errors-webpack-plugin": "^2.0.0",
- "webpack": "^3.4.1",
- "webpack-dependency-suite": "^2.4.4",
- "webpack-stream": "^4.0.0"
+ "typescript": "^3.6.3"
},
"resolutions": {
- "@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates"
+ "@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates"
},
"engines": {
- "node": ">= 6.9.0 < 13.0.0",
- "npm": ">= 3.x <= 6.x",
+ "node": ">= 6.9.0",
+ "npm": ">= 3.x",
"yarn": ">=0.27.5 || >=1.0.0-20170811"
},
"lint-staged": {
@@ -87,53 +89,5 @@
"hooks": {
"pre-commit": "lint-staged"
}
- },
- "jest": {
- "collectCoverageFrom": [
- "packages/*/src/**/*.mjs",
- "packages/*/src/**/*.js",
- "codemods/*/src/**/*.mjs",
- "codemods/*/src/**/*.js"
- ],
- "testRegex": "./(packages|codemods)/[^/]+/test/.+\\.m?js$",
- "testPathIgnorePatterns": [
- "/node_modules/",
- "/test/fixtures/",
- "/test/debug-fixtures/",
- "/babel-parser/test/expressions/",
- "/test/tmp/",
- "/test/__data__/",
- "/test/helpers/",
- "/test/warning\\.js",
- "/build/",
- "_browser\\.js"
- ],
- "testEnvironment": "node",
- "setupFilesAfterEnv": [
- "/test/testSetupFile.js"
- ],
- "transformIgnorePatterns": [
- "/node_modules/",
- "/packages/babel-standalone/babel(\\.min)?\\.js",
- "/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
- "/test/(fixtures|tmp|__data__)/",
- "/(packages|codemods)/[^/]+/lib/"
- ],
- "coveragePathIgnorePatterns": [
- "/node_modules/",
- "/packages/babel-standalone/babel(\\.min)?\\.js",
- "/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
- "/test/(fixtures|tmp|__data__)/"
- ],
- "modulePathIgnorePatterns": [
- "/test/fixtures/",
- "/test/tmp/",
- "/test/__data__/",
- "/build/"
- ],
- "moduleNameMapper": {
- "^@babel/([a-zA-Z0-9_-]+)$": "/packages/babel-$1/"
- }
- },
- "dependencies": {}
+ }
}
diff --git a/packages/babel-cli/package.json b/packages/babel-cli/package.json
index 0b4bd8731363..e8def286ed40 100644
--- a/packages/babel-cli/package.json
+++ b/packages/babel-cli/package.json
@@ -1,6 +1,6 @@
{
"name": "@babel/cli",
- "version": "7.5.5",
+ "version": "7.8.4",
"description": "Babel command line.",
"author": "Sebastian McKenzie ",
"homepage": "https://babeljs.io/",
@@ -19,25 +19,25 @@
"compiler"
],
"dependencies": {
- "commander": "^2.8.1",
+ "commander": "^4.0.1",
"convert-source-map": "^1.1.0",
"fs-readdir-recursive": "^1.1.0",
"glob": "^7.0.0",
"lodash": "^4.17.13",
- "mkdirp": "^0.5.1",
- "output-file-sync": "^2.0.0",
+ "make-dir": "^2.1.0",
"slash": "^2.0.0",
"source-map": "^0.5.0"
},
"optionalDependencies": {
- "chokidar": "^2.0.4"
+ "chokidar": "^2.1.8"
},
"peerDependencies": {
"@babel/core": "^7.0.0-0"
},
"devDependencies": {
- "@babel/core": "^7.5.5",
- "@babel/helper-fixtures": "^7.5.5"
+ "@babel/core": "^7.8.4",
+ "@babel/helper-fixtures": "^7.8.3",
+ "rimraf": "^3.0.0"
},
"bin": {
"babel": "./bin/babel.js",
diff --git a/packages/babel-cli/src/babel-external-helpers.js b/packages/babel-cli/src/babel-external-helpers.js
index c2560dfa6f37..fef536187c41 100755
--- a/packages/babel-cli/src/babel-external-helpers.js
+++ b/packages/babel-cli/src/babel-external-helpers.js
@@ -1,7 +1,12 @@
+// @flow
+
import commander from "commander";
import { buildExternalHelpers } from "@babel/core";
-function collect(value, previousValue): Array {
+function collect(
+ value: string | any,
+ previousValue: Array,
+): Array {
// If the user passed the option with no value, like "babel-external-helpers --whitelist", do nothing.
if (typeof value !== "string") return previousValue;
diff --git a/packages/babel-cli/src/babel/dir.js b/packages/babel-cli/src/babel/dir.js
index 2eaca85750f8..9b199b98a4e2 100644
--- a/packages/babel-cli/src/babel/dir.js
+++ b/packages/babel-cli/src/babel/dir.js
@@ -1,24 +1,48 @@
+// @flow
+
import defaults from "lodash/defaults";
-import outputFileSync from "output-file-sync";
-import { sync as mkdirpSync } from "mkdirp";
+import { sync as makeDirSync } from "make-dir";
import slash from "slash";
import path from "path";
import fs from "fs";
import * as util from "./util";
+import { type CmdOptions } from "./options";
+
+const FILE_TYPE = Object.freeze({
+ NON_COMPILABLE: "NON_COMPILABLE",
+ COMPILED: "COMPILED",
+ IGNORED: "IGNORED",
+ ERR_COMPILATION: "ERR_COMPILATION",
+});
+
+function outputFileSync(filePath: string, data: string | Buffer): void {
+ makeDirSync(path.dirname(filePath));
+ fs.writeFileSync(filePath, data);
+}
-export default async function({ cliOptions, babelOptions }) {
+export default async function({
+ cliOptions,
+ babelOptions,
+}: CmdOptions): Promise {
const filenames = cliOptions.filenames;
- async function write(src, base) {
+ async function write(
+ src: string,
+ base: string,
+ ): Promise<$Keys> {
let relative = path.relative(base, src);
if (!util.isCompilableExtension(relative, cliOptions.extensions)) {
- return false;
+ return FILE_TYPE.NON_COMPILABLE;
}
- // remove extension and then append back on .js
- relative = util.adjustRelative(relative, cliOptions.keepFileExtension);
+ relative = util.withExtension(
+ relative,
+ cliOptions.keepFileExtension
+ ? path.extname(relative)
+ : cliOptions.outFileExtension,
+ );
const dest = getDest(relative, base);
@@ -33,7 +57,7 @@ export default async function({ cliOptions, babelOptions }) {
),
);
- if (!res) return false;
+ if (!res) return FILE_TYPE.IGNORED;
// we've requested explicit sourcemaps to be written to disk
if (
@@ -54,37 +78,40 @@ export default async function({ cliOptions, babelOptions }) {
console.log(src + " -> " + dest);
}
- return true;
+ return FILE_TYPE.COMPILED;
} catch (err) {
if (cliOptions.watch) {
console.error(err);
- return false;
+ return FILE_TYPE.ERR_COMPILATION;
}
throw err;
}
}
- function getDest(filename, base) {
+ function getDest(filename: string, base: string): string {
if (cliOptions.relative) {
return path.join(base, cliOptions.outDir, filename);
}
return path.join(cliOptions.outDir, filename);
}
- async function handleFile(src, base) {
+ async function handleFile(src: string, base: string): Promise {
const written = await write(src, base);
- if (!written && cliOptions.copyFiles) {
+ if (
+ (cliOptions.copyFiles && written === FILE_TYPE.NON_COMPILABLE) ||
+ (cliOptions.copyIgnored && written === FILE_TYPE.IGNORED)
+ ) {
const filename = path.relative(base, src);
const dest = getDest(filename, base);
outputFileSync(dest, fs.readFileSync(src));
util.chmod(src, dest);
}
- return written;
+ return written === FILE_TYPE.COMPILED;
}
- async function handle(filenameOrDir) {
+ async function handle(filenameOrDir: string): Promise {
if (!fs.existsSync(filenameOrDir)) return 0;
const stat = fs.statSync(filenameOrDir);
@@ -116,24 +143,26 @@ export default async function({ cliOptions, babelOptions }) {
util.deleteDir(cliOptions.outDir);
}
- mkdirpSync(cliOptions.outDir);
+ makeDirSync(cliOptions.outDir);
let compiledFiles = 0;
for (const filename of cliOptions.filenames) {
compiledFiles += await handle(filename);
}
- console.log(
- `Successfully compiled ${compiledFiles} ${
- compiledFiles !== 1 ? "files" : "file"
- } with Babel.`,
- );
+ if (!cliOptions.quiet) {
+ console.log(
+ `Successfully compiled ${compiledFiles} ${
+ compiledFiles !== 1 ? "files" : "file"
+ } with Babel.`,
+ );
+ }
}
if (cliOptions.watch) {
const chokidar = util.requireChokidar();
- filenames.forEach(function(filenameOrDir) {
+ filenames.forEach(function(filenameOrDir: string): void {
const watcher = chokidar.watch(filenameOrDir, {
persistent: true,
ignoreInitial: true,
@@ -143,8 +172,8 @@ export default async function({ cliOptions, babelOptions }) {
},
});
- ["add", "change"].forEach(function(type) {
- watcher.on(type, function(filename) {
+ ["add", "change"].forEach(function(type: string): void {
+ watcher.on(type, function(filename: string): void {
handleFile(
filename,
filename === filenameOrDir
diff --git a/packages/babel-cli/src/babel/file.js b/packages/babel-cli/src/babel/file.js
index f0678e27ed39..c1c60ff91615 100644
--- a/packages/babel-cli/src/babel/file.js
+++ b/packages/babel-cli/src/babel/file.js
@@ -1,14 +1,26 @@
+// @flow
+
import convertSourceMap from "convert-source-map";
import defaults from "lodash/defaults";
import sourceMap from "source-map";
import slash from "slash";
+import { sync as makeDirSync } from "make-dir";
import path from "path";
import fs from "fs";
import * as util from "./util";
-
-export default async function({ cliOptions, babelOptions }) {
- function buildResult(fileResults) {
+import { type CmdOptions } from "./options";
+
+type CompilationOutput = {
+ code: string,
+ map: Object,
+};
+
+export default async function({
+ cliOptions,
+ babelOptions,
+}: CmdOptions): Promise {
+ function buildResult(fileResults: Array