From 411a2c1a5af9473683d0233a9075980c1e870f59 Mon Sep 17 00:00:00 2001 From: Istvan Soos Date: Wed, 22 Jan 2025 12:09:23 +0100 Subject: [PATCH] Fix ARIA label for the logo pointing to the pub landing page. --- app/lib/dartdoc/dartdoc_page.dart | 7 +++++-- app/lib/frontend/templates/views/shared/site_header.dart | 3 +++ app/test/frontend/golden/authorized_page.html | 2 +- app/test/frontend/golden/consent_page.html | 2 +- app/test/frontend/golden/create_publisher_page.html | 2 +- app/test/frontend/golden/error_page.html | 2 +- app/test/frontend/golden/help_page.html | 2 +- app/test/frontend/golden/my_activity_log_page.html | 2 +- app/test/frontend/golden/my_liked_packages.html | 2 +- app/test/frontend/golden/my_packages.html | 2 +- app/test/frontend/golden/my_publishers.html | 2 +- app/test/frontend/golden/pkg_activity_log_page.html | 2 +- app/test/frontend/golden/pkg_admin_page.html | 2 +- app/test/frontend/golden/pkg_changelog_page.html | 2 +- app/test/frontend/golden/pkg_example_page.html | 2 +- app/test/frontend/golden/pkg_index_page.html | 2 +- app/test/frontend/golden/pkg_install_page.html | 2 +- app/test/frontend/golden/pkg_score_page.html | 2 +- .../golden/pkg_score_page_with_downloads_chart.html | 2 +- app/test/frontend/golden/pkg_show_page.html | 2 +- app/test/frontend/golden/pkg_show_page_discontinued.html | 2 +- app/test/frontend/golden/pkg_show_page_flutter_plugin.html | 2 +- app/test/frontend/golden/pkg_show_page_publisher.html | 2 +- app/test/frontend/golden/pkg_show_page_retracted.html | 2 +- .../pkg_show_page_retracted_non_retracted_version.html | 2 +- app/test/frontend/golden/pkg_show_version_page.html | 2 +- app/test/frontend/golden/pkg_versions_page.html | 2 +- app/test/frontend/golden/publisher_activity_log_page.html | 2 +- app/test/frontend/golden/publisher_admin_page.html | 2 +- app/test/frontend/golden/publisher_list_page.html | 2 +- app/test/frontend/golden/publisher_packages_page.html | 2 +- .../frontend/golden/publisher_unlisted_packages_page.html | 2 +- app/test/frontend/golden/report_page.html | 2 +- app/test/frontend/golden/report_page_appeal.html | 2 +- app/test/frontend/golden/search_page.html | 2 +- app/test/frontend/golden/topics_page.html | 2 +- .../testdata/goldens/documentation/oxygen/1.0.0/index.html | 2 +- .../documentation/oxygen/1.0.0/oxygen/MainClass-class.html | 2 +- .../oxygen/1.0.0/oxygen/MainClass/MainClass.html | 2 +- .../documentation/oxygen/1.0.0/oxygen/MainClass/text.html | 2 +- .../oxygen/1.0.0/oxygen/MainClass/toLowerCase.html | 2 +- .../oxygen/1.0.0/oxygen/MainClass/toString.html | 2 +- .../documentation/oxygen/1.0.0/oxygen/TypeEnum.html | 2 +- .../oxygen/1.0.0/oxygen/TypeEnum/values-constant.html | 2 +- .../goldens/documentation/oxygen/1.0.0/oxygen/index.html | 2 +- .../goldens/documentation/oxygen/1.0.0/oxygen/main.html | 2 +- .../testdata/goldens/documentation/oxygen/2.0.0/index.html | 2 +- .../documentation/oxygen/2.0.0/oxygen/MainClass-class.html | 2 +- .../oxygen/2.0.0/oxygen/MainClass/MainClass.html | 2 +- .../documentation/oxygen/2.0.0/oxygen/MainClass/text.html | 2 +- .../oxygen/2.0.0/oxygen/MainClass/toLowerCase.html | 2 +- .../oxygen/2.0.0/oxygen/MainClass/toString.html | 2 +- .../documentation/oxygen/2.0.0/oxygen/TypeEnum.html | 2 +- .../oxygen/2.0.0/oxygen/TypeEnum/values-constant.html | 2 +- .../goldens/documentation/oxygen/2.0.0/oxygen/index.html | 2 +- .../goldens/documentation/oxygen/2.0.0/oxygen/main.html | 2 +- .../goldens/documentation/oxygen/latest/index.html | 2 +- .../oxygen/latest/oxygen/MainClass-class.html | 2 +- .../oxygen/latest/oxygen/MainClass/MainClass.html | 2 +- .../documentation/oxygen/latest/oxygen/MainClass/text.html | 2 +- .../oxygen/latest/oxygen/MainClass/toLowerCase.html | 2 +- .../oxygen/latest/oxygen/MainClass/toString.html | 2 +- .../documentation/oxygen/latest/oxygen/TypeEnum.html | 2 +- .../oxygen/latest/oxygen/TypeEnum/values-constant.html | 2 +- .../goldens/documentation/oxygen/latest/oxygen/index.html | 2 +- .../goldens/documentation/oxygen/latest/oxygen/main.html | 2 +- app/test/task/testdata/goldens/packages/oxygen.html | 2 +- .../task/testdata/goldens/packages/oxygen/changelog.html | 2 +- .../task/testdata/goldens/packages/oxygen/example.html | 2 +- .../task/testdata/goldens/packages/oxygen/install.html | 2 +- .../task/testdata/goldens/packages/oxygen/license.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/score.html | 2 +- .../task/testdata/goldens/packages/oxygen/versions.html | 2 +- .../testdata/goldens/packages/oxygen/versions/1.0.0.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/changelog.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/example.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/install.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/license.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/score.html | 2 +- .../testdata/goldens/packages/oxygen/versions/2.0.0.html | 2 +- 80 files changed, 86 insertions(+), 80 deletions(-) diff --git a/app/lib/dartdoc/dartdoc_page.dart b/app/lib/dartdoc/dartdoc_page.dart index 2764b465ff..3f311085a8 100644 --- a/app/lib/dartdoc/dartdoc_page.dart +++ b/app/lib/dartdoc/dartdoc_page.dart @@ -153,8 +153,11 @@ extension DartDocPageRender on DartDocPage { href: '/', classes: ['hidden-xs'], child: d.img( - // TODO: Move this into a class - attributes: {'style': 'height: 30px; margin-right: 1em;'}, + attributes: { + 'aria-label': 'Go to the landing page of pub.dev', + // TODO: Move this into a class + 'style': 'height: 30px; margin-right: 1em;', + }, image: d.Image.decorative( src: staticUrls.dartLogoSvg, height: 30, diff --git a/app/lib/frontend/templates/views/shared/site_header.dart b/app/lib/frontend/templates/views/shared/site_header.dart index d45de6f747..3430fef177 100644 --- a/app/lib/frontend/templates/views/shared/site_header.dart +++ b/app/lib/frontend/templates/views/shared/site_header.dart @@ -24,6 +24,9 @@ d.Node siteHeaderNode({ d.a( classes: ['logo'], href: '/', + attributes: { + 'aria-label': 'Go to the landing page of pub.dev', + }, child: d.img( classes: ['site-logo'], image: d.Image.decorative( diff --git a/app/test/frontend/golden/authorized_page.html b/app/test/frontend/golden/authorized_page.html index 98e737892c..2ecd7a0ac2 100644 --- a/app/test/frontend/golden/authorized_page.html +++ b/app/test/frontend/golden/authorized_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/consent_page.html b/app/test/frontend/golden/consent_page.html index 56bd703632..1844a584e8 100644 --- a/app/test/frontend/golden/consent_page.html +++ b/app/test/frontend/golden/consent_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/create_publisher_page.html b/app/test/frontend/golden/create_publisher_page.html index a56b11e087..8b000f34c9 100644 --- a/app/test/frontend/golden/create_publisher_page.html +++ b/app/test/frontend/golden/create_publisher_page.html @@ -34,7 +34,7 @@
-
diff --git a/app/test/frontend/golden/error_page.html b/app/test/frontend/golden/error_page.html index 0cf4e96a8e..9a7a263eb5 100644 --- a/app/test/frontend/golden/error_page.html +++ b/app/test/frontend/golden/error_page.html @@ -34,7 +34,7 @@
-
diff --git a/app/test/frontend/golden/help_page.html b/app/test/frontend/golden/help_page.html index 9a0d6c1426..3676434a0d 100644 --- a/app/test/frontend/golden/help_page.html +++ b/app/test/frontend/golden/help_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 59947e9625..952dff07aa 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index d4d547d318..238765c4a1 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -36,7 +36,7 @@
-
diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index 321ef6c198..1bdb0999b9 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/my_publishers.html b/app/test/frontend/golden/my_publishers.html index fd397e7c83..28f1437f40 100644 --- a/app/test/frontend/golden/my_publishers.html +++ b/app/test/frontend/golden/my_publishers.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index 7546028f60..b5807721ad 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html index e4b0eecfc9..602a64a17a 100644 --- a/app/test/frontend/golden/pkg_admin_page.html +++ b/app/test/frontend/golden/pkg_admin_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html index c1731011b4..94095cced7 100644 --- a/app/test/frontend/golden/pkg_changelog_page.html +++ b/app/test/frontend/golden/pkg_changelog_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html index 81eabba500..b487dd728a 100644 --- a/app/test/frontend/golden/pkg_example_page.html +++ b/app/test/frontend/golden/pkg_example_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html index 99ded5b281..e8511553c0 100644 --- a/app/test/frontend/golden/pkg_index_page.html +++ b/app/test/frontend/golden/pkg_index_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/pkg_install_page.html b/app/test/frontend/golden/pkg_install_page.html index 106438baa5..b5a7d88fbf 100644 --- a/app/test/frontend/golden/pkg_install_page.html +++ b/app/test/frontend/golden/pkg_install_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_score_page.html b/app/test/frontend/golden/pkg_score_page.html index a57490b8bf..c2da3cf53c 100644 --- a/app/test/frontend/golden/pkg_score_page.html +++ b/app/test/frontend/golden/pkg_score_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html index a57490b8bf..c2da3cf53c 100644 --- a/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html +++ b/app/test/frontend/golden/pkg_score_page_with_downloads_chart.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page.html b/app/test/frontend/golden/pkg_show_page.html index f57c69d33e..9c64cf9385 100644 --- a/app/test/frontend/golden/pkg_show_page.html +++ b/app/test/frontend/golden/pkg_show_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page_discontinued.html b/app/test/frontend/golden/pkg_show_page_discontinued.html index 6f72ac6b33..cdfbd6d1a9 100644 --- a/app/test/frontend/golden/pkg_show_page_discontinued.html +++ b/app/test/frontend/golden/pkg_show_page_discontinued.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html index 57feb55da9..3fdfa9dd14 100644 --- a/app/test/frontend/golden/pkg_show_page_flutter_plugin.html +++ b/app/test/frontend/golden/pkg_show_page_flutter_plugin.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page_publisher.html b/app/test/frontend/golden/pkg_show_page_publisher.html index a7863a02d3..c86f430a8b 100644 --- a/app/test/frontend/golden/pkg_show_page_publisher.html +++ b/app/test/frontend/golden/pkg_show_page_publisher.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page_retracted.html b/app/test/frontend/golden/pkg_show_page_retracted.html index b38cf0e003..858272d043 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted.html +++ b/app/test/frontend/golden/pkg_show_page_retracted.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html index 9f03092173..77dffb14f3 100644 --- a/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html +++ b/app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_show_version_page.html b/app/test/frontend/golden/pkg_show_version_page.html index b58f863e02..c9f81e6175 100644 --- a/app/test/frontend/golden/pkg_show_version_page.html +++ b/app/test/frontend/golden/pkg_show_version_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/pkg_versions_page.html b/app/test/frontend/golden/pkg_versions_page.html index 2b37612be2..11081ec54a 100644 --- a/app/test/frontend/golden/pkg_versions_page.html +++ b/app/test/frontend/golden/pkg_versions_page.html @@ -37,7 +37,7 @@
-
diff --git a/app/test/frontend/golden/publisher_activity_log_page.html b/app/test/frontend/golden/publisher_activity_log_page.html index d03023fb95..80794c0377 100644 --- a/app/test/frontend/golden/publisher_activity_log_page.html +++ b/app/test/frontend/golden/publisher_activity_log_page.html @@ -36,7 +36,7 @@
-
diff --git a/app/test/frontend/golden/publisher_admin_page.html b/app/test/frontend/golden/publisher_admin_page.html index 61890c04fa..8acd1d2683 100644 --- a/app/test/frontend/golden/publisher_admin_page.html +++ b/app/test/frontend/golden/publisher_admin_page.html @@ -36,7 +36,7 @@
-
diff --git a/app/test/frontend/golden/publisher_list_page.html b/app/test/frontend/golden/publisher_list_page.html index 7a2e1b07ce..a8f8ee7b36 100644 --- a/app/test/frontend/golden/publisher_list_page.html +++ b/app/test/frontend/golden/publisher_list_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/publisher_packages_page.html b/app/test/frontend/golden/publisher_packages_page.html index 8030aee89a..4adba17519 100644 --- a/app/test/frontend/golden/publisher_packages_page.html +++ b/app/test/frontend/golden/publisher_packages_page.html @@ -36,7 +36,7 @@
-
diff --git a/app/test/frontend/golden/publisher_unlisted_packages_page.html b/app/test/frontend/golden/publisher_unlisted_packages_page.html index f1f7861256..c1560d9954 100644 --- a/app/test/frontend/golden/publisher_unlisted_packages_page.html +++ b/app/test/frontend/golden/publisher_unlisted_packages_page.html @@ -36,7 +36,7 @@
-
diff --git a/app/test/frontend/golden/report_page.html b/app/test/frontend/golden/report_page.html index 201f8f8a52..2a073e2110 100644 --- a/app/test/frontend/golden/report_page.html +++ b/app/test/frontend/golden/report_page.html @@ -34,7 +34,7 @@
-
diff --git a/app/test/frontend/golden/report_page_appeal.html b/app/test/frontend/golden/report_page_appeal.html index 53e17a540e..d07e49d227 100644 --- a/app/test/frontend/golden/report_page_appeal.html +++ b/app/test/frontend/golden/report_page_appeal.html @@ -34,7 +34,7 @@
-
diff --git a/app/test/frontend/golden/search_page.html b/app/test/frontend/golden/search_page.html index 08ee83475e..39dcd62e68 100644 --- a/app/test/frontend/golden/search_page.html +++ b/app/test/frontend/golden/search_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/frontend/golden/topics_page.html b/app/test/frontend/golden/topics_page.html index f287db3d99..2b3d527a24 100644 --- a/app/test/frontend/golden/topics_page.html +++ b/app/test/frontend/golden/topics_page.html @@ -35,7 +35,7 @@
-
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html index 7d3e97dc31..d53fc8c0ad 100644 --- a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html +++ b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html @@ -24,7 +24,7 @@
menu