From bc7dabc68d46133267358459eee33bf279c91317 Mon Sep 17 00:00:00 2001 From: Todd Riley Date: Mon, 29 Sep 2025 14:17:38 -0400 Subject: [PATCH 1/2] Better table upper decorations. --- .../github/GitHubIssueAppendEnhancer.tsx | 16 +++++++++------- .../github/GitHubIssueCreateEnhancer.tsx | 17 ++++++++++++----- .../enhancers/github/GitHubPrAppendEnhancer.tsx | 16 +++++++++++++--- .../enhancers/github/GitHubPrCreateEnhancer.tsx | 17 ++++++++++++----- 4 files changed, 46 insertions(+), 20 deletions(-) diff --git a/src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx b/src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx index 9e2f0c2..bbb9d75 100644 --- a/src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx +++ b/src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx @@ -90,13 +90,15 @@ export class GitHubIssueAppendEnhancer - #{spot.number} - - {spot.slug} - + + #{spot.number} |{" "} + + {spot.slug} + + ) } diff --git a/src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx b/src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx index b9f11d3..e9307f8 100644 --- a/src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx +++ b/src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx @@ -1,3 +1,4 @@ +import { IssueOpenedIcon } from "@primer/octicons-react" import OverType, { type OverTypeInstance } from "overtype" import type { CommentEnhancer, @@ -74,13 +75,19 @@ export class GitHubIssueCreateEnhancer } tableUpperDecoration(spot: GitHubIssueCreateSpot): React.ReactNode { - const { slug } = spot return ( <> - New Issue - - {" "} - {slug}{" "} + + + + + New |{" "} + + {spot.slug} + ) diff --git a/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx b/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx index 1b6acc4..aff5118 100644 --- a/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx +++ b/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx @@ -1,3 +1,4 @@ +import { FeedPullRequestOpenIcon } from "@primer/octicons-react" import OverType, { type OverTypeInstance } from "overtype" import type React from "react" import type { @@ -83,11 +84,20 @@ export class GitHubPrAppendEnhancer } tableUpperDecoration(spot: GitHubPrAppendSpot): React.ReactNode { - const { slug, number } = spot return ( <> - {slug} - PR #{number} + + + + + #{spot.number} |{" "} + + {spot.slug} + + ) } diff --git a/src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx b/src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx index ef02a0c..6bc8ea5 100644 --- a/src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx +++ b/src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx @@ -1,3 +1,4 @@ +import { FeedPullRequestOpenIcon } from "@primer/octicons-react" import OverType, { type OverTypeInstance } from "overtype" import type { CommentEnhancer, @@ -89,13 +90,19 @@ export class GitHubPrCreateEnhancer } tableUpperDecoration(spot: GitHubPrCreateSpot): React.ReactNode { - const { slug } = spot return ( <> - New PR - - {" "} - {slug}{" "} + + + + + New |{" "} + + {spot.slug} + ) From db3fc266ebf6fc9e35648954844273305475dac9 Mon Sep 17 00:00:00 2001 From: Todd Riley Date: Mon, 29 Sep 2025 14:31:46 -0400 Subject: [PATCH 2/2] Snapshots. --- .../__snapshots__/gh-ui.test.ts.snap | 158 ++++++++++++------ 1 file changed, 104 insertions(+), 54 deletions(-) diff --git a/tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap b/tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap index 74331a9..656c5f3 100644 --- a/tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap +++ b/tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap @@ -13,14 +13,18 @@ exports[`github ui > gh_issue:should render correct UI elements 1`] = ` size={16} /> - # - 523 - - diffplug/selfie - + + # + 523 + | + + + diffplug/selfie + + , }, ] @@ -46,14 +50,18 @@ exports[`github ui > gh_issue_edit:should render correct UI elements 1`] = ` size={16} /> - # - 56 - - diffplug/gitcasso - + + # + 56 + | + + + diffplug/gitcasso + + , }, ] @@ -86,14 +94,18 @@ exports[`github ui > gh_issue_edit_multiple:should render correct UI elements 1` size={16} /> - # - 3 - - diffplug/testing-deletable - + + # + 3 + | + + + diffplug/testing-deletable + + , }, ] @@ -105,15 +117,22 @@ exports[`github ui > gh_issue_new:should render correct UI elements 1`] = ` "for": "id=:r34: name=null className=prc-Textarea-TextArea-13q4j focus-visible overtype-input", "title": "New issue title", "upperDecoration": - - New Issue - + + + + New | - diffplug/gitcasso - + + diffplug/gitcasso + , }, @@ -128,15 +147,23 @@ exports[`github ui > gh_pr:should render correct UI elements 1`] = ` #517", "upperDecoration": - diffplug/selfie + - - PR # + + # 517 + | + + + diffplug/selfie + , }, @@ -159,15 +186,23 @@ exports[`github ui > gh_pr_edit:should render correct UI elements 1`] = ` #58", "upperDecoration": - diffplug/gitcasso + - - PR # + + # 58 + | + + + diffplug/gitcasso + , }, @@ -196,15 +231,23 @@ exports[`github ui > gh_pr_edit_multiple:should render correct UI elements 1`] = #5", "upperDecoration": - diffplug/testing-deletable + - - PR # + + # 5 + | + + + diffplug/testing-deletable + , }, @@ -217,15 +260,22 @@ exports[`github ui > gh_pr_new:should render correct UI elements 1`] = ` "for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input", "title": "Update README.md", "upperDecoration": - - New PR - + + + + New | - diffplug/selfie - + + diffplug/selfie + , },