From 9d7a2d07015af1c94d814a10fb2dc8248e459a65 Mon Sep 17 00:00:00 2001 From: Mark Peace Date: Tue, 8 Mar 2016 16:49:43 +0000 Subject: [PATCH] Remove references to webadmin --- RepositoryOverview.asciidoc | 3 +- community/.gitignore | 3 - community/server/pom.xml | 4 - .../org/neo4j/server/AbstractNeoServer.java | 10 +- .../rest/discovery/DiscoveryService.java | 4 +- .../neo4j/server/rest/domain/HtmlHelper.java | 2 - .../org/neo4j/server/ServerConfigDocIT.java | 18 +- .../helpers/CommunityServerBuilder.java | 24 +- .../CypherSessionDocTest.java | 6 +- .../org/neo4j/server/rest/JaxRsResponse.java | 29 ++ .../neo4j/server/rest/JmxServiceDocIT.java | 6 +- .../neo4j/server/rest/ManageNodeDocIT.java | 391 +++++++++++++++++- .../neo4j/server/rest/RedirectorDocIT.java | 4 +- .../rest/dbms/AuthorizationFilterTest.java | 17 +- .../auth/AuthorizationWhitelistIT.java | 4 +- ...ommunityVersionAndEditionServiceDocIT.java | 129 ------ ...nfigureEnabledManagementConsolesDocIT.java | 71 ---- .../webadmin/rest/ConsoleServiceDocTest.java | 93 ----- .../webadmin/rest/JmxServiceDocTest.java | 76 ---- .../rest/Neo4jShellConsoleSessionDocTest.java | 119 ------ .../webadmin/rest/RootServiceDocTest.java | 68 --- .../rest/VersionAndEditionServiceTest.java | 58 --- .../ServerRootRepresentationTest.java | 54 --- .../enterprise/EnterpriseNeoServer.java | 4 +- ...seAvailabilityDiscoveryRepresentation.java | 2 +- .../rest/CoreDatabaseAvailabilityService.java | 2 +- .../rest/DatabaseRoleInfoServerModule.java | 2 +- .../rest/HaDiscoveryRepresentation.java | 2 +- .../rest/MasterInfoService.java | 2 +- .../StandaloneHaInfoFunctionalTest.java | 6 +- .../EnterpriseVersionAndEditionServiceIT.java | 2 +- .../rest/MasterInfoServiceTest.java | 2 +- manual/contents/src/tools/index.asciidoc | 4 - manual/contents/src/tools/webadmin.asciidoc | 10 - .../src/docs/dev/tutorials/cypher.asciidoc | 4 +- packaging/standalone/document.properties | 2 - packaging/standalone/pom.xml | 2 +- 37 files changed, 480 insertions(+), 759 deletions(-) rename community/server/src/test/java/org/neo4j/server/{webadmin/console => rest}/CypherSessionDocTest.java (98%) delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/CommunityVersionAndEditionServiceDocIT.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/ConfigureEnabledManagementConsolesDocIT.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/ConsoleServiceDocTest.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/JmxServiceDocTest.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/Neo4jShellConsoleSessionDocTest.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/RootServiceDocTest.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/VersionAndEditionServiceTest.java delete mode 100644 community/server/src/test/java/org/neo4j/server/webadmin/rest/representations/ServerRootRepresentationTest.java rename enterprise/server-enterprise/src/main/java/org/neo4j/server/{webadmin => }/rest/CoreDatabaseAvailabilityDiscoveryRepresentation.java (97%) rename enterprise/server-enterprise/src/main/java/org/neo4j/server/{webadmin => }/rest/CoreDatabaseAvailabilityService.java (98%) rename enterprise/server-enterprise/src/main/java/org/neo4j/server/{webadmin => }/rest/DatabaseRoleInfoServerModule.java (98%) rename enterprise/server-enterprise/src/main/java/org/neo4j/server/{webadmin => }/rest/HaDiscoveryRepresentation.java (97%) rename enterprise/server-enterprise/src/main/java/org/neo4j/server/{webadmin => }/rest/MasterInfoService.java (99%) rename enterprise/server-enterprise/src/test/java/org/neo4j/server/{webadmin => }/rest/EnterpriseVersionAndEditionServiceIT.java (98%) rename enterprise/server-enterprise/src/test/java/org/neo4j/server/{webadmin => }/rest/MasterInfoServiceTest.java (99%) delete mode 100644 manual/contents/src/tools/webadmin.asciidoc diff --git a/RepositoryOverview.asciidoc b/RepositoryOverview.asciidoc index a9d260354ddeb..be87187286da3 100644 --- a/RepositoryOverview.asciidoc +++ b/RepositoryOverview.asciidoc @@ -110,8 +110,7 @@ neo4j-lucene-index:: neo4j-server:: The community version of http://neo4j.com/docs/milestone/reference-documentation.html[the Neo4j server]. - It contains the functionality of the http://neo4j.com/docs/milestone/rest-api.html[REST API] - and http://neo4j.com/docs/milestone/tools-webadmin.html[the WebAdmin tool]. + It contains the functionality of the http://neo4j.com/docs/milestone/rest-api.html[REST API]. neo4j-community:: The neo4j-community module is a historical alias for the neo4j module. diff --git a/community/.gitignore b/community/.gitignore index 3f202068ed597..d064be374bce8 100644 --- a/community/.gitignore +++ b/community/.gitignore @@ -18,9 +18,6 @@ target cypher/project cypher/lib_managed cypher/.cache -server/src/main/resources/webadmin-html/js/neo4j/ -server/src/main/resources/webadmin-html/js/ribcage/ -server/src/main/resources/webadmin-html/js/webadmin.js artifacts */bin */pom-with-build-number.xml diff --git a/community/server/pom.xml b/community/server/pom.xml index c9d6af8bd3f49..d45d16442df88 100644 --- a/community/server/pom.xml +++ b/community/server/pom.xml @@ -502,10 +502,6 @@ Server REST Interface org.neo4j.server.rest:org.neo4j.server.rest.* - - Server Admin Interface - org.neo4j.server.webadmin:org.neo4j.server.webadmin.* - diff --git a/community/server/src/main/java/org/neo4j/server/AbstractNeoServer.java b/community/server/src/main/java/org/neo4j/server/AbstractNeoServer.java index 4ea7d93c0ed04..4dec94599fbfc 100644 --- a/community/server/src/main/java/org/neo4j/server/AbstractNeoServer.java +++ b/community/server/src/main/java/org/neo4j/server/AbstractNeoServer.java @@ -19,10 +19,6 @@ */ package org.neo4j.server; -import com.sun.jersey.api.core.HttpContext; -import org.apache.commons.configuration.Configuration; -import org.bouncycastle.operator.OperatorCreationException; - import java.io.File; import java.io.IOException; import java.net.URI; @@ -36,6 +32,10 @@ import java.util.regex.Pattern; import javax.servlet.Filter; +import com.sun.jersey.api.core.HttpContext; +import org.apache.commons.configuration.Configuration; +import org.bouncycastle.operator.OperatorCreationException; + import org.neo4j.bolt.security.ssl.Certificates; import org.neo4j.bolt.security.ssl.KeyStoreFactory; import org.neo4j.bolt.security.ssl.KeyStoreInformation; @@ -85,6 +85,7 @@ import static java.lang.Math.round; import static java.lang.String.format; import static java.util.concurrent.TimeUnit.MILLISECONDS; + import static org.neo4j.helpers.Clock.SYSTEM_CLOCK; import static org.neo4j.helpers.collection.Iterables.map; import static org.neo4j.kernel.impl.util.JobScheduler.Groups.serverTransactionTimeout; @@ -105,7 +106,6 @@ public abstract class AbstractNeoServer implements NeoServer private static final Pattern[] DEFAULT_URI_WHITELIST = new Pattern[]{ Pattern.compile( "/browser.*" ), - Pattern.compile( "/webadmin.*" ), Pattern.compile( "/" ) }; diff --git a/community/server/src/main/java/org/neo4j/server/rest/discovery/DiscoveryService.java b/community/server/src/main/java/org/neo4j/server/rest/discovery/DiscoveryService.java index 074fcd7b5aeef..7e6158fd97500 100644 --- a/community/server/src/main/java/org/neo4j/server/rest/discovery/DiscoveryService.java +++ b/community/server/src/main/java/org/neo4j/server/rest/discovery/DiscoveryService.java @@ -53,10 +53,10 @@ public DiscoveryService( @Context Config configuration, @Context OutputFormat ou @Produces( MediaType.APPLICATION_JSON ) public Response getDiscoveryDocument() throws URISyntaxException { - String webAdminManagementUri = configuration.get( ServerSettings.management_api_path ).getPath() + "/"; + String managementUri = configuration.get( ServerSettings.management_api_path ).getPath() + "/"; String dataUri = configuration.get( ServerSettings.rest_api_path ).getPath() + "/"; - return outputFormat.ok( new DiscoveryRepresentation( webAdminManagementUri, dataUri ) ); + return outputFormat.ok( new DiscoveryRepresentation( managementUri, dataUri ) ); } @GET diff --git a/community/server/src/main/java/org/neo4j/server/rest/domain/HtmlHelper.java b/community/server/src/main/java/org/neo4j/server/rest/domain/HtmlHelper.java index 571a8afc0c677..561c069293524 100644 --- a/community/server/src/main/java/org/neo4j/server/rest/domain/HtmlHelper.java +++ b/community/server/src/main/java/org/neo4j/server/rest/domain/HtmlHelper.java @@ -28,7 +28,6 @@ public class HtmlHelper { private final static String STYLE_LOCATION = "http://resthtml.neo4j.org/style/"; - private final static String HTML_JAVASCRIPT_LOCATION = "/webadmin/htmlbrowse.js"; public static String from( final Object object, final ObjectType objectType ) { @@ -53,7 +52,6 @@ public static StringBuilder start( final String title, final String additionalCo } builder.append( "\n" + "\n" - + "\n" + "\n\n" + "
" + "