Convert JS to TS#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Convert the project’s JavaScript files to TypeScript, update configuration, and add typings across the renderer and main processes.
- Remove legacy
.jsconfigs and introduce.tsequivalents (Vite, tsconfig). - Add
defineProps/defineEmitsgenerics and explicit return types to all Vue components. - Include new test coverage configuration and add unit tests for formatter and category-color utilities.
Reviewed Changes
Copilot reviewed 31 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Replaced JS config with TS, added test settings |
| src/renderer/tsconfig.json | Introduced TypeScript compiler options |
| src/renderer/utils | Converted formatters and category-colors to TS |
| src/renderer/types | Added developer-cleaner and common type definitions |
| src/renderer/components/**/*.vue | Added <script setup lang="ts"> and types |
| src/renderer/components/**/tests | Added tests for formatters and categoryColors |
| package.json / workflows / sonar files | Updated build scripts, test workflows, coverage settings |
Comments suppressed due to low confidence (1)
src/renderer/components/DeveloperCleaner/ResultsTable.vue:114
- [nitpick] Returning an empty string for invalid dates may lead to blank UI. Consider returning a placeholder like "Unknown" or "Invalid Date" to provide clearer feedback.
if (isNaN(date.getTime())) return ''
| "@/*": ["./*"] | ||
| } | ||
| }, | ||
| "include": ["**/*.ts", "**/*.d.ts", "**/*.vue", "../types/**/*.d.ts"], |
There was a problem hiding this comment.
The include path "../types/**/*.d.ts" points outside the src/renderer directory and may not match your actual type definitions. Consider updating or removing it to ensure all TS files and declaration files within src/renderer are recognized correctly.
Suggested change
| "include": ["**/*.ts", "**/*.d.ts", "**/*.vue", "../types/**/*.d.ts"], | |
| "include": ["**/*.ts", "**/*.d.ts", "**/*.vue"], |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.