CompatHelper: add new compat entry for "CEnum" at version "0.4"#10
Merged
maleadt merged 1 commit intoAug 23, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 57.19% 57.19%
=======================================
Files 33 33
Lines 834 834
=======================================
Hits 477 477
Misses 357 357 Continue to review full report at Codecov.
|
maleadt
deleted the
compathelper/new_version/2020-08-23-00-19-13-839-2873217908
branch
michel2323
added a commit
that referenced
this pull request
Jul 8, 2026
Setting ENV["LD_LIBRARY_PATH"] inside __init__ cannot affect the running
process's dlopen search paths: glibc captures LD_LIBRARY_PATH once at process
startup, so the stated purpose (letting libsycl's bundled ze_lib find NEO's
libze_intel_gpu in-process) was never served for the current process — only for
child processes that inherit the environment.
dlopen the NEO driver by full path in __init__ so it is resident before libsycl
loads; a later dlopen("libze_intel_gpu.so.1") by libsycl's bundled loader then
resolves to it by soname without a path search. Keep extending LD_LIBRARY_PATH
but correct the comment to say it only covers spawned worker processes. Verified
oneMKL (which loads libsycl and needs NEO discovery) still works.
Addresses PR_REVIEW.md finding #10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request sets the compat entry for the
CEnumpackage to0.4.This is a brand new compat entry. Previously, you did not have a compat entry for the
CEnumpackage.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Note: Consider tagging a patch release immediately after merging this PR, as downstream packages may depend on this for tests to pass.