Skip to content

Fixed YML Clean Up & Chest Broken First Error#2

Merged
Orelii merged 1 commit into
Orelii:masterfrom
ItsOgge:ChestShopExtras-Fix
Jan 25, 2026
Merged

Fixed YML Clean Up & Chest Broken First Error#2
Orelii merged 1 commit into
Orelii:masterfrom
ItsOgge:ChestShopExtras-Fix

Conversation

@ItsOgge

@ItsOgge ItsOgge commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Fixed YML Clean UP:
When a shop is broken it leaves this:

Location{world=CraftWorld{name=world},x=0:
0,y=72:
0,z=10:
0,pitch=0:
0,yaw=0: {}

In the shops.yml, well no more with this new code!
Now it creates this ";;;;;: <owner_uuid>"
And all of that gets deleted when the shop is broken.

Chest Broken First Error:
If you break the shop chest -> and then the sign fall off.
It spits a error at you:

"[22:02:43 ERROR]: Could not pass event ShopDestroyedEvent to ChestShopExtras v1.1.0 java.lang.NullPointerException: Cannot invoke "org.bukkit.block.Container.getLocation()" because the return value of "com.Acrobot.ChestShop.Events.ShopDestroyedEvent.getContainer()" is null"

But now the data is stored as the sign (instead of the chest), and now it works PERFECTLY!
I hope you see this and accept the Pull Request! Thanks!

NOTE:
I also updated the version in the files to 1.1.1

@Orelii

Orelii commented Jan 25, 2026

Copy link
Copy Markdown
Owner

damn, i didn't think anyone still used this plugin lol
thanks a lot for fixing it

@Orelii Orelii merged commit 88d9c70 into Orelii:master Jan 25, 2026
@ItsOgge

ItsOgge commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

I was just looking around for a plugin that could combine my GriefPrevention, and my ChestShop. This is a life saver plugin for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants