Fixed YML Clean Up & Chest Broken First Error#2
Merged
Conversation
Owner
|
damn, i didn't think anyone still used this plugin lol |
Contributor
Author
|
I was just looking around for a plugin that could combine my GriefPrevention, and my ChestShop. This is a life saver plugin for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed YML Clean UP:
When a shop is broken it leaves this:
Location{world=CraftWorld{name=world},x=0:
0,y=72:
0,z=10:
0,pitch=0:
0,yaw=0: {}
In the shops.yml, well no more with this new code!
Now it creates this ";;;;;: <owner_uuid>"
And all of that gets deleted when the shop is broken.
Chest Broken First Error:
If you break the shop chest -> and then the sign fall off.
It spits a error at you:
"[22:02:43 ERROR]: Could not pass event ShopDestroyedEvent to ChestShopExtras v1.1.0 java.lang.NullPointerException: Cannot invoke "org.bukkit.block.Container.getLocation()" because the return value of "com.Acrobot.ChestShop.Events.ShopDestroyedEvent.getContainer()" is null"
But now the data is stored as the sign (instead of the chest), and now it works PERFECTLY!
I hope you see this and accept the Pull Request! Thanks!
NOTE:
I also updated the version in the files to 1.1.1