Fix aperture pixel <-> sky conversions for edge cases#2286
Merged
Conversation
larrybradley
force-pushed
the
fix-wcs-sky-pixel
branch
from
2d539e4 to
8c8a51d
Compare
larrybradley
force-pushed
the
fix-wcs-sky-pixel
branch
from
8c8a51d to
5738d23
Compare
larrybradley
force-pushed
the
fix-wcs-sky-pixel
branch
from
5738d23 to
4a10d1d
Compare
larrybradley
force-pushed
the
fix-wcs-sky-pixel
branch
from
4a10d1d to
a9be082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two related fixes to the WCS-based aperture
to_skyandto_pixelconversion helpers:to_skyandto_pixelmethods so that it is well-conditioned at the celestial poles and across the RA = 0/360 degree wraparound.RectangularAperture,RectangularAnnulus, and their sky counterparts to use the SVD-based ellipseto_skyandto_pixelconversions so that they round-trip correctly with a sheared WCS.