Handle undefined and ambiguous without throwing#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The
prepare()method used to throw an error if the step was undefined (no matching definitions) or ambiguous (> 1 matching definitions). This originated from https://github.com/cucumber/cucumber-node where we have to have such steps bubble up as an error for the test runner, but otherwise it means we're using exceptions for control flow which is better avoided.This PR changes the behaviour so that we return an object for an undefined or ambiguous step. The consumer can then handle that as desired, including by throwing - the error classes are still here and have been recast to accept those return objects as their input, for convenience - or whatever else.
Also,
UndefinedErroroptionally accepts a list of snippets too, so those can be included in the user-facing error message once the consuming implementation has written them.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.