Skip to content

Fix #277: type readTreeOids mock contract#595

Merged
flyingrobots merged 2 commits into
mainfrom
fix-277-read-tree-oids-mock-contract
Jun 3, 2026
Merged

Fix #277: type readTreeOids mock contract#595
flyingrobots merged 2 commits into
mainfrom
fix-277-read-tree-oids-mock-contract

Conversation

@flyingrobots

Copy link
Copy Markdown
Member

Summary

  • type shared mock readTreeOids helpers as Promise<Record<string, string>>
  • default both mock persistence factories to async object-map implementations
  • add focused tests that compile against and assert the object-map contract

Closes #277

Validation

  • npm exec vitest run test/unit/helpers/mockPorts.test.ts test/unit/helpers/WarpGraphMockPersistence.test.ts
  • npm run typecheck:test
  • pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 56 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2bab9892-8447-47ff-a019-2582e886d5e8

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and d8bc17b.

📒 Files selected for processing (4)
  • test/helpers/WarpGraphMockPersistence.ts
  • test/helpers/mockPorts.ts
  • test/unit/helpers/WarpGraphMockPersistence.test.ts
  • test/unit/helpers/mockPorts.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-277-read-tree-oids-mock-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Findings

@codex please confirm this review posture.

Severity File Lines Type Issue Recommended mitigation prompt
P5 Nit test/unit/helpers/WarpGraphMockPersistence.test.ts, test/unit/helpers/mockPorts.test.ts test title Contract wording The new test titles describe readTreeOids as a “tree path” contract, but the helper type and port argument are treeOid. This is a tiny wording drift in the proof text. Rename the affected test titles from “tree path to object-map contract” to “tree object id to object-map contract”, then rerun the focused helper tests and typecheck:test.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Activity Summary

@codex please confirm this closure.

Source Severity File Lines Issue Commit Outcome
Self P5 Nit test/unit/helpers/WarpGraphMockPersistence.test.ts, test/unit/helpers/mockPorts.test.ts test title Proof text called the readTreeOids(treeOid) contract a “tree path” contract. d8bc17bd Renamed both test titles to “tree object id to object-map contract”.

Validation:

  • npm exec vitest run test/unit/helpers/WarpGraphMockPersistence.test.ts test/unit/helpers/mockPorts.test.ts
  • npm run typecheck:test
  • git diff --check
  • WARP_QUICK_PUSH=1 git push static pre-push gates 0-7 passed; unit gate intentionally skipped by quick mode.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots flyingrobots merged commit 7e21b7d into main Jun 3, 2026
17 checks passed
@flyingrobots flyingrobots deleted the fix-277-read-tree-oids-mock-contract branch June 3, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readTreeOids mocks returned [] instead of {} (type contract violation)

1 participant