Fix #382: remove incremental props rewrap branch

[flyingrobots]

Summary

• remove the unreachable _handleProps() prop-bag rewrap branch
• add a codec-boundary regression test proving loaded legacy prop bags are normalized before save-time mutation
• preserve the existing proto-pollution safety coverage

Closes #382

Validation

• npm exec vitest run test/unit/domain/services/IncrementalIndexUpdater.test.ts
• npm run typecheck:test
• pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

[coderabbitai]

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1876177-a665-4061-ac0b-69b7dbbd02b7

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and f35400e.

📒 Files selected for processing (2)

• src/domain/services/index/IncrementalIndexUpdater.ts
• test/unit/domain/services/IncrementalIndexUpdater.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-382-incremental-props-invariant

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

[flyingrobots]

Code Lawyer Findings

@codex please confirm this review posture.

Severity	File	Lines	Type	Issue	Recommended mitigation prompt
P3 Medium	test/unit/domain/services/IncrementalIndexUpdater.test.ts	L72-L76, L726-L731	Type-policy/style	The new regression proof introduced unknown, Record<string, unknown>, and dedicated shape-trust helpers in a domain-service test. The file has legacy casts, but this PR should not add more boundary-leaking helper code.	Remove the new isRecord / isPropEntry helpers and capture encoded prop bags with simple runtime checks inside the local codec without adding explicit unknown or Record<string, unknown> annotations.

[flyingrobots]

Code Lawyer Activity Summary

@codex please confirm this closure.

Source	Severity	File	Lines	Issue	Commit	Outcome
Self	P3 Medium	test/unit/domain/services/IncrementalIndexUpdater.test.ts	L72-L76, L726-L731	New regression proof added explicit unknown / Record<string, unknown> shape helpers in a domain-service test.	f35400ec	Removed the helper functions and captured encoded prop bags with local runtime checks, preserving the null-prototype proof.

Validation:

• RED static check: rg -n "function isRecord|function isPropEntry|capturedPropBags: Array<Record<string, unknown>>" test/unit/domain/services/IncrementalIndexUpdater.test.ts
• GREEN static check: ! rg -n "function isRecord|function isPropEntry|capturedPropBags: Array<Record<string, unknown>>" test/unit/domain/services/IncrementalIndexUpdater.test.ts
• npm exec vitest run test/unit/domain/services/IncrementalIndexUpdater.test.ts
• npm run typecheck:test
• npm run lint -- test/unit/domain/services/IncrementalIndexUpdater.test.ts
• git diff --check
• WARP_QUICK_PUSH=1 git push static pre-push gates 0-7 passed; unit gate intentionally skipped by quick mode.

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.