Skip to content

Fix #312: structure non-TS tail assertions#597

Merged
flyingrobots merged 2 commits into
mainfrom
fix-312-non-ts-tail-structured
Jun 3, 2026
Merged

Fix #312: structure non-TS tail assertions#597
flyingrobots merged 2 commits into
mainfrom
fix-312-non-ts-tail-structured

Conversation

@flyingrobots

Copy link
Copy Markdown
Member

Summary

  • replace raw package/jsr/tsconfig/vitest source-text assertions with structured imports and config-module inspection
  • keep the tracked non-TypeScript tail inventory as the repository file proof
  • preserve the sha1sync export and stale .js glob guardrails without scanning config text

Closes #312

Validation

  • npm exec vitest run test/unit/scripts/non-ts-tail-shape.test.ts
  • npm run typecheck:test
  • pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3c7a0b4f-c282-4b10-8091-cb2594a554fe

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and 1b3ce66.

📒 Files selected for processing (1)
  • test/unit/scripts/non-ts-tail-shape.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-312-non-ts-tail-structured

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Findings

@codex please confirm this review posture.

Severity File Lines Type Issue Recommended mitigation prompt
P3 Medium test/unit/scripts/non-ts-tail-shape.test.ts L61-L72 Test coverage regression The rewrite removed the previous assertion that vitest.config.ts remains wired to scripts/coverage-ratchet.ts. The new structured assertions cover the include globs but not the coverage-ratchet hook that the old text assertion protected. Add a structured assertion that vitestConfig.test.coverage.thresholds.autoUpdate matches shouldAutoUpdateCoverageRatchet(), and prove the ratchet helper returns true only for the explicit update env flag.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Activity Summary

@codex please confirm this closure.

Source Severity File Lines Issue Commit Outcome
Self P3 Medium test/unit/scripts/non-ts-tail-shape.test.ts L61-L72 Structured assertion rewrite dropped the previous coverage-ratchet hook witness. 1b3ce66f Added a structured assertion that the Vitest threshold autoUpdate value matches shouldAutoUpdateCoverageRatchet(), plus direct helper truth-table checks.

Validation:

  • npm exec vitest run test/unit/scripts/non-ts-tail-shape.test.ts
  • npm run typecheck:test
  • npm run lint -- test/unit/scripts/non-ts-tail-shape.test.ts
  • git diff --check
  • WARP_QUICK_PUSH=1 git push static pre-push gates 0-7 passed; unit gate intentionally skipped by quick mode.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots flyingrobots merged commit e2191b3 into main Jun 3, 2026
17 checks passed
@flyingrobots flyingrobots deleted the fix-312-non-ts-tail-structured branch June 3, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static text assertions in test/unit/scripts/non-ts-tail-shape.test.ts

1 participant