Fix #267: prove GC failure handling

[flyingrobots]

Summary

• log caught auto-GC failures instead of silently swallowing them
• make the GC failure test prove the failure was caught and reported
• replace the no-logger no-crash assertion with a no-logger enabled-GC execution proof

Closes #267

Validation

• npm exec vitest run test/unit/domain/WarpGraph.autoGC.test.ts
• npm run typecheck:src
• npm run typecheck:test
• pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

[coderabbitai]

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffdb4e58-69c6-4b03-b3ea-3dbe19b82474

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and b9d75f8.

📒 Files selected for processing (2)

• src/domain/services/controllers/CheckpointController.ts
• test/unit/domain/WarpGraph.autoGC.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-267-gc-error-proof

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

[flyingrobots]

Code Lawyer Findings

@codex please confirm this review posture.

Severity	File	Lines	Type	Issue	Recommended mitigation prompt
P2 Major	src/domain/services/controllers/CheckpointController.ts, test/unit/domain/WarpGraph.autoGC.test.ts	controller catch / GC failure test	Error-handling invariant	The new warning uses String(err) for non-Error thrown values. String(Object.create(null)) throws, so an unusual GC failure can still break materialize inside the catch. The touched test also keeps an as any malformed-state setup.	Add a regression where GC metric collection throws a null-prototype value and _maybeRunGC still does not throw; make the warning payload derive a total error label without stringifying objects/functions; replace the malformed-state as any with a real state whose properties are overridden via Object.defineProperty.

[flyingrobots]

Code Lawyer Activity Summary

@codex please confirm this closure.

Source	Severity	File	Lines	Issue	Commit	Outcome
Self	P2 Major	src/domain/services/controllers/CheckpointController.ts, test/unit/domain/WarpGraph.autoGC.test.ts	controller catch / GC failure test	Auto-GC catch stringified non-Error thrown values with String(err), which can throw for null-prototype objects; touched test also kept an as any malformed-state setup.	b9d75f84	Added a RED/GREEN null-prototype thrown-value regression, made the error label total for object/function throws, and replaced the malformed-state as any with property overrides on a real state.

Validation:

• RED: npm exec vitest run test/unit/domain/WarpGraph.autoGC.test.ts failed because String(Object.create(null)) threw inside the catch.
• GREEN: npm exec vitest run test/unit/domain/WarpGraph.autoGC.test.ts
• npm run typecheck:src && npm run typecheck:test
• npm run lint -- src/domain/services/controllers/CheckpointController.ts test/unit/domain/WarpGraph.autoGC.test.ts
• git diff --check
• WARP_QUICK_PUSH=1 git push static pre-push gates 0-7 passed; unit gate intentionally skipped by quick mode.

[github-actions]

Release Preflight

• package version: 18.0.0
• prerelease: false
• npm dist-tag on release: latest
• npm pack dry-run: passed
• jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.