Skip to content

Fix PR duplicate check role gating#2241

Merged
aaronpowell merged 1 commit into
github:mainfrom
jamesmontemagno:motz-fix-pr-duplicate-check
Jul 8, 2026
Merged

Fix PR duplicate check role gating#2241
aaronpowell merged 1 commit into
github:mainfrom
jamesmontemagno:motz-fix-pr-duplicate-check

Conversation

@jamesmontemagno

Copy link
Copy Markdown
Contributor

Summary

  • remove the roles: all override from the PR duplicate check workflow
  • regenerate the gh-aw lock file so read-only actors are gated in pre-activation before PR checkout runs

Validation

  • gh aw compile pr-duplicate-check --strict
  • npm run build
  • bash eng/fix-line-endings.sh
  • git diff --check

Remove the read-only role override from the PR duplicate check so gh-aw pre-activation gates unsupported actors before the PR checkout step runs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 01:20
@github-actions github-actions Bot added the workflow PR touches workflow automation label Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the PR Duplicate Check agentic workflow configuration so that role gating is enforced via the generated pre-activation logic (instead of an explicit roles: all override), preventing read-only/untrusted actors from reaching the checkout/agent execution phases.

Changes:

  • Removed the roles: all override from the source workflow (pr-duplicate-check.md).
  • Regenerated the compiled pr-duplicate-check.lock.yml, introducing a pre_activation job and gating the activation job on its activated output (plus propagating trace context).
Show a summary per file
File Description
.github/workflows/pr-duplicate-check.md Removes the explicit roles: all override so default role gating behavior applies.
.github/workflows/pr-duplicate-check.lock.yml Updates the compiled workflow to run a pre_activation membership check and only proceed to activation/checkout when authorized.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Low

@aaronpowell aaronpowell merged commit 34f0e35 into github:main Jul 8, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow PR touches workflow automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants