fix: some utopia comment and remove some unwrap#1936
Merged
Conversation
Signed-off-by: Wangyan <topshihun@foxmail.com>
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5bcae6fe4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several Orion Server v2 API endpoints’ Utoipa annotations and response wiring, aiming to improve OpenAPI accuracy/consistency and remove some manual JSON serialization/unwrap() usage.
Changes:
- Fixes/clarifies some Utoipa path metadata (leading
/, improved descriptions, corrected path param naming in handler signature). - Switches several placeholder handlers to return
Json(MessageResponse)instead ofserde_json::to_string(...).unwrap(). - Adjusts
task_retry_handlerto return501 Not Implemented(but OpenAPI responses still document 200/400/404).
Signed-off-by: Wangyan <topshihun@foxmail.com>
benjamin-747
approved these changes
Feb 13, 2026
Collaborator
|
link #1852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.