Sourcery refactored main branch#1
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if isinstance(vec[0], ValType): | ||
| return vec | ||
| return [t for name,t in vec] | ||
| return vec if isinstance(vec[0], ValType) else [t for name,t in vec] |
Author
There was a problem hiding this comment.
Function FuncType.extract_types refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-226
to
+224
| if n <= 16: return 2 | ||
| return 4 | ||
| return 2 if n <= 16 else 4 |
Author
There was a problem hiding this comment.
Function alignment_flags refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-272
to
+269
| if n <= 16: return 2 | ||
| return 4 * num_i32_flags(labels) | ||
| return 2 if n <= 16 else 4 * num_i32_flags(labels) |
Author
There was a problem hiding this comment.
Function size_flags refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-371
to
+367
| self.rt_to_table = dict() | ||
| self.rt_to_table = {} |
Author
There was a problem hiding this comment.
Function HandleTables.__init__ refactored with the following changes:
- Replace
dict()with{}(dict-literal)
Comment on lines
-428
to
+424
| if math.isnan(f): | ||
| return reinterpret_i32_as_float(CANONICAL_FLOAT32_NAN) | ||
| return f | ||
| return reinterpret_i32_as_float(CANONICAL_FLOAT32_NAN) if math.isnan(f) else f |
Author
There was a problem hiding this comment.
Function canonicalize32 refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-894
to
+881
| i = vi.next('i' + str(core_width)) | ||
| i = vi.next(f'i{str(core_width)}') |
Author
There was a problem hiding this comment.
Function lift_flat_unsigned refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-899
to
+889
| i = vi.next('i' + str(core_width)) | ||
| i = vi.next(f'i{str(core_width)}') | ||
| assert(0 <= i < (1 << core_width)) | ||
| i %= (1 << t_width) | ||
| if i >= (1 << (t_width - 1)): | ||
| return i - (1 << t_width) | ||
| return i | ||
| return i - (1 << t_width) if i >= (1 << (t_width - 1)) else i |
Author
There was a problem hiding this comment.
Function lift_flat_signed refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-917
to
+902
| record = {} | ||
| for f in fields: | ||
| record[f.label] = lift_flat(cx, vi, f.t) | ||
| return record | ||
| return {f.label: lift_flat(cx, vi, f.t) for f in fields} |
Author
There was a problem hiding this comment.
Function lift_flat_record refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-938
to
+920
| if c.t is None: | ||
| v = None | ||
| else: | ||
| v = lift_flat(cx, CoerceValueIter(), c.t) | ||
| v = None if c.t is None else lift_flat(cx, CoerceValueIter(), c.t) |
Author
There was a problem hiding this comment.
Function lift_flat_variant refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-985
to
+964
| return [Value('i' + str(core_bits), i)] | ||
| return [Value(f'i{str(core_bits)}', i)] |
Author
There was a problem hiding this comment.
Function lower_flat_signed refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-1006
to
+985
| if c.t is None: | ||
| payload = [] | ||
| else: | ||
| payload = lower_flat(cx, case_value, c.t) | ||
| payload = [] if c.t is None else lower_flat(cx, case_value, c.t) |
Author
There was a problem hiding this comment.
Function lower_flat_variant refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1035
to
+1017
| if len(flat_types) > max_flat: | ||
| ptr = vi.next('i32') | ||
| tuple_type = Tuple(ts) | ||
| trap_if(ptr != align_to(ptr, alignment(tuple_type))) | ||
| trap_if(ptr + size(tuple_type) > len(cx.opts.memory)) | ||
| return list(load(cx, ptr, tuple_type).values()) | ||
| else: | ||
| if len(flat_types) <= max_flat: | ||
| return [ lift_flat(cx, vi, t) for t in ts ] | ||
| ptr = vi.next('i32') | ||
| tuple_type = Tuple(ts) | ||
| trap_if(ptr != align_to(ptr, alignment(tuple_type))) | ||
| trap_if(ptr + size(tuple_type) > len(cx.opts.memory)) | ||
| return list(load(cx, ptr, tuple_type).values()) |
Author
There was a problem hiding this comment.
Function lift_values refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
| self.last_alloc = ret + new_size | ||
| if self.last_alloc > len(self.memory): | ||
| print('oom: have {} need {}'.format(len(self.memory), self.last_alloc)) | ||
| print(f'oom: have {len(self.memory)} need {self.last_alloc}') |
Author
There was a problem hiding this comment.
Function Heap.realloc refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| elif src_encoding == 'utf16': | ||
| encoded = s.encode('utf-16-le') | ||
| tagged_code_units = int(len(encoded) / 2) | ||
| tagged_code_units = len(encoded) // 2 |
Author
There was a problem hiding this comment.
Function test_string refactored with the following changes:
- Simplify division expressions [×2] (
simplify-division)
|
|
||
| if got != v: | ||
| fail("test_roundtrip({},{},{}) got {}".format(t, v, caller_args, got)) | ||
| fail(f"test_roundtrip({t},{v},{caller_args}) got {got}") |
Author
There was a problem hiding this comment.
Function test_roundtrip refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!