TimedRotatingFileHandler doesn’t handle DST switch with daily rollover

[snoopyjc]

BPO	39661
Nosy	@vsajip, @snoopyjc

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-02-17.20:38:41.191>
created_at = <Date 2020-02-17.13:26:48.360>
labels = ['3.7', 'type-bug', 'library']
title = 'TimedRotatingFileHandler doesn\xe2\x80\x99t handle DST switch with daily rollover'
updated_at = <Date 2020-02-17.20:38:41.189>
user = 'https://github.com/snoopyjc'

bugs.python.org fields:

activity = <Date 2020-02-17.20:38:41.189>
actor = 'snoopyjc'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-17.20:38:41.191>
closer = 'snoopyjc'
components = ['Library (Lib)']
creation = <Date 2020-02-17.13:26:48.360>
creator = 'snoopyjc'
dependencies = []
files = []
hgrepos = []
issue_num = 39661
keywords = []
message_count = 2.0
messages = ['362140', '362156']
nosy_count = 2.0
nosy_names = ['vinay.sajip', 'snoopyjc']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue39661'
versions = ['Python 3.7']

[snoopyjc]

TimedRotatingFileHandler doesn’t handle the switch to/from DST when using daily/midnight rotation. It does not adjust the rollover time so the rollover will be off by an hour.

Parameters: when=‘midnight’, utc=False

[snoopyjc]

Never mind. I was looking for the DST code in computeRollover, and I found it in doRollover.