feat(chronos): add date/time handling module#74
Merged
Conversation
This ports existing code and tests (and adds new tests to achieve 100% coverage) from existing projects.
Copying relevant comment from commit by mgeisler: Before, dates were saved as 2015-03-31 12:46:23 +0000 in Mongo. This format is not the real ISO-8601 format, which looks like 2015-03-31T12:46:23Z The crucial difference is that Firefox (Iceweasel version 31.5.0) won't parse the almost-ISO-8601 format dates. This lead to missing dates in the UI.
Contributor
There was a problem hiding this comment.
If this format, and these utilities, comply with ISO-8601, maybe leave a note/comment/documentation about that.
Contributor
Author
There was a problem hiding this comment.
Updated the commit message :-)
Contributor
|
LGTM |
larsbutler
added a commit
that referenced
this pull request
Aug 3, 2015
feat(chronos): add date/time handling module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports existing code and tests (and adds new
tests to achieve 100% coverage) from existing
projects.