Multi-object group selection (iD-style)#17
Open
tordans wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Als GoMap-Nutzer/in, möchte ich mehrere Kartenobjekte zu einer temporären Gruppe zusammenfassen und gemeinsam bearbeiten können, damit ich mehrere POIs oder Wege effizient verschieben und deren Attribute in einem Durchgang anpassen kann — ähnlich wie im iD-Editor.
Aktuelles Verhalten: Beim Anklicken eines Objekts erscheint ein Tooltipp (Pushpin) mit Verschiebe-Symbol; es ist immer nur ein Objekt ausgewählt. Attribute bearbeiten betrifft nur dieses eine Objekt. Es gibt keine Möglichkeit, mehrere Objekte zu gruppieren, gemeinsam zu verschieben oder Tags mit Konfliktbehandlung („mehrfache Werte") zu pflegen.
Gewünschtes Verhalten:
Implementation notes (by Cursor)
Branch:
feature/multi-object-group-selectionPlan doc:
docs/plans/multi-object-group-selection.mdThis PR adds the feature plan; implementation follows in subsequent commits on this branch.
Architecture
selectedNode/Way/Relationto an orderedSelectionGroup: [OsmBaseObject]onEditorMapLayer/MapView. KeepselectedPrimaryas anchor (first member / pushpin target).GroupSelectionBarat top of map — member chips (preset/geometry icons) in selection order, + for add modes.Map & pushpin
friendlyDescription(); group → localized “Group” + existing move handle.dragMove/dragFinishto translate all member geometries together (with undo grouping).Attributes (POI)
POITabBarControllertakes multiple selections; merge tag dict per key.(object → value)(iD-style).commitChanges()applies changes to every group member.Suggested phases
Key files
EditorMapLayer.swift,EditorMapLayer+Edit.swift,MapView.swift,PushPinView.swift,MainViewController.swiftPOITabBarController.swift,POICommonTagsViewController.swift,POIAllTagsViewController.swiftGroupSelectionBar.swift, multi-value tag presenterTesting notes (by @tordans)
Gruppe anlegen & Leiste
Mitglieder hinzufügen
Verschieben
Attribute (Mehrfachbearbeitung)
Regression
Made with Cursor
Note
Low Risk
Documentation-only change with no production code or behavior impact.
Overview
This PR only adds
docs/plans/multi-object-group-selection.md— a design/planning write-up for iD-style multi-select editing. No application code ships here (SelectionGroup,GroupSelectionBar, etc. are not in the tree yet).The doc spells out how selection would move from single-object to an ordered group on
EditorMapLayer/MapView, a top group bar with add/batch-add modes, group pushpin/move, merged tag editing with “Multiple values” conflict UI, and phased rollout across editor/POI files. It also lists open questions (group size, persistence, relations).Reviewed by Cursor Bugbot for commit 978eea8. Bugbot is set up for automated code reviews on this repo. Configure here.