Skip to content

[AIRFLOW-533] Delegate setting autocommit in insert_rows to set_autocommit#1813

Closed
thyming wants to merge 1 commit intoapache:masterfrom
thyming:fix-insert-rows-autocommit
Closed

[AIRFLOW-533] Delegate setting autocommit in insert_rows to set_autocommit#1813
thyming wants to merge 1 commit intoapache:masterfrom
thyming:fix-insert-rows-autocommit

Conversation

@thyming
Copy link
Copy Markdown
Contributor

@thyming thyming commented Sep 29, 2016

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

Per Apache guidelines you need to create a Jira issue.

Testing Done:

  • Unittests are required, if you do not include new unit tests please
    specify why you think this is not required. We like to improve our
    coverage so a non existing test is even a better reason to include one.

Reminders for contributors (REQUIRED!):

  • Your PR's title must reference an issue on
    Airflow's JIRA.
    For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
    issue Improving the search functionality in the graph view #1. Please open a new issue if required!
  • Please squash your commits when possible and follow the How to write a good git commit message.
    Summarized as follows:
    1. Separate subject from body with a blank line
    2. Limit the subject line to 50 characters
    3. Do not end the subject line with a period
    4. Use the imperative mood in the subject line (add, not adding)
    5. Wrap the body at 72 characters
    6. Use the body to explain what and why vs. how

@r39132
Copy link
Copy Markdown
Contributor

r39132 commented Nov 15, 2016

+1

@asfgit asfgit closed this in f34b292 Nov 15, 2016
alekstorm pushed a commit to alekstorm/incubator-airflow that referenced this pull request Jun 1, 2017
 Delegate setting autocommit in insert_rows to set_autocommit

Closes apache#1813 from thyming/fix-insert-rows-
autocommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants