Skip to content

Conversation

@shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Dec 17, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208996908465307/f

Description

Testing Steps

Note

When viewing as a URL you'll get some some additionally latency on images, that won't be present in the browser.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Dec 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Dec 17, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Dec 17, 2024

[Beta] Generated file diff

Time updated: Mon, 23 Dec 2024 21:48:13 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/en/new-tab.json
  • integration/pages/onboarding/dist/index.css
  • integration/pages/onboarding/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/en/new-tab.json
  • windows/pages/onboarding/dist/index.css
  • windows/pages/onboarding/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/en/new-tab.json
  • dist/pages/onboarding/dist/index.css
  • dist/pages/onboarding/dist/index.js

File has changed

@shakyShane shakyShane force-pushed the shane/ntp-customizer-presets branch from 634d60b to 6c6784c Compare December 17, 2024 21:17
Base automatically changed from shane/ntp-customizer-presets to main December 18, 2024 09:48
@shakyShane shakyShane marked this pull request as ready for review December 18, 2024 09:49
@shakyShane shakyShane requested review from a team and mgurgel as code owners December 18, 2024 09:49
@netlify
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit c1f1347
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6769da5ffa24680008c809f9
😎 Deploy Preview https://deploy-preview-1336--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane changed the title ntp: polish ntp: customizer polish 💅 Dec 18, 2024
@shakyShane shakyShane changed the base branch from main to 12-19-ntp_prep_a_re-usable_switch December 19, 2024 10:17
@shakyShane shakyShane mentioned this pull request Dec 19, 2024
8 tasks
Base automatically changed from 12-19-ntp_prep_a_re-usable_switch to main December 19, 2024 11:23
@shakyShane shakyShane force-pushed the shane/ntp-polish branch 4 times, most recently from c23662e to 6fc38ee Compare December 23, 2024 15:40
@shakyShane shakyShane changed the base branch from main to shane/ntp-auto-open December 23, 2024 15:40
mgurgel
mgurgel previously approved these changes Dec 23, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from shane/ntp-auto-open to main December 23, 2024 21:46
@shakyShane shakyShane dismissed mgurgel’s stale review December 23, 2024 21:46

The base branch was changed.

@shakyShane shakyShane merged commit ac1518c into main Dec 24, 2024
12 checks passed
@shakyShane shakyShane deleted the shane/ntp-polish branch December 24, 2024 09:14
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
* ntp: matching designs for customizer drawer

* re-enable tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants