ntp: prep a re-usable switch

[shakyShane]

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209013497841867/f

Description

Using the ‘rule of 3’ -> in the NTP I need a switch component. We already implemented a switch in Onboarding, and then again in DuckPlayer (because the DuckPlayer one was quite different). But now I need exactly the same as in Onboarding, so I’m takingn the time to make it re-usable.

NOTE: We’ve realised that we must not use globals for components we want to share - that’s why the refactored components works how it does. You must be able to configure the components where you use them, since some pages will have a mix of light+dark

Testing Steps

• Check the components view of Onboarding https://deploy-preview-1339--content-scope-scripts.netlify.app/build/pages/onboarding/?display=components

Checklist

Please tick all that apply:

• I have tested this change locally
• I have tested this change locally in all supported browsers
• This change will be visible to users
• I have added automated tests that cover this change
• I have ensured the change is gated by config
• This change was covered by a ship review
• This change was covered by a tech design
• Any dependent config has been merged

[netlify]

✅ Deploy Preview for content-scope-scripts ready!

Name	Link
🔨 Latest commit	99e501f
🔍 Latest deploy log	https://app.netlify.com/sites/content-scope-scripts/deploys/6763f02e394c1400088e1f8a
😎 Deploy Preview	https://deploy-preview-1339--content-scope-scripts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[shakyShane]

• ntp: customizer polish 💅 #1336
• ntp: prep a re-usable switch #1339 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

• Branch Name: pr-releases/pr-1339
• Commit Hash: f845fdf1db64417858f1c2ca0c458c31932f0c80
• Install Command: npm i github:duckduckgo/content-scope-scripts#f845fdf1db64417858f1c2ca0c458c31932f0c80

Please use the above install command to update to the latest version.

[github-actions]

[Beta] Generated file diff

Time updated: Thu, 19 Dec 2024 10:11:26 GMT

Integration

    - integration/pages/onboarding/dist/index.css

• integration/pages/onboarding/dist/index.js

File has changed

Windows

    - windows/pages/onboarding/dist/index.css

• windows/pages/onboarding/dist/index.js

File has changed

Apple

    - dist/pages/onboarding/dist/index.css

• dist/pages/onboarding/dist/index.js

File has changed

[mgurgel]

🏆