Skip to content

Add input files to React-Codegen script_phases#32755

Closed
sota000 wants to merge 1 commit into
facebook:mainfrom
sota000:export-D33007986
Closed

Add input files to React-Codegen script_phases#32755
sota000 wants to merge 1 commit into
facebook:mainfrom
sota000:export-D33007986

Conversation

@sota000
Copy link
Copy Markdown
Contributor

@sota000 sota000 commented Dec 14, 2021

Summary: Changelog: [Internal] Make the Reat-Codegen script_pahses only triggered when the in-app libaries are modified. When other libraries like ones inside node_modules are modified, you'll need to run USE_CODEGEN_DISCOVERY=1 pod install to update the source.

Reviewed By: cortinico

Differential Revision: D33007986

Summary: Changelog: [Internal] Make the Reat-Codegen script_pahses only triggered when the in-app libaries are modified. When other libraries like ones inside node_modules are modified, you'll need to run `USE_CODEGEN_DISCOVERY=1 pod install` to update the source.

Reviewed By: cortinico

Differential Revision: D33007986

fbshipit-source-id: 2e36dd821c701c3785e4ad8f6fd2077f99b3a4c0
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 14, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D33007986

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 9cd4092
Branch: main

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,293,042 +0
android hermes armeabi-v7a 7,623,655 +0
android hermes x86 8,763,620 +0
android hermes x86_64 8,702,530 +0
android jsc arm64-v8a 9,681,450 +0
android jsc armeabi-v7a 8,668,758 +0
android jsc x86 9,637,541 +0
android jsc x86_64 10,234,044 +0

Base commit: ad9eabe
Branch: main

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @sota000 in 959c6b7.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants