A framework for building native apps with React.
JavaScript Java Objective-C C++ Objective-C++ Python Other
Switch branches/tags
Clone or download
VSchlattinger and facebook-github-bot fix missing selection indicator lines (#18885)
Summary:
This PR is based on #13342 by pvinis and fixes #14442.

As suggested in the discussion on the PR mentioned above, I moved the code from `React/Views/RCTPickerManager.m` to the `initWithFrame` function in `React/Views/RCTPicker.m` and verified that it still fixes the problem.

Before the change in this PR the selection indicator lines are missing when the Picker is initially added to the View and only appear after changing to a different Tab and back. This happens both in the Simulator and my real device (iPhone 6S on iOS 11.3).

![beforechange](https://user-images.githubusercontent.com/7568362/38824104-7b294cae-41a8-11e8-8609-7a647ab3adb8.png)

After the change, the indicator lines always appear. I did not notice any side effects of this change when playing around with the Picker in different configurations.

![afterchange](https://user-images.githubusercontent.com/7568362/38824109-82a5b382-41a8-11e8-8af3-ca07c8b2c30e.png)

#13342 also fixes this issue but appears to be inactive.

[IOS] [BUGFIX] [PickerIOS] - Fixed missing selection indicator lines
Pull Request resolved: #18885

Differential Revision: D8945483

Pulled By: hramos

fbshipit-source-id: 2b6c6f42559691530b062503feb24bc305f4a8af
Latest commit e592d6f Jul 21, 2018
Permalink
Failed to load latest commit information.
.circleci remove useless config in circle ci (#19980) Jun 29, 2018
.github Update PULL_REQUEST_TEMPLATE.md (#19813) Jun 20, 2018
ContainerShip Bump Buck to v2018.06.25.01 (#19882) Jun 26, 2018
IntegrationTests Uniformizes how THIS_DIR is computed in xplat/js Jul 19, 2018
Libraries Fix `currentlyFocusedField` by Removing `this` usage in TextInputState ( Jul 20, 2018
RNTester Add FlatList and SectionList to Animated exports Jul 18, 2018
React fix missing selection indicator lines (#18885) Jul 21, 2018
ReactAndroid Fix overflow issue in root view Jul 20, 2018
ReactCommon Replace `YG_NODE_STYLE_PROPERTY_IMPL` macro with template Jul 19, 2018
ReactNative Fix conditional load usage. Jul 15, 2018
bots Prettier the rest of ReactNative May 11, 2018
flow-github Add open source Flow declaration for Metro module Jun 6, 2018
flow Jest: Upgrade Flow Definition in RN + Metro Jun 12, 2018
gradle/wrapper @allow-large-files [react-native][PR] Upgrade Gradle to 4.4 (#19899) Jul 4, 2018
jest Fix hasteImpl path checks on Windows machines Jul 17, 2018
keystores Apply auto-formatter for BUCK files in fbandroid. Feb 27, 2017
lib Prettier the rest of ReactNative May 11, 2018
local-cli BREAKING: metro: rename 'unbundle' to 'ram bundle' Jul 20, 2018
react-native-cli Prettier files with shebang May 11, 2018
react-native-git-upgrade Prettier files with shebang May 11, 2018
scripts Uniformizes how THIS_DIR is computed in xplat/js Jul 19, 2018
third-party-podspecs iOS OSS: update podspec's to target iOS 9.0 May 23, 2018
.buckconfig use android build-tools 26.0.2 and set compileSdk to 26 (#19662) Jun 13, 2018
.buckjavaargs limiting BUCK's memory for CI Feb 1, 2016
.editorconfig Fix indent of .gradle files Oct 19, 2016
.eslintignore Split out docs to their own repo Dec 5, 2017
.eslintrc RN: Ignore Unused Rest Property Siblings Jul 12, 2018
.flowconfig Flow v0.76.0 Jul 9, 2018
.gitattributes Added a .gitattributes file, ensuring that Bash script source files (… Oct 14, 2015
.gitignore OSS: ignore xcodeproj in root dir May 30, 2018
.npmignore Update .npmignore to include generated bundle file Feb 3, 2017
CODE_OF_CONDUCT.md Create CODE_OF_CONDUCT.md Oct 26, 2017
CONTRIBUTING.md Removed last traces of @providesModule from React Native Apr 26, 2018
DockerTests.md Typo in DockerTests.md (#20009) Jul 3, 2018
Jenkinsfile Container Testing Updates Apr 12, 2017
LICENSE Update to MIT license Feb 17, 2018
LICENSE-docs More licenses Mar 25, 2015
README.md add windows ci (#20281) Jul 19, 2018
React.podspec iOS: Support <ActivityIndicator> component May 23, 2018
Releases.md Fix Stable release date of 0.58.0 (#19751) Jun 16, 2018
appveyor.yml add windows ci (#20281) Jul 19, 2018
build.gradle Suppress lint errors in Dialog module. remove abortOnError=false (#19740 Jun 15, 2018
cli.js Prettier the rest of ReactNative May 11, 2018
gradlew Update gradle wrapper binary and scripts Sep 9, 2016
gradlew.bat Update gradle wrapper binary and scripts Sep 9, 2016
jest-preset.json Fix jest snapshot testing on windows May 31, 2018
package.json Bump metro@0.42.2 Jul 20, 2018
react.gradle Android - Fix Drawable v4 paths in Android Artifact Resources (Librar… May 1, 2018
rn-cli.config.js Update license headers for MIT license Feb 17, 2018
rn-get-polyfills.js Prettier the rest of ReactNative May 11, 2018
runXcodeTests.sh Uniformizes how THIS_DIR is computed in xplat/js Jul 19, 2018
settings.gradle Migrate Android sources to MIT license header May 31, 2018
setupBabel.js Prettier the rest of ReactNative May 11, 2018

README.md

React Native · Circle CI Status Build status npm version PRs Welcome

Learn once, write anywhere: Build mobile apps with React.

  • Build native mobile apps using JavaScript and React: React Native lets you build mobile apps using only JavaScript. It uses the same design as React, letting you compose a rich mobile UI from declarative components.
  • A React Native app is a real mobile app: With React Native, you don't build a "mobile web app", an "HTML5 app", or a "hybrid app". You build a real mobile app that's indistinguishable from an app built using Objective-C, Java, or Swift. React Native uses the same fundamental UI building blocks as regular iOS and Android apps. You just put those building blocks together using JavaScript and React.
  • Don't waste time recompiling: React Native lets you build your app faster. Instead of recompiling, you can reload your app instantly. With hot reloading, you can even run new code while retaining your application state. Give it a try - it's a magical experience.
  • Use native code when you need to: React Native combines smoothly with components written in Objective-C, Java, or Swift. It's simple to drop down to native code if you need to optimize a few aspects of your application. It's also easy to build part of your app in React Native, and part of your app using native code directly - that's how the Facebook app works.

The focus of React Native is on developer efficiency across all the platforms you care about - learn once, write anywhere. Facebook uses React Native in multiple production apps and will continue investing in React Native.

See the official React Native website for an introduction to React Native.

Supported operating systems are >= Android 4.1 (API 16) and >= iOS 8.0.


Getting Started

Follow the Getting Started guide. The recommended way to install React Native depends on your project. Here you can find short guides for the most common scenarios:


Documentation

The website’s documentation is divided into multiple sections.

Another great way to learn more about the components and APIs included with React Native is to read their source. Look under the Libraries/Components directory for components like ScrollView and TextInput, for example. The RNTester example is also here to demonstrate some of the ways to use these components. From the source you can get an accurate understanding of each component’s behavior and API.

The React Native documentation only discusses the components, APIs and topics specific to React Native (React on iOS and Android). For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.


Upgrading

React Native is under active development. See the guide on upgrading React Native to keep your project up-to-date.


Contributing

Read below to learn how you can take part in improving React Native.

Code of Conduct

Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please read the full text so that you can understand what actions will and will not be tolerated.

Contributing Guide

Read our contributing guide to learn about our development process, how to propose bug fixes and improvements, and how to build and test your changes to React Native.

Beginner Friendly Bugs

We have a list of beginner friendly issues to help you get your feet wet in the React Native codebase and familiar with our contribution process. This is a great place to get started.


License

React Native is MIT licensed.

React Native documentation is Creative Commons licensed.