Fix nil error in Analytics.last_month#52
Merged
Conversation
Use Hash#dig for nil-safe nested hash access instead of chained bracket lookups, which raised NoMethodError when analytics[ont] was nil. Defaults to 0 views and logs a debug message when data is missing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 67.21% 66.48% -0.73%
==========================================
Files 29 29
Lines 915 919 +4
Branches 172 174 +2
==========================================
- Hits 615 611 -4
- Misses 300 308 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analytics[ont][:"#{year_num}"][:"#{month_num}"]) withHash#digto preventNoMethodErrorwhenanalytics[ont]is nilLOGGERconstant for structured loggingTest plan
Analytics.last_monthreturns results without errors when all ontology data is presentanalytics[ont]is nil for some ontologies🤖 Generated with Claude Code