Add model client sessions #9102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove OnceLock-backed ModelClientSession from TurnContext and create a new session per turn/compact run. Pass the session explicitly into try_run_turn and use it for streaming, avoiding shared mutable state.
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct ModelClientSession { |
Collaborator
There was a problem hiding this comment.
Why do we have identical structs ModelClientSession and ModelClient?
Collaborator
Author
There was a problem hiding this comment.
ModelClientSession will have more per-session state in the future (like websocket) connection in addition to the more generic state of the client.
aibrahim-oai
approved these changes
Jan 13, 2026
Adds an extremely minimal websocket-based client for Responses API. This PR doesn't implement many things (like long running sessions, model etags, usage) etc. It's mostly setting up a place to iterate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain a long-running session.